From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB274C61DB3 for ; Thu, 12 Jan 2023 13:25:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g1QVVm1Y9NlcRtjTvnyccCPkBwkYXnNYSIx2X7N+7hc=; b=uPdYF2zneH5cKV pTie9CujYR89wUq7s7vik5KCUXcNg9B7hEEnElC9RDQ7dS5dXiofS3uY5nFb76srOYOiIWPMm50Gd SAPk1Sm6tqN05fq5u69npy26PXlDh0gxOJFwdbSbRpAW7q74MQ3c91v0/DdEn6V2ZRTD/97qnYL54 POf6dSQiu5NshuSq9f986PEhgJ9HDcjv2X9jcxc8GAbhTnNH9+ZkDjPbsiRPtBaU/UEALw8jck3/X xOAo2deNrKiaQy+z+7VSP8MMknZOee40e6xkFlNUzOnJejwgT+SZl2dPIgXsZGQ+etjiDSx7b7BLk MWqdtGK0lmnLgeNImFbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFxZg-00F8oP-N4; Thu, 12 Jan 2023 13:24:57 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFxZd-00F8n3-6S; Thu, 12 Jan 2023 13:24:54 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ADD1961AB8; Thu, 12 Jan 2023 13:24:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13E64C433D2; Thu, 12 Jan 2023 13:24:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673529891; bh=0zSlVdYnPlbeNYKtpgCs0o57tBG0cbE87Ki1QmaP4YM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Waya4oOTGc/ruH/oPImj1IC6j6yg1CShhpqNMoexocftc7u43r/3dnDLXBYzw52p5 q/8Sf1poFhpD36FOwMnfSb0I/thmR/cgN5bLo72F9k14o0wY/SLvyjB/n+KgH+1Nhv XbyJb0xONCyr+Ah/iSpkMaTGlceoCXaP/w86xG9aWzlUlfVyIYAnfqh8SVF/EiqlfF oamFvinesWSFSamkc2Hu79ua827T0ZKcABEyx+2i7/IYeLNNDpntxOztWfdfXDxG/Q aBJETlWkC9h++bhC+vvVvEWLLSfPF5+ekBRVbmGad8Z5KsLzBNRoRQzyThMJjbJOkR EeTIiH4GrgRmw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pFxZh-0001fB-IY; Thu, 12 Jan 2023 14:24:58 +0100 Date: Thu, 12 Jan 2023 14:24:57 +0100 From: Johan Hovold To: Thomas Gleixner Cc: Johan Hovold , Marc Zyngier , Hector Martin , Sven Peter , Alyssa Rosenzweig , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] genirq/irqdomain/msi: Add irq_domain_alloc_irqs_affinity() wrapper Message-ID: References: <20221213140844.15470-1-johan+linaro@kernel.org> <20221213140844.15470-3-johan+linaro@kernel.org> <87358ggayt.ffs@tglx> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87358ggayt.ffs@tglx> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230112_052453_326159_C8F52482 X-CRM114-Status: GOOD ( 18.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 11, 2023 at 07:52:42PM +0100, Thomas Gleixner wrote: > On Tue, Dec 13 2022 at 15:08, Johan Hovold wrote: > > The full __irq_domain_alloc_irqs() interface was initially only intended > > for some legacy (x86) use cases while most callers should use the > > irq_domain_alloc_irqs() wrapper. > > > > Add a matching irq_domain_alloc_irqs_affinity() wrapper that can be used > > when an affinity hint needs to be provided and use it for MSI > > allocations. > > I definitely like the irqchip cleanup, but this one is core code and > having the extra wrapper is not really buying us much. Fair enough. If you don't expect there to be any further users then perhaps it's not worth it even if it arguably makes the call site a bit more readable (e.g. by dropping the base and realloc arguments). Johan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel