From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3C1FC61DB3 for ; Thu, 12 Jan 2023 14:01:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+Khl9Rax09QOeNc77I1o9bHF8agr8NpGXjXDDc9rYPo=; b=LxnyaVY6SE6p7s Ck3QFkroBUQ582yO/Fojts3RoPY2HV8dqVi4DZwSNa5SBv87bxeEZHO5S628un37Cmz8JkhvPc8Vd o9cIV9UCJToOg5APea5bBJwZ1Etp5PjwnQV0K3fs7n7CxHFg0cU+uVNEeo8cExuvQ4X+Clf4tfYZo IoIHauF5pk/HCc5ekhN8G9vLap77X8QUTHiiIP9uJcqSFXQki6NMpq5c9pwTV4qz/4z5/44yOTieD o9Pnn6j/8D9bgGbe/9ldsv49/4NvNLNm2DPPTQkIler2JyQLP5TxhbTGG82aJm2V/HiZNsNKqtIJ0 uV0p4W3CQ9xYkFj0oxlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFy7f-00FGwc-Vo; Thu, 12 Jan 2023 14:00:04 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFy7c-00FGvP-Pc for linux-arm-kernel@lists.infradead.org; Thu, 12 Jan 2023 14:00:02 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2C32F13D5; Thu, 12 Jan 2023 06:00:40 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.43.206]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 18F3B3F67D; Thu, 12 Jan 2023 05:59:56 -0800 (PST) Date: Thu, 12 Jan 2023 13:59:54 +0000 From: Mark Rutland To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon Subject: Re: [PATCH V7 4/6] arm64/perf: Add branch stack support in struct pmu_hw_events Message-ID: References: <20230105031039.207972-1-anshuman.khandual@arm.com> <20230105031039.207972-5-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230105031039.207972-5-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230112_060000_894665_19DF9FD7 X-CRM114-Status: GOOD ( 18.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 05, 2023 at 08:40:37AM +0530, Anshuman Khandual wrote: > This adds branch records buffer pointer in 'struct pmu_hw_events' which can > be used to capture branch records during PMU interrupt. This percpu pointer > here needs to be allocated first before usage. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Mark Rutland > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual This looks fine, but it's difficult to review this without seeing how its lifetime is managed, and it feels like this should be folded into a subsequent patch which manages that. Thanks, Mark. > --- > include/linux/perf/arm_pmu.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/linux/perf/arm_pmu.h b/include/linux/perf/arm_pmu.h > index 64e1b2594025..9184f9b33740 100644 > --- a/include/linux/perf/arm_pmu.h > +++ b/include/linux/perf/arm_pmu.h > @@ -44,6 +44,13 @@ static_assert((PERF_EVENT_FLAG_ARCH & ARMPMU_EVT_47BIT) == ARMPMU_EVT_47BIT); > }, \ > } > > +#define MAX_BRANCH_RECORDS 64 > + > +struct branch_records { > + struct perf_branch_stack branch_stack; > + struct perf_branch_entry branch_entries[MAX_BRANCH_RECORDS]; > +}; > + > /* The events for a given PMU register set. */ > struct pmu_hw_events { > /* > @@ -70,6 +77,8 @@ struct pmu_hw_events { > struct arm_pmu *percpu_pmu; > > int irq; > + > + struct branch_records *branches; > }; > > enum armpmu_attr_groups { > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel