Re: [PATCH v3 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format

From: Tony Lindgren <tony@atomide.com>
To: Rob Herring <robh@kernel.org>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-omap@vger.kernel.org, linux-pwm@vger.kernel.org,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Nishanth Menon" <nm@ti.com>,
	"Vignesh Raghavendra" <vigneshr@ti.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: pwm: Allow decimal format in addition to hex format
Date: Fri, 13 Jan 2023 09:06:06 +0200	[thread overview]
Message-ID: <Y8EC3jB2317ohUIB@atomide.com> (raw)
In-Reply-To: <20221127182232.GA128974-robh@kernel.org>

Hi Rob,

* Rob Herring <robh@kernel.org> [221127 18:22]:
> On Wed, Nov 23, 2022 at 08:58:54AM +0200, Tony Lindgren wrote:
> > * Rob Herring <robh@kernel.org> [221123 02:31]:
> > > On Tue, Nov 22, 2022 at 02:32:24PM +0200, Tony Lindgren wrote:
> > > > --- a/Documentation/devicetree/bindings/pwm/pwm.yaml
> > > > +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml
> > > > @@ -13,7 +13,7 @@ select: false
> > > >  
> > > >  properties:
> > > >    $nodename:
> > > > -    pattern: "^pwm(@.*|-[0-9a-f])*$"
> > > > +    pattern: "^pwm(@.+|-[0-9a-f]+)?$"
> > > 
> > > So now pwm-10 could be either?
> > 
> > Yes.
> > 
> > > I'm fine with decimal, but can we do that everywhere we do this -N 
> > > naming?
> > 
> > Do you mean the '[0-9a-f]' users that don't use '[0-9af]+'?
> 
> No, I mean for all cases of <nodename>-N, can be we consistent. Either 
> we use hex or we use decimal.
>  
> > 
> > These can be found with:
> > 
> > $ find Documentation/devicetree/bindings/ -name \*.yaml | \
> > 	xargs grep pattern: | grep '\[0-9a-f\]' | grep -v '\[0-9a-f\]+'
> 
> Not quite. It's just cases of '-N':
> 
> $ find Documentation/devicetree/bindings/ -name \*.yaml |         xargs grep pattern: | grep '\-\[0-9a-f\]' | grep -v '\[0-9a-f\]+'
> Documentation/devicetree/bindings/phy/intel,combo-phy.yaml:    pattern: "combophy(@.*|-[0-9a-f])*$"
> Documentation/devicetree/bindings/pwm/pwm.yaml:    pattern: "^pwm(@.*|-[0-9a-f])*$"
> Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml:    pattern: "^timestamp(@.*|-[0-9a-f])?$"
> Documentation/devicetree/bindings/watchdog/watchdog.yaml:    pattern: "^watchdog(@.*|-[0-9a-f])?$"
> Documentation/devicetree/bindings/spi/spi-controller.yaml:    pattern: "^spi(@.*|-[0-9a-f])*$"
> Documentation/devicetree/bindings/rtc/rtc.yaml:    pattern: "^rtc(@.*|-[0-9a-f])*$"
> 
> 
> And there's probably some more in dtschema.

Looking at this again, not exactly sure still what you want..

Can you please post some initial patch maybe, verbal patches are
a bit tricky :)

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel