From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE99DC54EBD for ; Fri, 13 Jan 2023 15:49:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xFnMCUj3aM6N4IfULn2jLxESeD4hk+J3QHRJ1wibNvY=; b=b0kDPuiP64eDma BIo/xEDvHhlCRE5FhHTf6uW2X8T6865oDq0Q7dTx/Xa9v/nhYnPe9tkLPS2rdaJHNVnFY7isZlcNf uvDIYO6C+gFgpSKljFyAlBv6ielopxhdJvSVQCm7zDSqQukjos9kQzTGWiNuus9SQkSi7Z973hpL4 2CccwsOCZ4rboCW+7hbWpTqg+6jkpgvQJk2ilaq/UrLZOuJpmAFp9YDhlfFXTcqGKaNY0DfIYxtqF edlDw+6wHiFzpn+XiWAQOKv8pTKo5AfbxUdpEiA61izvfGWnYdZvBmvI+z/emxO3Gu/pCSjvrdP8b suEGB8BHbjr4Pj+I3V4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGMHb-003GAP-JG; Fri, 13 Jan 2023 15:47:55 +0000 Received: from mga18.intel.com ([134.134.136.126]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGMHX-003G9F-C8; Fri, 13 Jan 2023 15:47:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673624871; x=1705160871; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=drD33sAx5gjjcRkozsAJSrAFVmd5zo3pbQJ6aOlk0jQ=; b=QyXUlR4kLIwTogNl6lzXQ+FS82FkUYMQy3WyN/XIhZYQ63vAcMw3nXe+ W2FvGv9ORG6Rar2AOKVh5LYwTsIm8jQzwyUtg/8jUZJeGVcdQnLSk9ZQt 2ZXHJnOor7CLNQr1hiDg38CIW2iq44yEFyrdyKsI/GpZvozUPM3789LJj gNXKsQJow+9kBKl1bXsfdWLixddUvbeN43qkmehPrC0SXK502GXh5VNbC SxqMtpFS3r8t1nLD2wtRiDmiuZ26R/F1IOnLpR3rfuUcJiZPx+IOoCadL SrHB1EPbhP1WK8wGq6yz4T2t/Fk5Kw8tVGjPdqh7yVmkYkP0XY8WmZ2Zn w==; X-IronPort-AV: E=McAfee;i="6500,9779,10589"; a="307565082" X-IronPort-AV: E=Sophos;i="5.97,214,1669104000"; d="scan'208";a="307565082" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2023 07:47:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10589"; a="688784173" X-IronPort-AV: E=Sophos;i="5.97,214,1669104000"; d="scan'208";a="688784173" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.55]) by orsmga008.jf.intel.com with SMTP; 13 Jan 2023 07:47:40 -0800 Received: by stinkbox (sSMTP sendmail emulation); Fri, 13 Jan 2023 17:47:39 +0200 Date: Fri, 13 Jan 2023 17:47:39 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Sam Ravnborg Cc: Thomas Zimmermann , alexander.deucher@amd.com, christian.koenig@amd.com, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, patrik.r.jakobsson@gmail.com, thierry.reding@gmail.com, f.fainelli@gmail.com, james.qian.wang@arm.com, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 02/10] drm: Include where needed Message-ID: References: <20230111130206.29974-1-tzimmermann@suse.de> <20230111130206.29974-3-tzimmermann@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Patchwork-Hint: comment X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230113_074751_528095_EB1DF8D2 X-CRM114-Status: GOOD ( 17.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 13, 2023 at 04:11:48PM +0100, Sam Ravnborg wrote: > Hi Ville, > On Wed, Jan 11, 2023 at 06:08:42PM +0200, Ville Syrj=E4l=E4 wrote: > > On Wed, Jan 11, 2023 at 02:01:58PM +0100, Thomas Zimmermann wrote: > > > Include in source files that need it. Some of DRM's > > > source code gets OF header via drm_crtc_helper.h and , > > > which can leed to unnecessary recompilation. > > > = > > > In drm_modes.c, add a comment on the reason for still including > > > . The header file is required to get KHZ2PICOS(). The > > > macro is part of the UAPI headers, so it cannot be moved to a less > > > prominent location. > > = > > I never liked that KHZ2PICOS() thing in there. Maybe we should > > just nuke it and see if anyone notices? > https://github.com/search?q=3DKHZ2PICOS&type=3Dcode No idea what relevance any of those have. > = > tells me that it will be noticed. > So it is part of the UAPI The only thing it does it potentially mistake some modes for being equal when they are not. So basically just second guessing what the driver/hardware is actually capable of doing. -- = Ville Syrj=E4l=E4 Intel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel