From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B221C67871 for ; Sun, 15 Jan 2023 16:50:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eiV5jWiknoabCUAs64N2OXtVUuNH44qIQpQk1e1TqvQ=; b=yrVM/qZTjQ1kDO 1GoB+S3KJ88aNHzbPu/7slfps+qKU9T8TQiZBoCNKOD/Ohr8PJKe1a2C9OLsVaHIaK5F3Ar6Iqp5r mVaOZhUSxyUo7FuKsxZkgC+dxBgjbdsgatM10BzwA5u25u+jXJJHtNdAAiIVJ6AvzUMQ0Dwrnf7zQ Y7q1tW1q0tpWkYRp/IrCjIyHaTq30eLrmsdIIMseos+Gf6nniew4PJuoacnCD6Sx5cquZfdZLa3hZ dNq6RSG2oGfbOdX+GnZ2U2mGk0o/6eRIH/wurEw/WQasgsFNv6xNnzvLFb2SmrKB2HxfJGtuVpnSI rRCIjyj4FMXiq/9dBRxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pH6BS-007gKi-PW; Sun, 15 Jan 2023 16:48:38 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pH6BP-007gKH-A2 for linux-arm-kernel@lists.infradead.org; Sun, 15 Jan 2023 16:48:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=VDN4ZcMTm2XXAkD1jevXmk+JGFJznA8SYQizYocoJ/s=; b=k1ok4xo2PPrSDV/7QpXTR6DZia QKtxlY9//tK9r/oOITIKeymXmH+rZrKTFGZpfZ+fQxAcB9i52Eb3IzmZ4iUgcL1kE5dOpOwm2tl4f Lt+cO0pR8pxP0pRcI/zyPB4e9l/6xLLRBhWowufSOQyJgEJGAG1rUPrCP4kehve9Rxaw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pH6B0-0028s5-Av; Sun, 15 Jan 2023 17:48:10 +0100 Date: Sun, 15 Jan 2023 17:48:10 +0100 From: Andrew Lunn To: Kurt Kanzenbach Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Vijayakannan Ayyathurai , Wong Vee Khee Subject: Re: [PATCH net v1] net: stmmac: Fix queue statistics reading Message-ID: References: <20230114120437.383514-1-kurt@linutronix.de> <87fsccvy2o.fsf@kurt> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87fsccvy2o.fsf@kurt> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230115_084835_366654_61BBE140 X-CRM114-Status: GOOD ( 16.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jan 15, 2023 at 12:25:51PM +0100, Kurt Kanzenbach wrote: > Hi Andrew, > > On Sat Jan 14 2023, Andrew Lunn wrote: > > On Sat, Jan 14, 2023 at 01:04:37PM +0100, Kurt Kanzenbach wrote: > >> Correct queue statistics reading. All queue statistics are stored as unsigned > >> long values. The retrieval for ethtool fetches these values as u64. However, on > >> some systems the size of the counters are 32 bit. > > > >> @@ -551,16 +551,16 @@ static void stmmac_get_per_qstats(struct stmmac_priv *priv, u64 *data) > >> p = (char *)priv + offsetof(struct stmmac_priv, > >> xstats.txq_stats[q].tx_pkt_n); > >> for (stat = 0; stat < STMMAC_TXQ_STATS; stat++) { > >> - *data++ = (*(u64 *)p); > >> - p += sizeof(u64 *); > >> + *data++ = (*(unsigned long *)p); > >> + p += sizeof(unsigned long); > > > > As you said in the comment, the register is 32 bits. > > Maybe the commit message is a bit misleading. There are no registers > involved here. Ah! In that case, yes, unsigned long. Maybe reword the commit message to mention the values are being read from struct stmmac_txq_stats and struct stmmac_rxq_stats which use unsigned long. That would avoid my confusion of thinking it is being read from a register. With that change made, you can add my Reviewed-by. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel