From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6B1FC54EBE for ; Mon, 16 Jan 2023 18:15:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y2VcKYsTB9LUwrE16sRuempvTbYT8Q2u3OFY5F5TQng=; b=Sj2b08kubja5mb HG47XNBXQ3sD2YBNHUYMv+DYMhmPMKIV9B8iUqxY8ihGpbFUlW0Bkd8NnhWCFcOy62QJGKoWKMtfl ZHnJ5WT0BsGAx5AShSFET792sSX+vxMR74MRIttuyBgKTodQRL9IEzhkIJIR9t1mp44CMjrIP1N3h QDTggU2BFmpL1CGTOB+Q3Pwrzu+ltYStR7lDsqfc6FnTd2Bl2qh8PdBACEdL08U9ewX5FGlzm8YJz Jjh4FbD1hvxTgqYyn7W5KszHt3dybYzQGfuFkaoD0Debzaso6z3C2OjwWmDRC9M4BMjTyw//rC6kN uIt8zcnCSTlTcZuzhrpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHTzo-00Bg5r-A6; Mon, 16 Jan 2023 18:14:12 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHTzk-00Bg3I-7N; Mon, 16 Jan 2023 18:14:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=oZ/eIqVO5uQMasPeB15wvp3K//r6DTxoyyALad2UpFA=; b=aPBcR9TgPdrX8Re8IVHqBUFNUK XyNlwN0rPdVq/8bvRhdN3fuubtm/R2AaMXi6XE+rObMlbJUo3P/1o/UXtfhl86pFo/ZY4xChj2bSp zFnBEX90KCjYcXtuh4RsZL9JtcfiGpMdl+v2sAGyd98aYIVwJKZBW7/uinb/h7ti07Ps76lzsh9aD 494/TqDNMEQFctOU+FJgwXJ+lo1qdYzvsDmwo0Z+5SvmrPX1HJMz/Yd21t5M5TUKFOKzmATYp9j7f PB3wtuAUJdKSMKzDnaL4imf664WUh99ukXpuvglfwAb+447oafXyGAJsLwHIwBZYzQ0iW0mnbmupz dulPqpNg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:36144) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pHTzf-0005dC-ND; Mon, 16 Jan 2023 18:14:03 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pHTzc-0006Du-NE; Mon, 16 Jan 2023 18:14:00 +0000 Date: Mon, 16 Jan 2023 18:14:00 +0000 From: "Russell King (Oracle)" To: =?iso-8859-1?Q?Bj=F8rn?= Mork Cc: Frank Wunderlich , Frank Wunderlich , linux-mediatek@lists.infradead.org, Alexander Couzens , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: mtk_sgmii: implement mtk_pcs_ops Message-ID: References: <87h6wq35dn.fsf@miraculix.mork.no> <87bkmy33ph.fsf@miraculix.mork.no> <875yd630cu.fsf@miraculix.mork.no> <871qnu2ztz.fsf@miraculix.mork.no> <87pmbe1hu0.fsf@miraculix.mork.no> <87lem21hkq.fsf@miraculix.mork.no> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87lem21hkq.fsf@miraculix.mork.no> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230116_101408_287284_ADCFD262 X-CRM114-Status: GOOD ( 10.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 16, 2023 at 07:04:53PM +0100, Bj=F8rn Mork wrote: > Bj=F8rn Mork writes: > = > > [ 52.473325] offset:20 0x10000 > = > Should have warned about my inability to write the simplest code without > adding more bugs than characters. 20 !=3D 0x20 Ah, that kind of explains the lack of change in the values at offset 20! > [ 44.139420] mtk_soc_eth 15100000.ethernet wan: Link is Down > [ 47.259922] mtk_sgmii_select_pcs: id=3D1 > [ 47.263683] mtk_pcs_config: interface=3D4 > [ 47.267503] offset:0 0x140 > [ 47.267505] offset:4 0x4d544950 > [ 47.270210] offset:8 0x20 > [ 47.273335] offset:0x20 0x31120018 > [ 47.275939] forcing AN > [ 47.281676] mtk_pcs_config: rgc3=3D0x0, advertise=3D0x1 (changed), lin= k_timer=3D1600000, sgm_mode=3D0x103, bmcr=3D0x1200, use_an=3D1 > [ 47.292610] mtk_pcs_link_up: interface=3D4 > [ 47.296516] offset:0 0x81140 > [ 47.296518] offset:4 0x4d544950 > [ 47.299387] offset:8 0x1 > [ 47.302512] offset:0x20 0x3112011b > [ 47.305043] mtk_soc_eth 15100000.ethernet wan: Link is Up - 1Gbps/Full= - flow control rx/tx > [ 56.619420] mtk_soc_eth 15100000.ethernet wan: Link is Down > [ 60.779865] mtk_sgmii_select_pcs: id=3D1 > [ 60.783623] mtk_pcs_config: interface=3D22 > [ 60.787531] offset:0 0x81140 > [ 60.787533] offset:4 0x4d544950 > [ 60.790409] offset:8 0x1 > [ 60.793535] offset:0x20 0x3112011b > [ 60.796057] mtk_pcs_config: rgc3=3D0x4, advertise=3D0x20 (changed), li= nk_timer=3D10000000, sgm_mode=3D0x0, bmcr=3D0x0, use_an=3D0 > [ 60.810117] mtk_pcs_link_up: interface=3D22 > [ 60.814110] offset:0 0x40140 > [ 60.814112] offset:4 0x4d544950 > [ 60.816976] offset:8 0x20 > [ 60.820105] offset:0x20 0x31120018 > [ 60.822723] mtk_soc_eth 15100000.ethernet wan: Link is Up - 2.5Gbps/Fu= ll - flow control rx/tx That all looks fine. However, I'm running out of ideas. What we seem to have is: PHY: VSPEC1_SGMII_CTRL =3D 0x34da VSPEC1_SGMII_STAT =3D 0x000e The PHY is programmed to exchange SGMII with the host PCS, and it says that it hasn't completed that exchange (bit 5 of STAT). The Mediatek PCS says: BMCR =3D 0x1140 AN enabled BMSR =3D 0x0008 AN capable ADVERTISE =3D 0x0001 SGMII response (bit 14 is clear, hardware is supposed to manage that bit) LPA =3D 0x0000 SGMII received control word (nothing) SGMII_MODE =3D 0x011b SGMII mode, duplex AN, 1000M, Full duplex, Remote fault disable which all looks like it should work - but it isn't. One last thing I can think of trying at the moment would be writing the VSPEC1_SGMII_CTRL with 0x36da, setting bit 9 which allegedly restarts the SGMII exchange. There's some comments in the PHY driver that this may be needed - maybe it's necessary once the MAC's PCS has been switched to SGMII mode. -- = RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel