From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CA20C32793 for ; Wed, 18 Jan 2023 09:23:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6rtkYf/jT9EglNIH27cmnQcfMUCblzYCmr4nNJJufyw=; b=NijV2AhlprsTIo eTbB21GzVPS288vQ/HC7S7bpqxUrzIF7efWRPCXPyYl8rpFDSfpVHGod486LJLjBE1jfw/EirDr6P psgvByr2p2pQ0iew8mkoIYpJ8d7Li0cBFatLlHVGbVf7nld8wxTK6Zl8xuJYrYY2rDvaUhdfvcXEo +FwjK4WXEE6nSw1KX7t/CcBdrsH+IsCvm0T5FdOlTvqoMAgm0g8/zf+mskBaC32C1ALEMSXsHGx/B ND7HrjB6lXebkLU6WbuKeHKGWJ9eGmfI2ew+Umh0YxYJ7r93w4SF8nANSilQiGJ5DTPkz2YdqIfXT cHoCiVdeV9ss3QlAZCOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pI4e2-00053X-2D; Wed, 18 Jan 2023 09:22:10 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pI4dx-000519-PX for linux-arm-kernel@lists.infradead.org; Wed, 18 Jan 2023 09:22:07 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4BA18B81C0E; Wed, 18 Jan 2023 09:22:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6099C433F2; Wed, 18 Jan 2023 09:22:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674033723; bh=DZS895Z+3sptXir0tPzxTsJKKkNp6DzwiYVTcI+Nxas=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kQ7ipcJnCrbNJpn/1LWq84GZ6TR5qt3+KUz1dTKkr0XakM13mE2CdJADXrQLKwcR6 /Y3Z9lMY/yyTr/h9ZUnaD8+HXWyOE5ECHRk5Ms4N/Ok8HHvwCpTGqhjRA0VIalsHhM Me7LShijNUwJaJ0wWn8jIkIIhcRWdLmHJ1kRfvMXLLv6X71hv3leQfEbYu6u3h9QRe CgT19EWFPvSX+s3slPUT+xSyveq5YOLXegUVs4z8Ti9TPBsI0yH1Rys/JCC1QfWt8t ughKXZz3GlLkly1qj6aT0KSqaw88dFUiVD4evJ91gGUyuExYpTAmMoCAcYMW+RlnUq AdP1+leZLv+ng== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pI4eI-0001cJ-FS; Wed, 18 Jan 2023 10:22:27 +0100 Date: Wed, 18 Jan 2023 10:22:26 +0100 From: Johan Hovold To: Thomas Gleixner Cc: Johan Hovold , Marc Zyngier , x86@kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Hsin-Yi Wang , Mark-PK Tsai Subject: Re: [PATCH v4 06/19] irqdomain: Drop revmap mutex Message-ID: References: <20230116135044.14998-1-johan+linaro@kernel.org> <20230116135044.14998-7-johan+linaro@kernel.org> <871qnslut3.ffs@tglx> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <871qnslut3.ffs@tglx> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230118_012205_991554_21597364 X-CRM114-Status: GOOD ( 17.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 17, 2023 at 10:23:20PM +0100, Thomas Gleixner wrote: > On Mon, Jan 16 2023 at 14:50, Johan Hovold wrote: > > The global irq_domain_mutex is now held in all paths that update the > > revmap structures so there is no longer any need for the revmap mutex. > > This can also go after the 3rd race fix, but ... > > > static void irq_domain_clear_mapping(struct irq_domain *domain, > > irq_hw_number_t hwirq) > > { > > + lockdep_assert_held(&irq_domain_mutex); > > these lockdep asserts want to be part of the [dis]association race > fixes. They are completely unrelated to the removal of the revmap_mutex. No, they are very much related to the removal of the revmap_mutex. These functions deal with the revmap structures which before this patch were clearly only modified with the revmap_mutex held. The lockdep assert is here to guarantee that my claim that all current (and future) paths that end up modifying these structures do so under the irq_domain_mutex instead. > Your race fixes change the locking and you want to ensure that all > callers comply right there, no? I want to make sure that all callers of these function comply, yes. That's why the asserts belong in this patch. Johan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel