From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5636FC004D4 for ; Wed, 18 Jan 2023 09:31:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t0h5iRv4aiG4Lypy5Eot4Vfs5dhlwawyuBZtECihOQ8=; b=IgeA+4B/O4SkA3 UcasutooHIjxNFZSjqugp3y/VAISTclZD5I4aZ4fGjseGRlmmRkV42g+I+UMqOzaMNebophncix9a IGFBSzFoHbGFcNEHI1eh/WW+Z3dc1AUeW6oxoFPirGFQQd+JkrcmtA/IQESiXsoyAkkIrlvlx+0BQ rDxIrok/5kZbQoA+5Wz4IajHSlbyJDG1Daj2pfscNwhXwlzmOcRfz9eWN0SxVPy7B68WHdQlN1Rj4 H6+bAO5QFlOGJE7lBXXjlg1ixdozqU+plf7sV6wNCVT+tJo63DgDp/gz5xniJlknIHC5tPyO9XUyR wbZL3+IH/CG8jvS5V8og==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pI4lm-0007y9-TN; Wed, 18 Jan 2023 09:30:11 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pI4lk-0007x9-J1 for linux-arm-kernel@lists.infradead.org; Wed, 18 Jan 2023 09:30:09 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2BBD2B81C12; Wed, 18 Jan 2023 09:30:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C573EC433D2; Wed, 18 Jan 2023 09:30:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674034205; bh=3XyBFQNLnTyo9L+X0vrC5knpbLQfzzDd/EREfX7SuV8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MiOTsPzfhCtG5D2uMQmCk52l/VOS8fqxJvZPWk57KOq8xyLCHSOgS6UY4qI+N7kPI /JOk6EDQXbDnhyqJuIDv8wP9EfKfmhNa5WIaVYIF05q1YvJOEcOyYUjNYFEBrCDH9Y ItuJ+LdqkqD39zPRSoLHzSyaHNXURNNkWUZsGJs2erhOqDliW7SGP8I4WeeFLT1Y7R 7y3XZQHlKo4yxIgYBWQcFXtoigA0dKA0ioeiG7D4zLHgLO6HQPGL1GLnnfYDoLC7Ut AfrVDOuoOVdg+pGi/Cbi8sE+qokWA6U2JBzMGzMgLhpvlP0PSczfsxmiV2U4bp3GPN chX0f98MBfIEA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pI4m6-0001jE-0W; Wed, 18 Jan 2023 10:30:30 +0100 Date: Wed, 18 Jan 2023 10:30:30 +0100 From: Johan Hovold To: Thomas Gleixner Cc: Johan Hovold , Marc Zyngier , x86@kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Hsin-Yi Wang , Mark-PK Tsai Subject: Re: [PATCH v4 08/19] irqdomain: Refactor __irq_domain_alloc_irqs() Message-ID: References: <20230116135044.14998-1-johan+linaro@kernel.org> <20230116135044.14998-9-johan+linaro@kernel.org> <87v8l4kfpr.ffs@tglx> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87v8l4kfpr.ffs@tglx> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230118_013008_783968_1F0F090F X-CRM114-Status: GOOD ( 11.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 17, 2023 at 10:34:40PM +0100, Thomas Gleixner wrote: > On Mon, Jan 16 2023 at 14:50, Johan Hovold wrote: > > -int __irq_domain_alloc_irqs(struct irq_domain *domain, int irq_base, > > - unsigned int nr_irqs, int node, void *arg, > > - bool realloc, const struct irq_affinity_desc *affinity) > > +static int ___irq_domain_alloc_irqs(struct irq_domain *domain, int irq_base, > > + unsigned int nr_irqs, int node, void *arg, > > + bool realloc, const struct irq_affinity_desc *affinity) > > __ vs. ___ is almost undistinguishable. > > irq_domain_alloc_irqs_locked() nicely explains what this is about, no? Yeah, wasn't too happy about those three underscores either, but with the exported function unfortunately already having a double underscore prefix... I'll try switching to a 'locked' suffix instead. Johan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel