From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 240ACC46467 for ; Wed, 18 Jan 2023 13:57:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XGrsxOXgne856ALjpuUHnfkuxf2gR0ZRyjTeMCProWQ=; b=kuHWk7LvLDLJ5r I6jVoULSK7ltfydPhJ7VYrVgtfpI2GguasNOsOlZWNwdPnalQQfd/+1vinclOKjiGm7WgKXi/p88Y BOzJWrmqx2W7sXxPwA3ca8axs9UHQdE6avhozn3MJxbR4nb4BdD1Ra0nbkhjdAuHCrCbKTJThxI0A 94m56SxgDeE8zpfm7M5RWgG6fNMisy6c8x58voaiGJSHL95HRoiZKxOXU5wYvTjMzZeYakHhbBI2/ FfvlPeliWbx96eesn1jUAIGYyvLV7D+0pH+nia1pF0puMI3xQ00esSD/wepcdTq5LR1H4kUcgkldY S6RwiGRbG2J9HbiVWLsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pI8vI-001E2l-Bo; Wed, 18 Jan 2023 13:56:16 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pI8vD-001E11-Fw for linux-arm-kernel@lists.infradead.org; Wed, 18 Jan 2023 13:56:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1674050171; x=1705586171; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=dqgrCRmeHzQF29M6PcQRpGvYtYWHGY1aocV8Imilqxs=; b=pjcgXeGo4uFmgci2EWl7oTBH+WEB0B1cvKQZvh3Ol4CIDRWiyIpm6JvB JiLfFZXlK7mkvIYWetyppE2bb1W+E3BBG3FoP1xgp0K0H1mLqDo3n9Amb 5z9Q+y/M6ZLWMVT6DTDrNklqMfdiUppsVbnO6N+du0ehwuBoWn4WnruHN Ca8EzPaXDe5UGluDSSWYEAi7bTtZwY9fE6UJEAQpl1qYr1rfg1Bb6agYg Zy4XpDCUr+r1plIfb0k/wgznculYLxO7ISIB8VAWGj5F6gGjlYLj7OV2A 5KRWyfC1LtGpdPJEPLn3CK5Be29LkWb01EThs+sO/IgaSTsrzf/iN0R83 Q==; X-IronPort-AV: E=Sophos;i="5.97,226,1669100400"; d="scan'208";a="197156705" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 18 Jan 2023 06:56:10 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 18 Jan 2023 06:56:09 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 18 Jan 2023 06:56:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dG8x/v6HNQDWWptIxND2sN6WsZ/teeNuqsB56c58Nhu/ekry5B/pmez0jDJQUhEFIpr991NeiyWIpdCl00vR0kUD7V4e4k+llR5JXVbImE3FSzJgGbn4znXshBSd6uzxpWc6IjslA7XdyZQqHTa157+YhAr7UYe5QaeHkRjl3TnpXm+geHjMgfHOTUrV0sw1Mtf6rNeZG2+1/bPw2+8ifC9wELsbj9IXF71Umip+5AJmVcletXREnkaHSnPR5sm94Lks6Zx6pW6MHnEqvvvYHJFEyffDMy4cynSraU8JlT3fJ2jfGRVrgIOjX1zIN284hK6/mFM445oIRtpsd/Ou1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oUPLKTr4Fu5Foo2s+u1mn3EIctUgwa0eaUfesOXMIt8=; b=argLP3KChGCqiofMFXcHZZSYxKPn5OM9dNiE2fs3nDS62qm1S0sO4UyR1haJnU2OnOAvvh9n8n6ZBNOKQLsayho9hCWGkqidVbIum8yEWmKAA9U6sWNGY5y2cqJ6CUKkI6EgkcPeCxGwM30K+BPoVq9UJr2fhPvg0n9lR/ZlYmvarDR3+5GgOOmJiM92Rxyzu+nJVL60jUy0bMofdDQKGtwhzwSh5wyX91Mq9t2nitmJxo0KwZpMm2s55BSt++d1aPmKlbJqmGegJ++jsvW2OtDNA7BCu83wOQTyDW+jV/ZC6SWbT2GQpQO5bYpvdK0b8P8inQSNdsWLIriFigX6JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oUPLKTr4Fu5Foo2s+u1mn3EIctUgwa0eaUfesOXMIt8=; b=IdsN8eGnEI9XVvikNZYvCJyCeAGA8MTDNThnJmFm80uXo3RpNfIkuWPHCaOHfHwZw+1r4FdirLs+9rfD7CsooynohX4sGDGg8sPKgzS66oMXLzF9edMlI1d3RO/MiMwQNkHXV9M7dJ2OOQx5YQ2toHrVERYSGZu1IdkbAVe0tvM= Received: from CO6PR11MB5569.namprd11.prod.outlook.com (2603:10b6:303:139::20) by IA1PR11MB7812.namprd11.prod.outlook.com (2603:10b6:208:3f7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.23; Wed, 18 Jan 2023 13:56:07 +0000 Received: from CO6PR11MB5569.namprd11.prod.outlook.com ([fe80::8155:464d:11a2:a626]) by CO6PR11MB5569.namprd11.prod.outlook.com ([fe80::8155:464d:11a2:a626%7]) with mapi id 15.20.6002.024; Wed, 18 Jan 2023 13:56:07 +0000 From: To: CC: , , , , , , , , , , , , , , , Subject: Re: [PATCH net-next v2 2/6] net: dcb: add new common function for set/del of app/rewr entries Thread-Topic: [PATCH net-next v2 2/6] net: dcb: add new common function for set/del of app/rewr entries Thread-Index: AQHZKbnEKv6IsE6w70C8Q9TlPGBnVK6j+1CAgAAKK4CAADBJAA== Date: Wed, 18 Jan 2023 13:56:07 +0000 Message-ID: References: <20230116144853.2446315-1-daniel.machon@microchip.com> <20230116144853.2446315-3-daniel.machon@microchip.com> <87cz7cw1g5.fsf@nvidia.com> <874jsow1b6.fsf@nvidia.com> In-Reply-To: <874jsow1b6.fsf@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR11MB5569:EE_|IA1PR11MB7812:EE_ x-ms-office365-filtering-correlation-id: 00f915c3-4d32-4378-8290-08daf95bbf65 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /KfJaegDhPjR9zvjQZT6USOOzl9SAVqeF/poVoJ7M1GNt+dXzh1kVriiwD9SX7bgGDKmDJqgoEtC15ZK95lRkqVnWT4NfTDFRpLfWZXx4f62J3Yl0MKwcB0KvI6z3CNuly276s0vyryFhD84EbinWANW8d0f12RdyJyyewao7a6Msq3N3VyJgciWAEaIiBezOrdI2erxLvEH889O3vcyeg6Tl1SG5M5e1PdRuMBWaToaDp5wni1/fiNcN0O+12sFAmNqbr0bg4glBfCoR2+Evbt/AndY1a8LeI2GBPqH26RbdYn4eUUhaIk7I+SvsjcUdtpeGNzHvTfrMamRnmdV4sx0VxyVkPWc63PKDp76v2OFdFSwwOcn3d3LlM8JkGhSSag1EBW166TGLsXRJTFpL6iD1dtV55x/MwnSfD86DlR7RhRigRrds342vSOxHuIo9VYXy5Xq5XIixoQTbBaZ+NbIie2cthENeWisSQrit47zuKwUX+WEWryJ8MnMPLj4L46n6laU5yBUQeywAvFpXrRgOOOEa8/5qtgcc3Iy4wouQ08yM35vASLzmQX9NFlhZMpOPlVPefCrChm2QXMParA49csbPfAydsLubE1PJPo1tXpc/U3rAPunxf93PN7VWH/BWe4jBidFr2IdC68GIJRyn/MkoMvFQl8THmbTPaPQHrFoib5DGFa5Zo+0uBJmBrK/PGDOtGktMZobO3pVwg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO6PR11MB5569.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(396003)(366004)(346002)(376002)(39860400002)(136003)(451199015)(122000001)(6916009)(54906003)(71200400001)(66556008)(91956017)(6506007)(6486002)(86362001)(4326008)(8676002)(6512007)(9686003)(66946007)(66446008)(76116006)(186003)(26005)(66476007)(64756008)(38100700002)(33716001)(7416002)(2906002)(38070700005)(5660300002)(316002)(478600001)(83380400001)(41300700001)(8936002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ikSHJ7JUpOE3xyhR8MIRRums6PTlcQm5ZIqr5IdZIN6xpzsP7N1SqBoNJ+5d?= =?us-ascii?Q?Sd3qB2JKT7mmr3UB2E05HOFKeBx1zciS4iyNUB5ln8V1YbBgWtrP1/2+vJFw?= =?us-ascii?Q?M6ktxBAfUu5/yaiECVAXOSuyyJsJ2vN4A2WtL2YM73gP1/KLXsbvOK4N+bdp?= =?us-ascii?Q?lcLiuM/iBxIWeGkkGElkwTbe2rR/ILKk/9025Hg2AsHLfa0PwVPc2MXroj1+?= =?us-ascii?Q?eXBnc0YnHuRu2jV5V6AX8aEa2NPKk8r8kBxyzlhkuD27F6BNgmeLndSSVm39?= =?us-ascii?Q?nn0lNHeI3JA3yg3jbRAxe/HaHXnKtiWes/GZFLuAK3Stq1Nkf1qCn9hQ+pkF?= =?us-ascii?Q?TrROum7oeUpbRQsd5OkTW/eZvYMPEE9KzmBHYWDsm2NxZvk82sQ4AHJrJVjI?= =?us-ascii?Q?B5nQBO+lfYd0VnL7xzVt4+c2qlIn0H1sSeoRFJq/R7PildgSPyJD306xLpaL?= =?us-ascii?Q?lmJ8jvCbUGgb72WKskhTVVMZBASEHoORmHDdHIaPi0btY1s1keI880KCqVK9?= =?us-ascii?Q?ZahsBVlctLX59+gEzjzr/wkNJsziFzauWpfh422UnET9wP9bHmf9iOr/VR1k?= =?us-ascii?Q?RGREH3kggwxrlfKG369fokYDcHiKvzpNwkih5h8YO3V5c3iv94y+OZVB/G1H?= =?us-ascii?Q?yk+J0Kv9nXSm0MasocbfgTyiM5MDjpo1JO42Jnky5RH7wORzuz7IozPP8NgV?= =?us-ascii?Q?RHX4hql91WE9aDjPDdtvtH6EHoU5ZRYarO7FQAWgomiguLM4Fp/amxd7JZO/?= =?us-ascii?Q?Zlu+IZvU9gkevKgd6SAZMpNrVBvRJIqyVCAfwqWdQwinfCRGQ5PudqtHBJEc?= =?us-ascii?Q?azLnQK0VW3Ii7ySFr/W0wTQaQ0gNg3Zo++IAwJ8xFn8GhORseXtLGNTzgC3j?= =?us-ascii?Q?jnCqYNbHXSWH8/fsR8C66v7g3Fy7YvHqnH4NGdoY0bwIHaTyWuD+WtkX9akL?= =?us-ascii?Q?72tRS2YDAOrw1jD+N8XWnlvjdP8S4l2SoY7rmogjT9s2F3uV8Cmi2m7/508J?= =?us-ascii?Q?pFkCCNpymR6wPxComm/5Lw3BK1j2kTdvGdEz5J9wRcqSKoptZhQfnvJY2OBn?= =?us-ascii?Q?KW3mcdlWZP1TkQpcU+mh2/vleQpKYYtcCJlD+huElz8xNP3cQCZIAq9P91kv?= =?us-ascii?Q?ZQYWSZPtArvAC9AUoxs935sgqagiH23R8OwaKYlI84pOvBsl5O2RODn3oGP0?= =?us-ascii?Q?b5xnhAYQJmQrRPbMo3NAtXN8wWxTndcSG7tkmsuScInAOXrTz8Ugm0TufUAv?= =?us-ascii?Q?6gAIxJYkcZjatR3HyURj9QvjB0/DXES7D+Dyw3Iy2qiHbEq0wByjLEoJKK//?= =?us-ascii?Q?8b3eSEnzxzQR5rR97QqgSknZi5JkDlL3M/kLC2KHIxIUC+5XEvTZOitP/5b4?= =?us-ascii?Q?/ewM7/BvFFwzPEPVIbyrP3Ckcqie6a02bmYHTP4qUfywd6tv0nR3lXqVkw0F?= =?us-ascii?Q?woDqw1tKsOHeo7sd5TojwRJcRNH7C0tdSa/wNlPpEdpKz6EDtM20bCT3v4XL?= =?us-ascii?Q?hHxz7VJZozROSXLLsDHdP4PJDndChnFiajaxubKH96F0lwPzWmksbv1PzeYz?= =?us-ascii?Q?PbRPJ8OvOKGjrs4jiS9X0acAg1p0H/mlzu9a2lR1iKEXWHf7UOgn6t6dBRCJ?= =?us-ascii?Q?8KL7MF5jywgjDpQLVxbGlRM=3D?= Content-ID: <883D2D71D6146740ADD2A74A28764E16@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5569.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00f915c3-4d32-4378-8290-08daf95bbf65 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2023 13:56:07.4162 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rkWcsjhBw5yglkwhwnOjPZPKB23Wmcw5xk5q5xxmsjnjnfAM/d+HANImFfH5Te6FrI/vLiVjY2YR4af9j+D/yUUjP2gB6GzUcy8huU7ufqw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7812 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230118_055611_558595_FD05AC6A X-CRM114-Status: GOOD ( 19.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Petr Machata writes: > > > Daniel Machon writes: > > > >> In preparation for DCB rewrite. Add a new function for setting and > >> deleting both app and rewrite entries. Moving this into a separate > >> function reduces duplicate code, as both type of entries requires the > >> same set of checks. The function will now iterate through a configurable > >> nested attribute (app or rewrite attr), validate each attribute and call > >> the appropriate set- or delete function. > >> > >> Note that this function always checks for nla_len(attr_itr) < > >> sizeof(struct dcb_app), which was only done in dcbnl_ieee_set and not in > >> dcbnl_ieee_del prior to this patch. This means, that any userspace tool > >> that used to shove in data < sizeof(struct dcb_app) would now receive > >> -ERANGE. > >> > >> Signed-off-by: Daniel Machon > > > > Reviewed-by: Petr Machata > > ... though, now that I found some issues in 3/6, if you would somehow > reformat the ?: expression that's now awkwardly split to two unaligned > lines, that would placate my OCD: > > + err = dcbnl_app_table_setdel(ieee[DCB_ATTR_IEEE_APP_TABLE], > + netdev, ops->ieee_setapp ?: > + dcb_ieee_setapp); Putting the expression on the same line will violate the 80 char limit. Does splitting it like that hurt anything - other than your OCD :-P At least checkpatch didn't complain. /Daniel > > (and the one other). _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel