From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 297DBC32793 for ; Wed, 18 Jan 2023 10:32:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eSJmhvEstuzdIpdHWuE5DpGed8+lREW9/FKeN88L/Ac=; b=3eafT7czK6neiR OOvJ2vzpGwcw1MmSY/KNIXMKSWkpUgBHngavacwz/OOvnNTHV5ZP16PD7ozkN9t694lD6N9rCueiH +IB5uTdsk0AsfEIQy/PVFxBiqVbFrJ2cpOxH6j8CnTYMwpi89xruN+JXfHZV2f/ke8WzS9lgpYxVU bFazAMJ8cgWLb8EBLDgBwRW2wfWS2sa7kHO0MGDVJrLHski6EPF59Sm0+zFsr3UbMdV5YU2B6oIq2 ACVtXkcpLD/uarXdNxP5R+wf3MQhdsLFhWFtUooSk1vTD2sE174kF78t2qTS26p2JqUfN6bxf+mhP Wc6BAyGyf8Rv6PkscRkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pI5ie-000N3K-0u; Wed, 18 Jan 2023 10:31:00 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pI5ib-000N2E-DC for linux-arm-kernel@lists.infradead.org; Wed, 18 Jan 2023 10:30:58 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E6399B81C1E; Wed, 18 Jan 2023 10:30:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EDABC433EF; Wed, 18 Jan 2023 10:30:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674037854; bh=JESyVLEBRskcOn6pGiXUzE4QX0hziwBDIa4wVXsbNCA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fY97SJidlILMLeB4sgj157aP8uuTuwfnJ3d/HtvwBkbPYiHgwlpuWmXx90N3of1h0 uf/voAEVr0UlP89b+slzMHrEM3XCslwpk0/biuUMzwoanBCTAOQUPeXd9/WfBVWZa8 k3h1ra/S5PeiMKl1OXx5HGZ3eL7LOGliaqOEJ7StKCLQAFIsRQWog4pde6EJ+dR+m9 mCgBFSqMYTnfwqV6d2dMby9YBTewhHELGuF3S0e6O2wTeES1ytGvt7wqiDbbm079wV geSf3eNhTn6PXkvUFhO+BZT5QDyymNrapcgQpPj7UpoUB4STS42103uJdzpS5Vh+7W ylg9EEo9ickfg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pI5iw-000300-OB; Wed, 18 Jan 2023 11:31:18 +0100 Date: Wed, 18 Jan 2023 11:31:18 +0100 From: Johan Hovold To: Thomas Gleixner Cc: Johan Hovold , Marc Zyngier , x86@kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Hsin-Yi Wang , Mark-PK Tsai Subject: Re: [PATCH v4 11/19] x86/ioapic: Use irq_domain_create_hierarchy() Message-ID: References: <20230116135044.14998-1-johan+linaro@kernel.org> <20230116135044.14998-12-johan+linaro@kernel.org> <87pmbckfe7.ffs@tglx> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87pmbckfe7.ffs@tglx> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230118_023057_613642_BC4E23C8 X-CRM114-Status: GOOD ( 14.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 17, 2023 at 10:41:36PM +0100, Thomas Gleixner wrote: > On Mon, Jan 16 2023 at 14:50, Johan Hovold wrote: > > > > - ip->irqdomain = irq_domain_create_linear(fn, hwirqs, cfg->ops, > > - (void *)(long)ioapic); > > - > > + ip->irqdomain = irq_domain_create_hierarchy(parent, 0, hwirqs, fn, > > + cfg->ops, > > + (void *)(long)ioapic); > > The 80 character limit has been lifted quite some time ago. Please use > the 100 which are now the norm. Not everyone agrees, including coding-style.rst: The preferred limit on the length of a single line is 80 columns. Statements longer than 80 columns should be broken into sensible chunks, unless exceeding 80 columns significantly increases readability and does not hide information. I go above 80 chars when it improves readability, but it's still a soft limit for many of us. I'll change the above, but not sure trying too hard to fit everything in one line really improves things in cases like: - uv_domain = irq_domain_create_hierarchy(x86_vector_domain, 0, 0, fn, - &uv_domain_ops, NULL); + uv_domain = irq_domain_create_hierarchy(x86_vector_domain, 0, 0, fn, &uv_domain_ops, NULL); Johan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel