From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 376CDC32793 for ; Wed, 18 Jan 2023 11:31:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xcq+z++PQlQ1gHbtX8jrZYj2dhHngAp/3gf97tI4mhs=; b=TAy++1ZAoq348I YKzXVMiEomtHX9MiVgVxilJwTMkWB8ZYAD36j+6ee7XKmWtKmoB2vH7oE1KxnXjohPGT6I08gyL9H 97gGlYC500vcPxOLcl2ReITZiDoaIyuWEpNboUislBbj5tBh1vWyR/7743kYOovAah/M5KSD+Se/t bWDtSxGYof24E88G58X1dgGc6Bt/gslD58tEx/Xa7n0B9oixgzlZYMzwkgtYCtaxc+/REuUxA03Sg xtVhaVjjwdwngtYUj9qb3vKvkPh/1ty3U21dlPE/qSVUFTemYSEddDl080tDBiMjALDjbV127uong 5QQoeLJFsl7D2vz8V4KA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pI6e8-000XcT-Dq; Wed, 18 Jan 2023 11:30:24 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pI6dy-000XZl-L3 for linux-arm-kernel@lists.infradead.org; Wed, 18 Jan 2023 11:30:15 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3E95761784; Wed, 18 Jan 2023 11:30:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACCC4C433D2; Wed, 18 Jan 2023 11:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674041413; bh=wYh26QEkOVgnC4Jwvggs/1VX+pgdOvwPisiu0/vGJY4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MAmp3jigIdgpYoymR5GLeOKBDqILizSsosDi/KzYw/H31lh0VLIPZkbYthLUikjZ7 5WFS0KilKZaUm0M5yS11VHCCw6c+KB1yd6caqDBRo3pjKHAlCdBaVzgv9jj0Enadfb PPSCiLA6CQQI+aBd8GdKD3w8O/yjtgrUjwuuif0zSHGhFOP7rA0WHDTZ6r1jhDyI6n /YTfa8F42W8qCYUYBmJfgA7WjERHd5fIzP+QeKxJ0TBMM2winbxgkMTzxfwxGAhDUj SIA1gSM4L3Jr2NlPL5l2FaIfDrBtb68LnqEWflKle+EtLsHuLk0J2TRiLXVByGZZJV 9ufutYYnJhhQA== Date: Wed, 18 Jan 2023 13:30:06 +0200 From: Leon Romanovsky To: Siddharth Vadapalli Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, linux@armlinux.org.uk, pabeni@redhat.com, rogerq@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, vigneshr@ti.com, srk@ti.com Subject: Re: [PATCH net-next v3 1/2] net: ethernet: ti: am65-cpsw: Delete unreachable error handling code Message-ID: References: <20230118095439.114222-1-s-vadapalli@ti.com> <20230118095439.114222-2-s-vadapalli@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230118095439.114222-2-s-vadapalli@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230118_033014_762129_318FB0ED X-CRM114-Status: GOOD ( 12.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 18, 2023 at 03:24:38PM +0530, Siddharth Vadapalli wrote: > The am65_cpts_create() function returns -EOPNOTSUPP only when the config > "CONFIG_TI_K3_AM65_CPTS" is disabled. Also, in the am65_cpsw_init_cpts() > function, am65_cpts_create() can only be invoked if the config > "CONFIG_TI_K3_AM65_CPTS" is enabled. Thus, the error handling code for the > case in which the return value of am65_cpts_create() is -EOPNOTSUPP, is > unreachable. Hence delete it. > > Reported-by: Leon Romanovsky > Signed-off-by: Siddharth Vadapalli > --- > drivers/net/ethernet/ti/am65-cpsw-nuss.c | 5 ----- > 1 file changed, 5 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel