From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABD30C38142 for ; Thu, 19 Jan 2023 09:35:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VEbjPb4hF6EVhZnJvGTUWEy5Mk9OPSTi1yf0aYZ8WSg=; b=RxSwr82EjPcD4l x0KIHESCwAv1Lz8O/WHdoeVPIJKGw0UCFCtu3VUzfX1ZqZkkconP9xhoYZgxH24uhw8uhpFatwaH9 dT1gmhxRDvvTAYNloOJq44AVkXsaklsAV6jN3YjlySfM0ylgR3r/dJ8CTyN03iRbHvA4X1p7E0Vnw x2ROwJEC6c25LFWH8VBlXFcfdA2jk1wTnN6d7mhP0PVA5VmA1XkxgP5Nfq+ZajQEtAPGHiy8forKS J7MTSY+0s9hR6BxgoJsS6Mig2yp8K+x9wNWqN69GSNKDq7HKfgDaPaQLjxrrV6JYMMC065CqXizL5 ZnxfUCJem5vJY4Y2dSHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIRJR-004GZB-0x; Thu, 19 Jan 2023 09:34:25 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIRJO-004GXn-Im; Thu, 19 Jan 2023 09:34:23 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B96D66134F; Thu, 19 Jan 2023 09:34:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A385FC433D2; Thu, 19 Jan 2023 09:34:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1674120859; bh=cTYhWhuoAArfN8ATkC/1fHyyuIoz5/V7W6EqeQ81PU4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NXyrMIIwdo9UdtGF5a0iaSMpO6tagJ8WWBUxVwSHRBIjLSGvE+Oavb4ePMGPwdqxB 5nYP7pEBMNjs2Qar0Vj1npXLCKlZN+J8YCwSVyaEs5rCKIjSE1fvQq3KQoQiqku4vV zPJT33Koo7thoNF72zmUER2bBTs/gT/U09Zq0DYw= Date: Thu, 19 Jan 2023 10:34:16 +0100 From: Greg Kroah-Hartman To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Florian Fainelli , Adrien Thierry , Dan Carpenter , Dave Stevenson , Kieran Bingham , Laurent Pinchart Subject: Re: [RFC PATCH 0/4] Drop custom logging Message-ID: References: <20230118115810.21979-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230118115810.21979-1-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230119_013422_680461_F7789D75 X-CRM114-Status: GOOD ( 12.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 18, 2023 at 05:28:06PM +0530, Umang Jain wrote: > Drop custom logging from the vchiq interface. > Mostly of them are replaced with dev_dbg and friends > and/or pr_info and friends. Everything should be dev_*() calls, there should never be a pr_* call in a driver. > The debugfs log levels (in 4/4) are mapped to kernel > logs levels (coming from include/linux/kern_levels.h) > Would like some thoughts on it as I am not sure (hence > marking this is RFC) Do not have any "custom" debugging controls in a driver, they are not special and should follow the whole rest of the kernel. Just remove them all and rely on the existing dev_*() calls instead please. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel