From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9C48C004D4 for ; Thu, 19 Jan 2023 11:49:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YINJyu6y4aXjfylXwUILH1BTtOVKTPs3uOwxX6NJVSE=; b=p8OkzcSgBcGKLj ROg61WanRgR/SB8eNwgE/+O5qDlrMJeXuPrIWDm+rn0lw6tJwFqbaF6uaDl4VzAd/ce8nk2AIXCIS sFd3cGy5Wn/Y/EPA0nYZSfGKkoB+RbRIZd6EFxtJ4pOQlfDnkVzIYMky/A70AthOm+a8cFp5sSL5w rlM9SUUykPOh7lJo5cBNdmp04Rxhsda2QJekLLBGRfECYCpoZZiz8ZQTQCLIVMlcMt9KLo9N3CoJ+ pbOuwmYfRjyhpCcdiR4bTDA8VT+hfbCbYPIrj44hcPfYzlsfiwsYG68CACtD69tcvJi+vfAuSLE+V nPfMb6JuBluG1GEKQfxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pITPf-004e2h-Dm; Thu, 19 Jan 2023 11:48:59 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pITPZ-004dzU-QA for linux-arm-kernel@lists.infradead.org; Thu, 19 Jan 2023 11:48:57 +0000 Received: by mail-ej1-x632.google.com with SMTP id kt14so4997977ejc.3 for ; Thu, 19 Jan 2023 03:48:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OfApbZNaZr6Z8xIb2jJ8eKCH2W+NHkUdXeZjNWjuExM=; b=wRk71RacpT28/nFBKA4seJvhpniWQPuqi5ZADNXVsWB2YH4xD9zKiOrjea+yjyn6t8 QZF+nfkDog3jK/unutjliAh8EJ/mmnf+z//oqXhtZN3lm3x4ADDvuFJE29Ryd4AL4gkv P5NCYiOT9saYrheRYEWyGTw/z7jEEiIy5r5F1XDexU4Wj8yR4jpoNvv2y076/nHgGaq8 sK9AAqjegyite6tXt+erofB6p+lMWDw8pUD2XO3uZbLMSfzWbTHQrKZKkFBQ6cPA5/Mx b2svUQwHCJ4W+aFFOSKH8gBtS6+g7FkzE8u5JrsKKuaeG9E4gwXPQ6PLRrQLIla2SlXT pu8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OfApbZNaZr6Z8xIb2jJ8eKCH2W+NHkUdXeZjNWjuExM=; b=w3mmpz5hM9sKTygz0NcD31HTSOEeE8Zi5P5UpUWygR5EGlGwPf8/gG87wTCVVBC6QV sz+ZY8yMK1fVF17hrY5PhDP/Xu7+uIQUjRMWal7zleT/8QTTJUx382OM4+nqZvi1v0k4 Lkp/eZZft6KdNLzSBvC+UOtAjRNa8LtviYheBeHUsn335cMlZAIo72/KQYyaJA9XkYC+ EMjIZosoNd9UFzeampCf1ukuY44w/GzLTWHd7iHUkDk6Ekoqs+Z8/RJAggDuMKwTMREX INGXG6i4wGk6zsOd57I3m1AlSv9Vtbm1RBenZYcKdlUO1IjuJctkGvdQkS0ivHvZ1q4G mxdw== X-Gm-Message-State: AFqh2krokHacafGNuWqRlfpRzgs23ZVscs3qOFCOUQwFQLVMcVfPJZLj Ojm3puvOmrH47Tp/nlCTSWPr2Q== X-Google-Smtp-Source: AMrXdXuVZ6e1vq1DuWiskM3xp3ei42aLAUo7/50sjxdXOkzfqZ7xYsRSzXeQimL6PctKmRJV6oHbkQ== X-Received: by 2002:a17:906:804e:b0:86b:6a54:36e0 with SMTP id x14-20020a170906804e00b0086b6a5436e0mr9757970ejw.36.1674128928948; Thu, 19 Jan 2023 03:48:48 -0800 (PST) Received: from localhost ([217.111.27.204]) by smtp.gmail.com with ESMTPSA id o12-20020a170906768c00b0085ff3202ce7sm10454657ejm.219.2023.01.19.03.48.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 03:48:48 -0800 (PST) Date: Thu, 19 Jan 2023 12:48:47 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: "Kubalewski, Arkadiusz" , Vadim Fedorenko , Jonathan Lemon , Paolo Abeni , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" Subject: Re: [RFC PATCH v5 0/4] Create common DPLL/clock configuration API Message-ID: References: <20230117180051.2983639-1-vadfed@meta.com> <20230118161525.01d6b94f@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230118161525.01d6b94f@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230119_034854_157410_303C93A6 X-CRM114-Status: GOOD ( 27.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thu, Jan 19, 2023 at 01:15:25AM CET, kuba@kernel.org wrote: >On Wed, 18 Jan 2023 18:07:53 +0000 Kubalewski, Arkadiusz wrote: >> Based on today's sync meeting, changes we are going to introduce in next >> version: >> - reduce the muxed-pin number (artificial multiplication) on list of dpll's >> pins, have a single pin which can be connected with multiple parents, >> - introduce separated get command for the pin attributes, >> - allow infinite name length of dpll device, >> - remove a type embedded in dpll's name and introduce new attribute instead, >> - remove clock class attribute as it is not known by the driver without >> compliance testing on given SW/HW configuration, >> - add dpll device "default" quality level attribute, as shall be known >> by driver for a given hardware. > >I converted the patches to use the spec, and pushed them out here: > >https://github.com/kuba-moo/ynl/tree/dpll > >I kept the conversion step-by-step to help the readers a bit but >the conversion patches should all be squashed into the main DPLL patch. > >The patches are on top of my YNL branch ('main' in that repo). >I'll post the YNL patches later today, so hopefully very soon they will >be upstream. > >Two major pieces of work which I didn't do for DPLL: > - docs - I dropped most of the kdocs, the copy-n-pasting was too much; > if you want to keep the docs in the uAPI you need to add the > appropriate stuff in the spec (look at the definition of > pin-signal-type for an example of a fully documented enum) > - the notifications are quite unorthodox in the current > implementation, so I faked the enums :S > Usually the notification is the same as the response to a get. > IIRC 'notify' and 'event' operation types should be used in the spec. I already pointed this out in the past. This is not he only thing that was ignored during the dpll review. I have to say I'm a bit annoyed by that. > >There is documentation on the specs in >Documentation/userspace-api/netlink/ which should give some idea of how >things work. There is also another example of a spec here: >https://github.com/kuba-moo/ynl/blob/psp/Documentation/netlink/specs/psp.yaml > >To regenerate the C code after changes to YAML: > > ./tools/net/ynl/ynl-regen.sh > >if the Python script doing the generation dies and eats the files - >bring them back with: > > git checkout drivers/dpll/dpll_nl.c drivers/dpll/dpll_nl.h \ > include/uapi/linux/dpll.h > >There is a "universal CLI" script in: > > ./tools/net/ynl/samples/cli.py > >which should be able to take in JSON requests and output JSON responses. >I'm improvising, because I don't have any implementation to try it >out, but something like: > > ./tools/net/ynl/samples/cli.py \ > --spec Documentation/netlink/specs/dpll.yaml \ > --do device-get --json '{"id": 1}' > >should pretty print the info about device with id 1. Actually - it >probably won't because I didn't fill in all the attrs in the pin nest. >But with a bit more work on the spec it should work. > >Would you be able to finish this conversion. Just LMK if you have any >problems, the edges are definitely very sharp at this point. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel