From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B1C8C004D4 for ; Thu, 19 Jan 2023 14:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q2nvNpLNJhk20mw5tXbLrNVACmRJHu8VmtmljLjaVzw=; b=NR+OfprqVvQ9eB 9ADCNjLHCw6rV6VSC0aThIJOaYN1HpNPHRSPN7t2v8Abx6JsPGnQtgSqWkdBHy+zmlS1G41vPOdF1 gpEpB2M4+I3h+l7cbJydG3yZZ9nSgzR/LDRUN+ftP0AnbziE1t7nLpiNm7xfvBETKaEM2QptHq8pZ K1fLzQmxiKfp/3vh06pQBC6nz16+P9Zu7a9wF64iR0afDqwV+Vh9DNEK/NTofpAljsnK5UrTHuBwl uifGQOHdMhrlio6Pl+3F0L4gVbymbz1kz59NmmECcW7odFOkVGCVYrNv5pCR4yQ8w6yYHUzICjymF UUyB2uyv53080bjoYnWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIVrU-005IQQ-F0; Thu, 19 Jan 2023 14:25:52 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIVrQ-005IOd-9G; Thu, 19 Jan 2023 14:25:49 +0000 Received: by mail-wr1-x42e.google.com with SMTP id e3so2005600wru.13; Thu, 19 Jan 2023 06:25:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KjsZya+QHJjprUyI8l0iTCJWloAUubwO/7pn5KMVxco=; b=ar8Y5jds9GnCb1bu9DJlG8T+9M+euQ3P5Pu6wNsuF9/BaX1fRYVPzQ7B2JdXHWJ3dx jJBVGU0BUXV4y8nCmJF+RLL7OyT+kIJjeC8aN2Y8OIjJoVZMxnvnOUeSzAyL4uGFWUbC eHLU+nygimgKouEHjd6736nsBkRFYhWSTAgCfuX4PxBBulOya7uXBLma/0Xld25w7bh0 +1ymYyPEV15P4mapiPWA6b17HdvXzp6qG0dqm18xTcFLjKIHl0rYU0S05H+AXxnPupeZ mZ9EzJniQwpnEisWTjPN3ei4BseZCp1PV1/ui9dRQUPC6HbG9XHtlLvDWaFJDhjtRhSh 5mbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KjsZya+QHJjprUyI8l0iTCJWloAUubwO/7pn5KMVxco=; b=jf+m3vMbCg/oj5HofwliC4D82cTbnKFHjF1kMSVaw/vOtfdP9ZFQPK6kB5/e8az4dq 3+GHAn3vrMeacEU5eXF6UtM+hMO+0opmrHnZE11+wIQZ+oe2DmNuNSgD0KR6Ma646los LC92qh7mLaz/iyAhltUwhYdakDYAL2MjtsBWvtRho2SCA65zZwTD4fhNoebjloDU1vyD EV/z6aitmyt4w6+x44iXr/9hwapZjg7cLBblCxAg4mbf+PPG2X4PYRkCW3HuXE78Owjx fWclN+sdgDMSsNqKIIpERyeSBUohAsfbK2qH579lzyhgeWdOf4lmJ4nICNTSVkbnIGVu 8X/Q== X-Gm-Message-State: AFqh2koFADSGDgjBcAphcYby9ScsJhTcXwNNXZOgOGDHzc1mRTRQ08u2 cBilxAG4p5vjTwzugXyLsII= X-Google-Smtp-Source: AMrXdXtDiP7c/DabjOn7bKOH7ivh1JfCmDp+cs2iDNvgeWytgRdBmlEkHJc7fFHINSKci4IxJ/rbnA== X-Received: by 2002:a5d:5e85:0:b0:2b6:2eb3:82a1 with SMTP id ck5-20020a5d5e85000000b002b62eb382a1mr6224673wrb.67.1674138344975; Thu, 19 Jan 2023 06:25:44 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id e1-20020a5d65c1000000b002be15ee1377sm7953480wrw.22.2023.01.19.06.25.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 06:25:44 -0800 (PST) Date: Thu, 19 Jan 2023 17:25:41 +0300 From: Dan Carpenter To: Phil Elwell Cc: Greg Kroah-Hartman , Stefan Wahren , Umang Jain , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, Florian Fainelli , Adrien Thierry , Dave Stevenson , Kieran Bingham , Laurent Pinchart , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/4] Drop custom logging Message-ID: References: <20230118115810.21979-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230119_062548_345550_1907035A X-CRM114-Status: GOOD ( 16.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 19, 2023 at 01:47:44PM +0000, Phil Elwell wrote: > > > I understand the desire to remove the custom logging. I don't welcome > > > the loss of flexibility that comes with such a strategy > > > > What "loss of flexibility"? You now have access to the full dynamic > > debugging facilities that all of the rest of the kernel has. What is > > lacking? > > Perhaps I've missed something, either in this patch set or the kernel > as a whole, but how is one supposed to set different logging levels on > different facilities within a driver/module, or even for the module as > a whole? Yeah. You will be still able to do that and more besides after the transition. Cleaning this up makes the code better in every way. Documentation/admin-guide/dynamic-debug-howto.rst regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel