From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19B67C00A5A for ; Thu, 19 Jan 2023 14:34:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nB3LxvZUdQrEkfWLVHzH9oyQOU5HFQHB9d6w2Q/2WqA=; b=S+eWFwT2R0nkju gyH9rmXeEyd215SzSnvzTxdkgSssfisLTh/GsMDcaCPQF0lWpBu6VFRZVZc6D42S/EWyM51WeyuOL KnyB09VTHtmvnNlXk4fASlYu/ZQu0+W2dbsbjxlZicwMAzHODNtB6QdYv1zpvd15Z7ML9IkV4JD7+ jEAPL6qi14mqZlW7WV0K1J11pfT884bq1HtbpW7OpK6DjIgMy+PMYUaA8YvIu6BSj/oNk3BbA1VyF SVNrKIEFDiKlJ2Oyqg+VIBngt97y8JXMItifrBipNvPMf79w2Q2dMrkcEgiFU31cs136O5t3p/DIK sjmCeGLtII7rTgLg8eig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIVyK-005KVx-VE; Thu, 19 Jan 2023 14:32:57 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIVxt-005KKG-Qx; Thu, 19 Jan 2023 14:32:31 +0000 Received: by mail-wm1-x330.google.com with SMTP id m5-20020a05600c4f4500b003db03b2559eso1400507wmq.5; Thu, 19 Jan 2023 06:32:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wS7HSylCm9otocOdYBhDnMFqnI4PKH4nfYFHOFNvW3g=; b=ZyeibTCU3dHPBSQm3WEHymYSJKlzsLGwKkfHxwUW+zHH042eB7+IP/Sj0sEQFz6Jcj qu4v3JFderI0jEofEgqUdNuzs2JAeJgMZqswIkfxy32njBcZthC3qWipijH92mL4KqFr +8sdV/pFoM6gcD4xk1Ql6rKYxJr19dAPyeJDJYd/yqx93L/crHwkdHENThnjCJptZ4u+ uk5ORYgoPKm7KD0QUqFC276bwEUOnYm7ap9lWdW3bEFX77L55hRkf02Z68of/uzFMdal eoUdH52gXk0xreepJohtwXGYXwkv5zX4/k7+HKFW6/RuO7awltBN5yy01HaDHG4Iv5Sw 79jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wS7HSylCm9otocOdYBhDnMFqnI4PKH4nfYFHOFNvW3g=; b=fV2uzi/IxXcJwbLdejaAogMr0juBIkJlT8Eq5N/ITK3GuBfWiuLhARJ5rf6iWkvZpc pRRNyVqgIdZNDdsNFEUJ7XebRv/4Djx1lDS7cU0xkmk9rX/EYcHvGapDmayKkxIZ5JnE FvSaJqyHC68YuQh1NfPMx2amonLMAwamoaARBpd54ZFA5qplZwgQUdUdvJIDF20QN+m0 FDQz1w0B7Dw6KtqbSeYztKTbhfdi1vFPBEiAe971zDe51GUuUuiwmgXFSRRJgVwYXTqS eI7GuK/7d7YrxvxJmUOJHWOeLhrQlKiRulS8q/IxK8h9mlYcHSupJYPM7hH8IwEi2kdO 9/Tw== X-Gm-Message-State: AFqh2kphQFCS1PVNg/VfJK0/PK+4CJ2JcJtTyyiHiPCju3p3fyvbsZzM 7nPHOlFQw0oOMcWcojn+aqM= X-Google-Smtp-Source: AMrXdXsk3J0ufP1mfd0P9SekZ3FFkzaf0xCJj0h4j/1DCaEarvPaz9ltTd8g8lO+rl2wWrcKN7nq4A== X-Received: by 2002:a05:600c:1e19:b0:3da:2ba4:b97 with SMTP id ay25-20020a05600c1e1900b003da2ba40b97mr17848869wmb.19.1674138748164; Thu, 19 Jan 2023 06:32:28 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id z4-20020a1cf404000000b003da2932bde0sm5701400wma.23.2023.01.19.06.32.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 06:32:27 -0800 (PST) Date: Thu, 19 Jan 2023 17:32:24 +0300 From: Dan Carpenter To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Greg Kroah-Hartman , Florian Fainelli , Adrien Thierry , Dave Stevenson , Kieran Bingham , Laurent Pinchart Subject: Re: [RFC PATCH 1/4] staging: vc04_services: vchiq_core: Drop custom logging Message-ID: References: <20230118115810.21979-1-umang.jain@ideasonboard.com> <20230118115810.21979-2-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230118115810.21979-2-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230119_063229_941728_B93E98EC X-CRM114-Status: GOOD ( 12.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 18, 2023 at 05:28:07PM +0530, Umang Jain wrote: > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > index 4e705a447a62..7b3c57326d28 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > @@ -227,10 +227,11 @@ static const char *msg_type_str(unsigned int msg_type) > static inline void > set_service_state(struct vchiq_service *service, int newstate) > { > - vchiq_log_info(vchiq_core_log_level, "%d: srv:%d %s->%s", > - service->state->id, service->localport, > - srvstate_names[service->srvstate], > - srvstate_names[newstate]); > + struct vchiq_state *state = service->state; > + > + dev_info(state->dev, "%d: srv:%d %s->%s", state->id, > + service->localport, srvstate_names[service->srvstate], > + srvstate_names[newstate]); This should be a debug level printk. Don't spam dmesg in the success path. Success should not be noteworthy. > service->srvstate = newstate; > } regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel