From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41436C004D4 for ; Thu, 19 Jan 2023 14:43:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hSZBX2XybKRW5ruSQijIr2kNS0psEdCp0MOTrVkVpZk=; b=zSaNyVRWV0K71Z ZSnM2+RjUpYggtMMbkXjjw4rSkxeucu9KPnpEElypnrKiqfY0jueufLpVrFRdPOuOxFS2I4ZvcWC1 USeHF7uAXJ5czFV7CwI/PvLZSp0wqh47c5pCxm8twplw+iKFGdqWE4hignbGkm07RauBBTbVTk6wG /V5BhN4mWEUdV5sZnyTGIvJCqr0RWB3FiKyKcFNDPiitt1i9RxiCQ3DfgZ93lv0xGICQYzHR0zUah yaPnjlLQTlt2kb3GobK05yQJmBC2YI0aphIf5wooifkJB3RncsBctNi2sYSvcz60yp7M175rRGVbo KALIBjBjemJDYQIvadpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIW7e-005OZk-Ok; Thu, 19 Jan 2023 14:42:35 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIW3I-005MH8-2T; Thu, 19 Jan 2023 14:38:05 +0000 Received: by mail-wr1-x42b.google.com with SMTP id t5so2090320wrq.1; Thu, 19 Jan 2023 06:38:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GD0a/ka5+MJwmasza9LWV0qmM9V0aVs/dU+fSwzbrLs=; b=bQEZCtdRMYcijshT0y2Qu43vkvvkxnxFwy1oJhQCYKekBgxduc4PibPd41KYQ4DIlk r36PazF7qhmaQ/BJkKR0r/pA4X/4FSq3jf7rlUlUfMW7edWvRHJBHv0kUNUmXL50ivUI daB4uoFA40zs8ffS7cHsMu0w5LQUUrZvR+lq+C3EULFL5NugbTV2ey3ubJRZmC1unaO1 VUh8MjbKZHEKtzBc0UF8AXYnpQE3c9EhcLMKjFCQ5sNvCd2dB+32dnHVa1GYHjjdod9X z5WwPPK2NwjfBbtV9/lAkTJ00PRnU5dLTD4avwUpEBqtxinsS8SBcs3s0vmSS6BWdjB9 DqQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GD0a/ka5+MJwmasza9LWV0qmM9V0aVs/dU+fSwzbrLs=; b=LHdqbZf7fN6sGgB2J7cjmPH6N1ny5nhRzAaSXfIGZoITxytkNwudH7ltq9aLtXG6JX Z5/QN/Uzce/6EXd/fnB9Lwkixbsnyuq8gQqs+aYBJ6t6cFKcS2B43KWzdK4e1YQeWMja qPkJhuAweRvbN+hm7VOEvsHp/E+YCGfcrkto1H6UAX26NFt7m9O5Og5OHndeWL0bcddU ry3iwP4OHLhdoUpdG74E6bYKir6liDONecQfixeJQW/xsiKMlqXN/Az/N8CLEVTIPVX3 hky+GMyXs6fArRW4/6F9nyP6wPX7gCJG52OPit1E6aXIkdkGvB5VtnOqlTRL78adj1bc U6HA== X-Gm-Message-State: AFqh2kqAWUwTrHsyHXVm0V5k5GHB/DkhczBku+GR6Rwm2gEjut+RkJYD dYGXSkuyv0HQhf3ZQhTFqqHyoS3Kvc6c2A== X-Google-Smtp-Source: AMrXdXs/MbE7VqWd1vWjhpRw1JIECqYAGxrvtnGpGJTppbIZ3SSFqmdLDloCNBl/0j/F8ueulrWNqA== X-Received: by 2002:a5d:428e:0:b0:2bc:8339:1fcc with SMTP id k14-20020a5d428e000000b002bc83391fccmr10333611wrq.58.1674139079212; Thu, 19 Jan 2023 06:37:59 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id q15-20020adfab0f000000b002bde7999cd6sm16061235wrc.61.2023.01.19.06.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 06:37:58 -0800 (PST) Date: Thu, 19 Jan 2023 17:37:48 +0300 From: Dan Carpenter To: Phil Elwell Cc: Greg Kroah-Hartman , Stefan Wahren , Umang Jain , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, Florian Fainelli , Adrien Thierry , Dave Stevenson , Kieran Bingham , Laurent Pinchart , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/4] Drop custom logging Message-ID: References: <20230118115810.21979-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230119_063804_257345_81D72068 X-CRM114-Status: GOOD ( 19.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 19, 2023 at 02:31:50PM +0000, Phil Elwell wrote: > On Thu, 19 Jan 2023 at 14:25, Dan Carpenter wrote: > > > > On Thu, Jan 19, 2023 at 01:47:44PM +0000, Phil Elwell wrote: > > > > > I understand the desire to remove the custom logging. I don't welcome > > > > > the loss of flexibility that comes with such a strategy > > > > > > > > What "loss of flexibility"? You now have access to the full dynamic > > > > debugging facilities that all of the rest of the kernel has. What is > > > > lacking? > > > > > > Perhaps I've missed something, either in this patch set or the kernel > > > as a whole, but how is one supposed to set different logging levels on > > > different facilities within a driver/module, or even for the module as > > > a whole? > > > > Yeah. You will be still able to do that and more besides after the > > transition. Cleaning this up makes the code better in every way. > > > > Documentation/admin-guide/dynamic-debug-howto.rst > > Are you saying this patch set gets us to that point? Yes. The patch has some issues, but yes. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel