From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73FB3C004D4 for ; Fri, 20 Jan 2023 01:29:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0VFIWhQqJk9PognUOj+TT1ZbAuFlTI4E5WjzBOsWG8w=; b=C6duva52W9jK4y lUKAoqNpxpcfO0HUHNeElJpcNqyZlDoOISkoJFhh9NaJBz3uiRRB37H8vDn0RpydE2mgtOXNaDNI9 tcKjxDr7Iwo5dPuaMzRS1s1+BzAaLO0FEmBqYuKWaZxI6O2QiAEhBen1KnUnS4SgxrOvZfSZItr4r MPnIvKRwdzmk+IedDsFPf8IEAgv02fbVOD+rY34bsAu8aNy6Ty1Nq1rGTGTo/X96kA+njsnIylx2L kX2LKfzcUSjDR4fzcI7dj1hGW7vKonJy/xD8EtUMJIMsECmjG01+1jkXUOvA8uTfNxbo0/WpUxmBq 0uojnLsvtKkQYGuuT7cQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIgCU-007uGS-Qm; Fri, 20 Jan 2023 01:28:14 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIgCQ-007uFO-49; Fri, 20 Jan 2023 01:28:12 +0000 Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0C919514; Fri, 20 Jan 2023 02:28:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1674178088; bh=X0HOvhmLDrQGLDDPb3/eIBIXq95Sy11uu6swxZDUNro=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S/N1qMM20n53QIcvPqw6rjEWS4R4xGxt0TnZalAJmWqndBf8dn2eIVlyOhtICQUhq eZXlkuEGIt8FeaI6R3jiQfO1Syg154omFYP1QIHwgyoowu1/NGZYy9IqpiQimlO9LK Kry4gABVjr1Ix/L7r+kN78zDUXDIZEAHrJ0IJrqI= Date: Fri, 20 Jan 2023 03:28:05 +0200 From: Laurent Pinchart To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Greg Kroah-Hartman , Florian Fainelli , Adrien Thierry , Dan Carpenter , Dave Stevenson , Kieran Bingham , Paul Elder Subject: Re: [PATCH v5 2/6] staging: vc04_services: bcm2835-audio: Drop include Makefile directive Message-ID: References: <20230119115503.268693-1-umang.jain@ideasonboard.com> <20230119115503.268693-3-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230119115503.268693-3-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230119_172811_482488_5CECA30F X-CRM114-Status: GOOD ( 18.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Umang, Thank you for the patch. On Thu, Jan 19, 2023 at 05:24:59PM +0530, Umang Jain wrote: > Drop the include directive they can break the build one only wants to > build a subdirectory. Replace with "../" for the includes, in the > bcm2835.h instead. I assume you meant Drop the include directive. They can break the build, when one only wants to build a subdirectory. > Suggested-by: Greg Kroah-Hartman > Signed-off-by: Umang Jain > --- > drivers/staging/vc04_services/bcm2835-audio/Makefile | 2 -- > drivers/staging/vc04_services/bcm2835-audio/bcm2835.h | 3 ++- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/vc04_services/bcm2835-audio/Makefile b/drivers/staging/vc04_services/bcm2835-audio/Makefile > index fc7ac6112a3e..01ceebdf88e7 100644 > --- a/drivers/staging/vc04_services/bcm2835-audio/Makefile > +++ b/drivers/staging/vc04_services/bcm2835-audio/Makefile > @@ -1,5 +1,3 @@ > # SPDX-License-Identifier: GPL-2.0 > obj-$(CONFIG_SND_BCM2835) += snd-bcm2835.o > snd-bcm2835-objs := bcm2835.o bcm2835-ctl.o bcm2835-pcm.o bcm2835-vchiq.o > - > -ccflags-y += -I $(srctree)/$(src)/../include The reason for this, I assume, is that the driver is in staging. The vchiq.h file should live in include/linux/raspberrypi/, not drivers/staging/vc04_services/include/linux/raspberrypi/, so an additional include directory is added in order to use #include When the code will get out of staging, vchiq.h will go to include/linux/raspberrypi/, the extra include directory will be dropped, and all will be well without having to change any source file. With this patch, we'll have to undo the change below to drivers/staging/vc04_services/bcm2835-audio/bcm2835.h when vc04_services will get out of staging. Greg, is that what you prefer ? > diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h > index 38b7451d77b2..0a81383c475a 100644 > --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h > +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h > @@ -6,11 +6,12 @@ > > #include > #include > -#include > #include > #include > #include > > +#include "../include/linux/raspberrypi/vchiq.h" > + > #define MAX_SUBSTREAMS (8) > #define AVAIL_SUBSTREAMS_MASK (0xff) > -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel