From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EF1FC25B4E for ; Fri, 20 Jan 2023 09:14:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X90iNmOXBN9n5ZQ86uB+rhUXcQWvIItsYFpCUUpFWVc=; b=OqVfmUQwgHUYJI BoqyeriBrFB4U6JhxY4Nm/QZ2rXMti+x8+K86+rQo/CGUg8u+x8F3WKH5F9qVaU8ClVgopIyz/nCR vMmikMh/WqErZOZXf166mQzLrfJNfqdxXxD9QhYPx9s2SqcYJHwoMiloiF+5DFCKCfw+p47vTD/BQ Wjibm+4y9LIjrWB+6sqePpEKmA5KZkHI24J+pfJipgc4ZLfQL47wyt12H/Zx51qhimJ/Zq8W7MYHY b5/SafUL63ZaNYowpEIEAhx3KpZNVrRZXART6oFVX9imh+Ae5C3cSuOfgu4QKXEXalBmxMl5Xw8WB VcEpMzoyN/Q1SwJd0z8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pInSF-009FkW-RK; Fri, 20 Jan 2023 09:13:00 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pInQt-009F1d-JS for linux-arm-kernel@lists.infradead.org; Fri, 20 Jan 2023 09:11:36 +0000 Received: by mail-wm1-x330.google.com with SMTP id q10-20020a1cf30a000000b003db0edfdb74so561100wmq.1 for ; Fri, 20 Jan 2023 01:11:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=W/9HYZJv5LKapOcMACURG3HHx3Aj77kiqHirfoKY1tQ=; b=H8BpBACFih31vDUTJOXQz2V3tXzvi+Fj9WHWF92Q4dAYazRUovAKMk77//92Lipw3n QWroRwl/Iqsyqtd0JXY4zR0m+4R9bF//845mJ0uluiBn8GL8Ql+MIK8WHuocf6KD1Aan kNjKOC69QkzL4Ud64hRh517upqCxb8gq1hwpT4Coud/eIW+7IBFa+RZioXGtXJNEAcVw SGW/gkyZ2KKn8uq0ulkZWsmX+BBpuq4ttr+fQGk9ccI9mZtsnvG9lRkFu/OSMhfXOA1/ dzk5QaqSEK9UweD0jkm2aghhSVuni28klaJSR8sQPSEGBsTUFVadzoZcVd/6IRZKgohg 8+Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=W/9HYZJv5LKapOcMACURG3HHx3Aj77kiqHirfoKY1tQ=; b=KM/1MsLYFB+QTl1lv4UWGj9jJNUH/OcSi/HAdoe33OL/gGwjVuYaLj9yQ4jcUXnXXE lAfpQeQZgtPHxvNTb3CUrw84tdk6vRzt3WH45TpIm412RpjanXT7BEhFSPfq/V3XRA4Z aEU2N+OcgahC+sZKKjs7XGSr0wd7zkpD6h1uAjzV43kWZDuYlZWfKqEsqy282j4+cvyX uDLCn4pLpCuCxCMhA4Jo9bp5tOYEq+ZmWG+uOMJD8PYuBv4yaLPHv8CvXEGPpeBbA0m+ LcMEdHCxL47vkxMAeH9dL0/+5B4lbAVgavXlIaiyjpjy4L5z3xJ2HPQm9Vwpo7Zq5F0I v6bA== X-Gm-Message-State: AFqh2kqAN8KCLn3Z5XsDUd7pwy0X9z8abJGPOp1XB5Xg0UCOK722uYwz 2MjFotlQ+LYGkDgLjlMBoVI= X-Google-Smtp-Source: AMrXdXv/kcdR2C2yGPspYuFWdJY4W96/xbaMPLOri/IXx4P1YPTbKHKSLi5m0BSKHMTKyAqss7DbRQ== X-Received: by 2002:a05:600c:5d1:b0:3d0:761b:f86 with SMTP id p17-20020a05600c05d100b003d0761b0f86mr13436702wmd.28.1674205893227; Fri, 20 Jan 2023 01:11:33 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id z2-20020a05600c220200b003db305bece4sm1264548wml.45.2023.01.20.01.11.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jan 2023 01:11:32 -0800 (PST) Date: Fri, 20 Jan 2023 12:11:29 +0300 From: Dan Carpenter To: Steen Hegelund Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , UNGLinuxDriver@microchip.com, Randy Dunlap , Casper Andersson , Russell King , Wan Jiabing , Nathan Huckleberry , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Daniel Machon , Horatiu Vultur , Lars Povlsen , Michael Walle Subject: Re: [PATCH net-next 3/8] net: microchip: sparx5: Add actionset type id information to rule Message-ID: References: <20230120090831.20032-1-steen.hegelund@microchip.com> <20230120090831.20032-4-steen.hegelund@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230120090831.20032-4-steen.hegelund@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230120_011135_715335_99615576 X-CRM114-Status: GOOD ( 13.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 20, 2023 at 10:08:26AM +0100, Steen Hegelund wrote: > +/* Add the actionset typefield to the list of rule actionfields */ > +static int vcap_add_type_actionfield(struct vcap_rule *rule) > +{ > + enum vcap_actionfield_set actionset = rule->actionset; > + struct vcap_rule_internal *ri = to_intrule(rule); > + enum vcap_type vt = ri->admin->vtype; > + const struct vcap_field *fields; > + const struct vcap_set *aset; > + int ret = -EINVAL; > + > + aset = vcap_actionfieldset(ri->vctrl, vt, actionset); > + if (!aset) > + return ret; > + if (aset->type_id == (u8)-1) /* No type field is needed */ > + return 0; > + > + fields = vcap_actionfields(ri->vctrl, vt, actionset); > + if (!fields) > + return -EINVAL; > + if (fields[VCAP_AF_TYPE].width > 1) { > + ret = vcap_rule_add_action_u32(rule, VCAP_AF_TYPE, > + aset->type_id); > + } else { > + if (aset->type_id) > + ret = vcap_rule_add_action_bit(rule, VCAP_AF_TYPE, > + VCAP_BIT_1); > + else > + ret = vcap_rule_add_action_bit(rule, VCAP_AF_TYPE, > + VCAP_BIT_0); > + } > + return 0; return ret; ? > +} regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel