From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3045DC25B4E for ; Fri, 20 Jan 2023 09:16:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=23vkG+2KLsZKy41CE3t8xPd7T1G4SR7+gAPgqqjOz9E=; b=C36Id6RX6j8M8j 8x6DgYNH4aWdPX1Sh55PZqAE4+0ewqIbHQyV7XGFwUSWgBgxfeCzXv01mt4/BzCiHiRJCsKGf9KgI wqbavDCP+v7PeZLYg2HelJaYb981aqxLyVbxNBzW5gS8WGn3Zz/zknclPVcfw641z3uMmjuGh9Y9t ZoIvnTh9s/KlCmIu1raEbaK/RzCcjSlnkb9MqgUjCTlv/NtmxOPD/LEogc1hjUOIWxFRXIWBMfq3N ajSvpoO1OpQDk7yxXXS9pSAK8XEWE1pwpUVAcOSwF6F4w47PbAItubE/ltuee3ByT1oQNkEh9lxR6 +1rY8BagTDcHWXmbJkRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pInTX-009GQW-V2; Fri, 20 Jan 2023 09:14:22 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pInSM-009FpL-UY for linux-arm-kernel@lists.infradead.org; Fri, 20 Jan 2023 09:13:08 +0000 Received: by mail-wm1-x330.google.com with SMTP id f12-20020a7bc8cc000000b003daf6b2f9b9so5352775wml.3 for ; Fri, 20 Jan 2023 01:13:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ux8y6Cx3Fu1EDV86Is7psjeM9rNqa+KOawGSAK6XGIk=; b=JUgOOzKNnW0nTnbNzRK1+tRYnthmcPUqJTN+A6ZkCo+/vW3HP/to4oXcN9oRUgUPuY 0aE27/2P042xOIud6eaSEm2xttT0WWA6ZGzhHP8fe/3ka3kGNjvFWwduztFn4bPog1VJ MbJo00GcJ4R9qQbSXvZQoRyUPSfdAKla7HSCjTa7YNEF5FbsDGhC40jHcZ/Tt97Z4QFI 8Cb9lOI7oyDHhMa9Wi71iihLbRljnKGcTFP46jTJpYVW3NV+dr5t/pIJAb9vKBezfU4b 7jeQfJQ/1pbTsNH/WipPasrCfHSm+ivPa3lknfnKn/03vXV5MUQwm1w65+s4L9Eirfmx LcAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ux8y6Cx3Fu1EDV86Is7psjeM9rNqa+KOawGSAK6XGIk=; b=udfHsfSIdDrNSRoaGRdaSS8InW9m3G0AQmDk6vIv/WM2e2VeiHjFHo2in6wONf4VQu oL6IQmguYVWDktP0Mwb4NolR5D30vkUZIJGXcFDuoPkN3iLCLvEa8Wlvh6He2d2bHllT gNKvvfDMyCc/OSnKElCzjFUaAnpN4WCE+zkw3b6RQFOOB/bjTjOL7u2j5IPdkaekAHMW s3vCut6621HnSy7WpWkvb+95J80EurIm/HiVxLSJKfmzTvQQgcUZKYqNLEgGTBnvDMaD GRdJa/zN3MeSuKjUhY1gOlFwJq3VoruMOvp/nMrzfbBLfN3rr3Xdcqab6LM78MXZCqDC QQlw== X-Gm-Message-State: AFqh2kqVW/Lk8qBsk7gow9FeaCoQGpUAr0PagHwFGOYSoEXJjtUY7GH8 Nvz8CpgX5z61MLiwHNQecaI= X-Google-Smtp-Source: AMrXdXujUNuBhbykArz4bplt23suFeP7EOY/IXTXm6XfPcIkfmHck7sImTIaeoiTw84iE4TZKAXfMw== X-Received: by 2002:a05:600c:4256:b0:3da:2a78:d7a3 with SMTP id r22-20020a05600c425600b003da2a78d7a3mr12824255wmm.33.1674205985529; Fri, 20 Jan 2023 01:13:05 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id m2-20020a05600c4f4200b003db0ad636d1sm1789231wmq.28.2023.01.20.01.13.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jan 2023 01:13:05 -0800 (PST) Date: Fri, 20 Jan 2023 12:13:02 +0300 From: Dan Carpenter To: Steen Hegelund Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , UNGLinuxDriver@microchip.com, Randy Dunlap , Casper Andersson , Russell King , Wan Jiabing , Nathan Huckleberry , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Daniel Machon , Horatiu Vultur , Lars Povlsen , Michael Walle Subject: Re: [PATCH net-next 4/8] net: microchip: sparx5: Add TC support for IS0 VCAP Message-ID: References: <20230120090831.20032-1-steen.hegelund@microchip.com> <20230120090831.20032-5-steen.hegelund@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230120090831.20032-5-steen.hegelund@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230120_011307_192090_BDAE1954 X-CRM114-Status: GOOD ( 12.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 20, 2023 at 10:08:27AM +0100, Steen Hegelund wrote: > -/* Add a rule counter action - only IS2 is considered for now */ > +/* Add a rule counter action */ > static int sparx5_tc_add_rule_counter(struct vcap_admin *admin, > struct vcap_rule *vrule) > { > - int err; > + int err = 0; Don't initialize. > > - err = vcap_rule_mod_action_u32(vrule, VCAP_AF_CNT_ID, vrule->id); > - if (err) > - return err; > + if (admin->vtype == VCAP_TYPE_IS2) { > + err = vcap_rule_mod_action_u32(vrule, VCAP_AF_CNT_ID, > + vrule->id); > + if (err) > + return err; > + vcap_rule_set_counter_id(vrule, vrule->id); > + } > > - vcap_rule_set_counter_id(vrule, vrule->id); > return err; return 0; > } regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel