From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8647FC05027 for ; Fri, 20 Jan 2023 17:00:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AgdOL6AJhbIVz3xTZgy93/nyUjqHgeHNyWl4EL3nCN4=; b=KWWdWzDqL0PRwh FeQQnz6yqqH5KpIy0kJ+awcvML2nGOiEsxIxrd7uSWg0BCmenLktbDpB/Cx99oqY//hBbA3XpIMV+ g5PH5sq9ooDSbFYDcEYHtN2/OQhMTcFa/BbJ259blV5jbWN7v99pl94YkSjVyVNOP1AExRlsfTes5 uoTt2QHc28eYprXai8y/STPQPm/tjPPhw3JQg5INonqIBG/0h/HmIkPOKgPSJXyDHZ71qqBFSNBpN r+yxJ+W3u3iD/np8MGyZuIHiHEcZMEYgJwr1uvVqLJRFiHYRS2RmhjQFL96c69DTUdpGXK107P4RR JfLdiuHDHHiOlFCwHWiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIujW-00BLvi-QX; Fri, 20 Jan 2023 16:59:18 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIujR-00BLtk-G7 for linux-arm-kernel@bombadil.infradead.org; Fri, 20 Jan 2023 16:59:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OBWyfr4FGOOBUa959NdX/B8Spu1HqR0j0qIxgx8Fu8k=; b=RBwGaTprSLWus2nYmCNxBUVfQ2 74l9V7Ox9CzRVDK/04uRDxlBFJabyZGAsGBgsjN4ck2bazefsD7T/zAH4x6hyWzx47iFg7G1/SUZ4 4mi+vTP9+ntjDYAbWEzBY8tdjR5pCQjbTYzJHrswE7oQ6fcPNXN6bQczVtakHUn78vb64VjeebYwR 6SsI2Y7sBzn9RMxB8ianM1Jr98BP5Nsj9/as+NeGN2o3KTalw0qPtmPNtij2ldPz6rB4HfNod8Knw KMt1Dcfj6ojTcWJb/WuKRG5XoCCa+vBu+sRsmDTQ5V/L1TnEMRG3VNVSvThqvbS0HDFMyCqHQoLGO +xmmu/1A==; Received: from [187.19.237.165] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pIuib-000jso-2r; Fri, 20 Jan 2023 16:58:26 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 432C0405BE; Fri, 20 Jan 2023 13:58:46 -0300 (-03) Date: Fri, 20 Jan 2023 13:58:46 -0300 From: Arnaldo Carvalho de Melo To: James Clark Cc: linux-perf-users@vger.kernel.org, tanmay@marvell.com, leo.yan@linaro.org, mike.leach@linaro.org, sgoutham@marvell.com, gcherian@marvell.com, lcherian@marvell.com, bbhushan2@marvell.com, Mathieu Poirier , Suzuki K Poulose , John Garry , Will Deacon , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/8] perf cs_etm: Basic support for virtual/kernel timestamps Message-ID: References: <20230119154308.3815108-1-james.clark@arm.com> <72843540-fe25-d805-df76-3a3556fb5774@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <72843540-fe25-d805-df76-3a3556fb5774@arm.com> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Fri, Jan 20, 2023 at 02:39:30PM +0000, James Clark escreveu: > > > On 19/01/2023 16:58, Arnaldo Carvalho de Melo wrote: > > Em Thu, Jan 19, 2023 at 03:42:59PM +0000, James Clark escreveu: > >> Changes since v3: > >> > >> * Scale time estimates by INSTR_PER_NS, rather than assuming 1 > >> instruction = 1ns > >> * Add a new commit that fixes some issues around timestamps going > >> backwards > >> * Use nanoseconds inside cs-etm-decoder.c, rather than storing the > >> raw time values and converting when a sample is synthesized. This > >> simplifies some of the code like estimating the first timestamp. > > > > I would check this myself, but since Suzuki had some review comments and > > you may consider a v5, please check this: > > > > Cover: ./v4_20230119_james_clark_perf_cs_etm_basic_support_for_virtual_kernel_timestamps.cover > > Link: https://lore.kernel.org/r/20230119154308.3815108-1-james.clark@arm.com > > git checkout -b v4_20230119_james_clark_arm_com 69b41ac87e4a664de78a395ff97166f0b2943210 > > git am ./v4_20230119_james_clark_perf_cs_etm_basic_support_for_virtual_kernel_timestamps.mbx > > [acme@quaco perf]$ git am ./v4_20230119_james_clark_perf_cs_etm_basic_support_for_virtual_kernel_timestamps.mbx > > Applying: perf: Remove duplication around EVENT_SOURCE_DEVICE_PATH > > error: patch failed: tools/perf/util/pmu.c:1993 > > error: tools/perf/util/pmu.c: patch does not apply > > error: patch failed: tools/perf/util/pmu.h:259 > > error: tools/perf/util/pmu.h: patch does not apply > > Patch failed at 0001 perf: Remove duplication around EVENT_SOURCE_DEVICE_PATH > > hint: Use 'git am --show-current-patch=diff' to see the failed patch > > When you have resolved this problem, run "git am --continue". > > If you prefer to skip this patch, run "git am --skip" instead. > > To restore the original branch and stop patching, run "git am --abort". > > [acme@quaco perf]$ > > > > Probably a conflict with one of these: > > > > [acme@quaco perf]$ git log --oneline -5 tools/perf/util/pmu.c > > acef233b7ca749fd perf pmu: Add #slots literal support for arm64 > > 336b92da1aa4228a perf tool: Move pmus list variable to a new file > > 49bd97c28b7e7f01 perf tools: Use dedicated non-atomic clear/set bit helpers > > e5c6109f4813246a perf list: Reorganize to use callbacks to allow honouring command line options > > eb2d4514a5971444 perf pmu: Restructure print_pmu_events() to avoid memory allocations > > [acme@quaco perf]$ > > > > Update to my perf/core branch or even tmp.perf/core which is newer but > > still needs the full set of container build tests. > > Oops I must have just missed the latest perf/core update. I fixed the > conflict and sent a v5, and decided to not make any changes for Suzuki's > comments. Trying it now _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel