From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D3CBC61DA4 for ; Fri, 3 Feb 2023 21:41:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f31s+nUFD38W38w+uDcpnFlbrixda7W0ME2SZBa5Xx0=; b=1bjvIFW41eRgEu 9XIBs1l6f4bfP3mbGd++DV8LWJSiFg//laSML8Td1RXnmr6Vo2eb/cpZbGYP/l62ub1xjlvmFde8+ 3VsS7GqtfPEnrIHgjxRLt06aqMD1qewTXdqm9iu2iPzm/PKtvcthM+C4+k+HCj/9kei2jugL1QmMk yVA2459DU7gfqX3DA2T/WddVn8wpBkk7gFPtm/y0/NlqOpahrF+zpGfiU2uAqf4M0Bt7SBFABf7mg Nj0UrG275/yHayahDWm7NFmhLRTaxdp4497rBclYR+zEq0efb2Ff8bVkFLGkEh3e/CLMIMM6dljnV cnMcsY53lrWZsf3yJx9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pO3nX-003g4s-Hf; Fri, 03 Feb 2023 21:40:43 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pO3nS-003g4E-Ko for linux-arm-kernel@lists.infradead.org; Fri, 03 Feb 2023 21:40:40 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CACF1B82C20; Fri, 3 Feb 2023 21:40:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11F6EC433D2; Fri, 3 Feb 2023 21:40:32 +0000 (UTC) Date: Fri, 3 Feb 2023 21:40:30 +0000 From: Catalin Marinas To: "kernelci.org bot" Cc: will@kernel.org, linux-arm-kernel@lists.infradead.org, kernel-build-reports@lists.linaro.org, kernelci-results@groups.io, Yuan Kang , Herbert Xu Subject: Re: arm64/for-kernelci build: 2 builds: 1 failed, 1 passed, 1 error, 1 warning (v6.2-rc6-115-gca72d58361ee) Message-ID: References: <63dae0c5.170a0220.d70b2.34f8@mx.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230203_134038_851306_0A1BFEBE X-CRM114-Status: GOOD ( 20.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 03, 2023 at 06:26:09PM +0000, Catalin Marinas wrote: > On Wed, Feb 01, 2023 at 01:59:33PM -0800, kernelci.org bot wrote: > > arm64/for-kernelci build: 2 builds: 1 failed, 1 passed, 1 error, 1 warning (v6.2-rc6-115-gca72d58361ee) > > > > Full Build Summary: https://kernelci.org/build/arm64/branch/for-kernelci/kernel/v6.2-rc6-115-gca72d58361ee/ > > > > Tree: arm64 > > Branch: for-kernelci > > Git Describe: v6.2-rc6-115-gca72d58361ee > > Git Commit: ca72d58361ee2e0d246385d21474b283f67416b9 > > Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git > > Built: 1 unique architecture > > > > Build Failure Detected: > > > > arm64: > > allmodconfig: (gcc-10) FAIL > > > > Errors and Warnings Detected: > > > > arm64: > > allmodconfig (gcc-10): 1 error, 1 warning > > > > Errors summary: > > > > 1 include/linux/fortify-string.h:57:29: error: argument 2 null where non-null expected [-Werror=nonnull] > > For some reason this shows with gcc-10 on arm64 allmodconfig but it's > been around for some time. We only noticed it now due to the SLUB_TINY > config that made it into 6.2-rc1 which disables KASAN. I can trigger it > on 6.1 just by disabling KASAN after an allmodconfig. > > The problem is the NULL 2nd argument passed to append_fifo_load_as_imm() > in gen_split_key() in drivers/crypto/caam/key_gen.c. The error below > looks sane to me and the key_gen.c needs fixing as you can't do a > memcpy() from a NULL source pointer. But I have no clue how to fix it, > so cc'ing the code author and crypto maintainer. Actually, we can conclude that gcc-10 is not smart enough and ignore this report. The call gen_split_key() has len == 0: append_fifo_load_as_imm(desc, NULL, 0, LDST_CLASS_2_CCB | FIFOLD_TYPE_MSG | FIFOLD_TYPE_LAST2); It ends up in append_data(), again with len == 0, which does: if (len) /* avoid sparse warning: memcpy with byte count of 0 */ memcpy(offset, data, len); So memcpy() should never get a NULL argument but gcc cannot figure it out. We could extend the check above to (len && data) but it's just for a compiler problem. I haven't seen this with gcc-12. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel