From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1145C636CC for ; Sat, 4 Feb 2023 16:28:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C5dLAoaMDf8bwrCWDnT4IJRMLXnvRcYH3Q5swoQtSg8=; b=mUALbXa++xH3e4 EZMamkGbHi28S7Tutyth74EBXB/CoUhKovdtJSZFV7WmugDtmJmbc/OWKSWqhglXq/qXjqwRY3rwS 2s1cLhRcJOmohzEXvqeudo1jminGgCljXWvtnvHaCxfEj40bekqe+hA1z58G+Ubamb+k+UEOyeJe8 GFg/nP08ge06ltBGp3TNA+Qbc7b5Ix6P2zimdKLm1vDrGZs1VSbK0nFDfmKtzPikY+wRJuiL/sMiy vkwMrIwTnoZBNBD+5GEKXd4+GdEaboeeiipsQ+DTTL6pwSVd+XY+VUS7I8VCkqK3aMgxSJoA7ei/B hs3cBq+ZWmaHGPfcyQgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pOLO0-005NaI-Et; Sat, 04 Feb 2023 16:27:32 +0000 Received: from out-158.mta1.migadu.com ([95.215.58.158]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pOLNw-005NZd-Lo for linux-arm-kernel@lists.infradead.org; Sat, 04 Feb 2023 16:27:31 +0000 Date: Sat, 4 Feb 2023 17:27:15 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=grimler.se; s=key1; t=1675528043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i6CjYk8EtEf6fAK6NSdNEXA8dI2Iw2y8gEGpp/id1NY=; b=F6cP3CajJGx3wXlb8Lu+U6S5k0cMuusHCgbFcNrzhJ0P/87aOWHJDHsP+Lbv0HVHDe9RX6 Ks/9jvHG9mDea9Kz1si19/efKKoInDFfcPN7ItdWxOQUDxROoeDWPi5r7amJofTD44tOvw tzOvvR6U/i/nk3hIKLr+lLtH9GDspOw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Henrik Grimler To: David Virag Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, alim.akhtar@samsung.com, m.szyprowski@samsung.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH 1/2] arm64: dts: exynos: drop mshc aliases Message-ID: References: <20230203204000.14410-1-henrik@grimler.se> <20230203204000.14410-2-henrik@grimler.se> <398401ce6a1e37b42f895b86fa2ed90c2676e15a.camel@gmail.com> <6c528b24aa94751d568d3b43bd00a4795964b3ae.camel@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6c528b24aa94751d568d3b43bd00a4795964b3ae.camel@gmail.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230204_082729_434957_5D6D7AC0 X-CRM114-Status: GOOD ( 23.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi David, On Sat, Feb 04, 2023 at 01:45:15PM +0100, David Virag wrote: > On Sat, 2023-02-04 at 12:43 +0100, David Virag wrote: > > On Fri, 2023-02-03 at 21:39 +0100, Henrik Grimler wrote: > > > They are no longer needed after commit a13e8ef6008d ("mmc: dw_mmc: > > > exynos: use common_caps"). > > > = > > > Signed-off-by: Henrik Grimler > > > --- > > > =A0arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 -- > > > =A0arch/arm64/boot/dts/exynos/exynos7-espresso.dts=A0=A0=A0=A0=A0=A0 = | 2 -- > > > =A02 files changed, 4 deletions(-) > [...] > > In dw_mmc-exynos.c, there's a caps array specified like this: > > = > > /* Common capabilities of Exynos4/Exynos5 SoC */ > > static unsigned long exynos_dwmmc_caps[4] =3D { > > =A0=A0=A0=A0=A0=A0=A0=A0MMC_CAP_1_8V_DDR | MMC_CAP_8_BIT_DATA, > > =A0=A0=A0=A0=A0=A0=A0=A00, > > =A0=A0=A0=A0=A0=A0=A0=A00, > > =A0=A0=A0=A0=A0=A0=A0=A00, > > }; > > = > > As I understand these capabilities are added to the mmc controllers > > based on mshc alias id. Shouldn't these capabilities be moved to > > device-tree before removing these aliases? This also applies to the > > 32bit arm patch. If I understand correctly, removing these aliases > > without adding the capabilities to dt removes the capability > > "MMC_CAP_1_8V_DDR" and "MMC_CAP_8_BIT_DATA" from mshc_0/mmc_0. Thanks for pointing this out (I should have seen it already), will send a new version to update device trees and remove the need for those mshc alias based capabilities. > Actually, it defaults to 0, so these capabilities will be added to all > mmc nodes, not just those with mshc0 alias. That may cause problems. I think I see what you mean: ctrl_id will be set to 0 if mshc alias is missing, and then caps is set as mmc->caps |=3D drv_data->caps[ctrl_id]; where drv_data->caps[0] =3D MMC_CAP_1_8V_DDR | MMC_CAP_8_BIT_DATA Should be fixed in next version of patchset then in any case, maybe it deserves a "Fixes:" tag as well, will have a look in git history if there is a particular commit that introduced this situation. > Best regards, > David Best regards, Henrik Grimler _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel