From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF707C38142 for ; Tue, 24 Jan 2023 17:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hEFHQKxevQtkO43Emj7XlJVuAW/BM19jXxXO8co0ZlQ=; b=CXFghsyvDpU02rbT5ZoSvM4mrc rlawjyji9/NLVEz6dVNwaCt92rUT0SJvpP15Ja6lWxS6Fa7Nlw2jLS8tADMx/kC2+/HDDNb4qzlmm LluS1lL+5U2c7lkaewwEnfpCEdiXUS2WcHHdXGe1qPbJzDXD8bLEtBs+ihE0yajAJkC1wXwYqKPYo hXiAAUtUCSnqK9AN6Ic8FHyiEHbEUI+yGhwQtiC1L5vvBN/2vNobvm7fx4pf4OgR/yYhMP0CrsQvV Q94iqAnGEFnDbmsZPvKBg4CYYLREzOrzqNhkwwu3Li4OOlqBXFapZQWhpEJz+SqlWDIoFUnidBY4a t+tDlXqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKMfc-004kvE-Bt; Tue, 24 Jan 2023 17:01:16 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKMfX-004kuJ-QZ for linux-arm-kernel@lists.infradead.org; Tue, 24 Jan 2023 17:01:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 29B27612FD; Tue, 24 Jan 2023 17:01:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5481EC433D2; Tue, 24 Jan 2023 17:01:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674579671; bh=hH4ROFBDE9/zvCleMxO0DBsKXeLU0Z/8dFxdcAZGYMI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xx7okMwMsx1OdKtdINef/nsB6UPGFCy5I8aNzzJ49saQp+dHtt/IfDu/atvIBwzhl 9ADvrLntSkKdkpOmIu3Og70fxhXty9DVLI8V6eQC/ZO8NhJUDFAO/5PegwaZNAvYhh iBNdXUlA9i7E4CDD0oeQ2B2AiCcPlArgRsbGnRV7fejqbWn1QToVQCw69tpX6jfG9S 56PanImLqpeQrsON5VmL39gcwJJTCYO4bU+5ZDTiBfjwbp8mOJNiCnpbWUacTs10Ks HIv4RYtrgv+fQwIaU6V9DFkCBPpw+vCIHXEpOHq1+bG6VBxOn3xJfPsdSb87cZaiuJ WOuaAfxdg0WjQ== Date: Tue, 24 Jan 2023 17:01:04 +0000 From: Conor Dooley To: Pierre Gondois Cc: linux-kernel@vger.kernel.org, Geert Uytterhoeven , Conor Dooley , Dan Carpenter , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Akihiko Odaki , Palmer Dabbelt , Gavin Shan , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH -next v2 3/3] cacheinfo: Remove unused check in init_cache_level() Message-ID: References: <20230124154053.355376-1-pierre.gondois@arm.com> <20230124154053.355376-4-pierre.gondois@arm.com> MIME-Version: 1.0 In-Reply-To: <20230124154053.355376-4-pierre.gondois@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230124_090111_922642_B91A71AC X-CRM114-Status: GOOD ( 23.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7034935074520068687==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7034935074520068687== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="C5gbpn4doceQBVba" Content-Disposition: inline --C5gbpn4doceQBVba Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 24, 2023 at 04:40:48PM +0100, Pierre Gondois wrote: > commit e75d18cecbb3 ("arm64: cacheinfo: Fix incorrect assignment > of signed error value to unsigned fw_level") > checks the fw_level value in init_cache_level() in case the value is > negative. > Remove this check as the error code is not returned through > fw_level anymore, and reset fw_level if acpi_get_cache_info() > failed. This allows to try fetching the cache information from > clidr_el1. I dunno anything about clidr_el1, but the mechanics of the change seem fair. There is a non-acpi path too, which shouldn't return negative numbers either so LGTM. > Signed-off-by: Pierre Gondois > --- > arch/arm64/kernel/cacheinfo.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/arch/arm64/kernel/cacheinfo.c b/arch/arm64/kernel/cacheinfo.c > index bf348b8d321f..c307f69e9b55 100644 > --- a/arch/arm64/kernel/cacheinfo.c > +++ b/arch/arm64/kernel/cacheinfo.c > @@ -62,9 +62,6 @@ int init_cache_level(unsigned int cpu) > fw_level =3D 0; > } > =20 > - if (fw_level < 0) > - return fw_level; > - > if (level < fw_level) { > /* > * some external caches not specified in CLIDR_EL1 > --=20 > 2.25.1 >=20 --C5gbpn4doceQBVba Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCY9AO0AAKCRB4tDGHoIJi 0szJAQCdmFEFdFU4G6o36G8+91OO9PTUNKda+jTIrbjZ3pKAnwD/XUULiEMDXoMo mI2CSx7E69a1BYjjDaTuo6jiVUpjBQs= =Wii1 -----END PGP SIGNATURE----- --C5gbpn4doceQBVba-- --===============7034935074520068687== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7034935074520068687==--