From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD2B8C25B4E for ; Tue, 24 Jan 2023 18:37:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6O4DG0LqxMXiSWy0V1tpJi65CrxOShVy0Qn3bRmzx9w=; b=CBPCx1kK7DCNZl BFYMGjASIuY16e5JjctpPYAQrJSUY3ejL8aU4tzytdoPBJm0nOgvwrra9u8G4T3M3MDwRwspRFO4S qjmg4aRnCTnYoE2hMM4bIEE3qo5F8Xo557N01UDunAtR8zC4gDPK8uJ/fui3jk5WuyFwcNo4THQVI M5G/YmlJu1Z3tcolBPG0Ky7w9PTSPmfa/AlRLxJW2EJ5o+Ih446Ow70WYGrr45j/Ez7KbPkCnCJKg UXxSML+E9s5jiGb4dmvOk9EGX5jRRwzn/o1YtvFsa3ddrTBI0RXBR6ce8GAyjGv0CDCmY9KieIDiB N2Jt3iFlz2fM+jhalRQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKO9J-004xRw-Fp; Tue, 24 Jan 2023 18:36:01 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKO9H-004xRl-Mq for linux-arm-kernel@bombadil.infradead.org; Tue, 24 Jan 2023 18:35:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0NU0x5fogIbsecuQXkHV1tJytvm4YwntIqqU8e/sJso=; b=TMAi8FbtgY+Pba0O/ooz5XJpmI QEk1dxPF+DgHmAovPMlqxVZ13iXBRqdd7MbOhpfAUC6F0vLErbwDrDK0qG4/oGIvKfHG+Ak5B9+eP fhe9n1829ziW50vQbb7XQH0ryS34bhW86JhSjSyjlCJx93+WwBr3j3wdxBB1lPwpU49QFGz6rOtjS xUJuTN9SlGfyhNpv+TYd0RQDatgb8FbHljN7Hrjm6bbnaHkbYBoqSGtFKcvug330ay7pslFq5KGhh 2KnlYZGR79zwKUqZzAWK5rdx9jNJonJKmHUZNuPk6HYbpquySDFYs8C20f8/aVgupbEbrfnjNLVoX rKdNuMjw==; Received: from [187.19.237.165] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKO9F-005Gn2-4M; Tue, 24 Jan 2023 18:35:58 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 8D2DE405BE; Tue, 24 Jan 2023 15:35:51 -0300 (-03) Date: Tue, 24 Jan 2023 15:35:51 -0300 From: Arnaldo Carvalho de Melo To: Suzuki K Poulose Cc: James Clark , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Mathieu Poirier , Mike Leach , Leo Yan , John Garry , Will Deacon , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] perf: cs-etm: Improve missing sink warning message Message-ID: References: <20230124110220.460551-1-james.clark@arm.com> <1dbd558a-92b7-77ed-1bbe-0f421547bf54@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1dbd558a-92b7-77ed-1bbe-0f421547bf54@arm.com> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Tue, Jan 24, 2023 at 11:08:32AM +0000, Suzuki K Poulose escreveu: > On 24/01/2023 11:02, James Clark wrote: > > Make the sink error message more similar to the event error message that > > reminds about missing kernel support. The available sinks are also > > determined by the hardware so mention that too. > > > > Also, usually it's not necessary to specify the sink, so add that as a > > hint. > > > > Now the error for a made up sink looks like this: > > > > $ perf record -e cs_etm/@abc/ > > Couldn't find sink "abc" on event cs_etm/@abc/. > > Missing kernel or device support? > > > > Hint: An appropriate sink will be picked automatically if one isn't is specified. > > > > For any error other than ENOENT, the same message as before is > > displayed. > > > > Signed-off-by: James Clark > > Acked-by: Suzuki K Poulose Thanks, applied. - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel