From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 852CEC27C76 for ; Wed, 25 Jan 2023 12:27:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MBp1i+jferElLyZfMpsvEfc/5029P3AL9DmQ7xjqNzU=; b=4Nk0umI7IqLMBj pY49tQw9JCe70nzH+0puMVJjcr14KDKh6TxQQOh8uvswt83Sp7iSt3qJlhFTtLrpwinbHN2w9ZvbG TsGG2XeSVBHNs/OV4FSCZEj7o1ufkuw7LEcl3yuaxqLfKhDNOBqyoka5bGJGoeE/iTWBscTxo7Y2H vnkc1DaK9sS3IfcQcOWQBCcMfqJkaAxmllYhNIZUQHUASsrg+Ng71qPri/HI2AQX3Ut/uaYbjthSN qVr5w4vZ1C/HvjXpKdokA/vPgrNQrkowV1hAkF5jI8tnMLO3beV8LjRpNh/a8FhWcpvJQbyTK/8nn LBjlVWNNsGAEcdnKcwfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKeqx-007Htj-CF; Wed, 25 Jan 2023 12:26:11 +0000 Received: from mga02.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKeqr-007Hsn-NB for linux-arm-kernel@lists.infradead.org; Wed, 25 Jan 2023 12:26:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674649565; x=1706185565; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=yrSmmLc3DVdQTD12Kpyaer5iKdyd+7tY7IvnduKXdIk=; b=QK19nfTrX49/vA0mgCHHn+z+wzwlmlL2OJh1pQtOLlMqJvL/C3sWjrT+ zPfIhwJ8BBlZ+EXR4eudckuXM/lSX1e7IU/UI85OWzddCRh1GZ1ipPC2N qwjnO5HsxqkaEXiGFbniU8toZrM+PE6zHvHmyfmooAd16EdS3SkJRGKFJ rhrt3Zl2oa7U+/hI/pRzZ8TIpDwb631XjBWpWBsQKFMLNcEZNA1y2vC7O CUiE80DxGZaSFk9sSM202sor/J0heQwdc7qmMlCq3Zx4j8hgNM/a3x4m+ o+qusS5j+ed+9H0fhW+dr7qyHH+uHQ67U6W/Iil4BBlWE5etdFtC8Fvzk w==; X-IronPort-AV: E=McAfee;i="6500,9779,10600"; a="314446107" X-IronPort-AV: E=Sophos;i="5.97,245,1669104000"; d="scan'208";a="314446107" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2023 04:26:03 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10600"; a="836329640" X-IronPort-AV: E=Sophos;i="5.97,245,1669104000"; d="scan'208";a="836329640" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2023 04:25:58 -0800 Received: from kekkonen.localdomain (localhost [IPv6:::1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 4CDEE120C31; Wed, 25 Jan 2023 14:25:55 +0200 (EET) Date: Wed, 25 Jan 2023 14:25:55 +0200 From: Sakari Ailus To: Marco Felsch Cc: Michael Riesch , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Gerald Loacker , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Laurent Pinchart , Hans Verkuil , Mikhail Rudenko , Krzysztof =?utf-8?Q?Ha=C5=82asa?= , Marek Vasut Subject: Re: [PATCH v2 1/2] dt-bindings: media: i2c: add imx415 cmos image sensor Message-ID: References: <20230124060107.3922237-1-michael.riesch@wolfvision.net> <20230124060107.3922237-2-michael.riesch@wolfvision.net> <20230125112111.hnjf57gecch4ddi5@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230125112111.hnjf57gecch4ddi5@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230125_042605_824128_637042C6 X-CRM114-Status: GOOD ( 32.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marco, On Wed, Jan 25, 2023 at 12:21:11PM +0100, Marco Felsch wrote: > Hi Michael, > > On 23-01-24, Michael Riesch wrote: > > Add devicetree binding for the Sony IMX415 CMOS image sensor. > > > > Signed-off-by: Michael Riesch > > --- > > v2: > > - fix reference in port (must be /$defs/port-base) > > - describe data-lanes in more detail > > - remove unexpected property clock-lanes from example > > - sort properties in example alphabetically > > > > .../bindings/media/i2c/sony,imx415.yaml | 130 ++++++++++++++++++ > > MAINTAINERS | 7 + > > 2 files changed, 137 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml > > new file mode 100644 > > index 000000000000..104c36b64c09 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml > > @@ -0,0 +1,130 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/i2c/sony,imx415.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Sony IMX415 CMOS Image Sensor > > + > > +maintainers: > > + - Michael Riesch > > + > > +description: |- > > + The Sony IMX415 is a diagonal 6.4 mm (Type 1/2.8) CMOS active pixel type > > + solid-state image sensor with a square pixel array and 8.46 M effective > > + pixels. This chip operates with analog 2.9 V, digital 1.1 V, and interface > > + 1.8 V triple power supply, and has low power consumption. > > + The IMX415 is programmable through I2C interface. The sensor output is > > + available via CSI-2 serial data output (two or four lanes). > > + > > +allOf: > > + - $ref: ../video-interface-devices.yaml# > > + > > +properties: > > + compatible: > > + const: sony,imx415 > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + description: Input clock (24 MHz, 27 MHz, 37.125 MHz, 72 MHz or 74.25 MHz) > > I would move this description to the clocks property. > > > + items: > > + - const: inck > > If there is only one clock we could remove the clock-names property to > not bother the user to specify this. > > > + > > + avdd-supply: > > + description: Analog power supply (2.9 V) > > + > > + dvdd-supply: > > + description: Digital power supply (1.1 V) > > + > > + ovdd-supply: > > + description: Interface power supply (1.8 V) > > + > > + reset-gpios: > > + description: Sensor reset (XCLR) GPIO > > + maxItems: 1 > > + > > + flash-leds: true > > + > > + lens-focus: true > > + > > + orientation: true > > + > > + rotation: true > > + > > + port: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + > > + properties: > > + endpoint: > > + $ref: /schemas/media/video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + data-lanes: > > + oneOf: > > + - items: > > + - const: 1 > > + - const: 2 > > + - items: > > + - const: 1 > > + - const: 2 > > + - const: 3 > > + - const: 4 > > + > > + link-frequencies: true > > + > > + required: > > + - data-lanes > > + - link-frequencies > > + > > + required: > > + - endpoint > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - clock-names > > + - avdd-supply > > + - dvdd-supply > > + - ovdd-supply > > + - port > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + imx415: camera-sensor@1a { > > + compatible = "sony,imx415"; > > + reg = <0x1a>; > > + avdd-supply = <&vcc2v9_cam>; > > + clocks = <&clock_cam>; > > + clock-names = "inck"; > > + dvdd-supply = <&vcc1v1_cam>; > > + lens-focus = <&vcm>; > > + orientation = <2>; > > + ovdd-supply = <&vcc1v8_cam>; > > + reset-gpios = <&gpio_expander 14 GPIO_ACTIVE_LOW>; > > + rotation = <180>; > > + > > + port { > > + imx415_ep: endpoint { > > + data-lanes = <1 2 3 4>; > > + link-frequencies = /bits/ 64 <445500000>; > > + remote-endpoint = <&mipi_in>; > > + }; > > + }; > > + }; > > + }; > > Nit albeit I'm not quite sure but I think the indent should be two spaces. I'm not sure either but AFAIR all the other examples I've seen use four spaces. > > > +... > > diff --git a/MAINTAINERS b/MAINTAINERS > > index f61eb221415b..c9fa893bf649 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -19493,6 +19493,13 @@ T: git git://linuxtv.org/media_tree.git > > F: Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml > > F: drivers/media/i2c/imx412.c > > > > +SONY IMX415 SENSOR DRIVER > > +M: Michael Riesch > > +L: linux-media@vger.kernel.org > > +S: Maintained > > +T: git git://linuxtv.org/media_tree.git > > +F: Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml > > I'm not sure if you should add an entry here since you're already listed > as maintainer within the binding file. Should be here as well. -- Regards, Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel