From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E156C61DA2 for ; Thu, 26 Jan 2023 17:26:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YrcXoGEWczzSFFAYmox7QrJFi7MRlgTcVkZ6PYII+F0=; b=T09HYQcH7cQblQ PtUSL4L87cWb2kMbX6/e4fSnnGSiiGlOMpUn4aApV8hHl2FV5mOPAP1t39m6nWnCWh5KhqMZz0wDU OhaV5VOoFGKrSD2Vb0kH+8bxpPgbXGoP6O1TcmEIOLS4ZmhmWROGpz7jge1zAJ25CcJDsEC6kU83N esblPrxBs4aKWx8bhf/rFdgFiSIY9Pg3yqN9Uw1s4mL2axkfTHG2EzSzVlFKw1R1K+4S+DH7jEmmV pnlniSM3bNn5NQbLGtfaK9MnfERl/c75ugPgYwEoDwbPLOShG5llcHY03LUbW2WCA43ZKdxC9bQdQ BZ0zvSZ9qU6lJcy+aRpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pL60B-00C0Ir-KF; Thu, 26 Jan 2023 17:25:31 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pL608-00C0HQ-3p for linux-arm-kernel@lists.infradead.org; Thu, 26 Jan 2023 17:25:30 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CF22F4B3; Thu, 26 Jan 2023 09:26:03 -0800 (PST) Received: from FVFF77S0Q05N.cambridge.arm.com (FVFF77S0Q05N.cambridge.arm.com [10.1.33.135]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E981E3F64C; Thu, 26 Jan 2023 09:25:20 -0800 (PST) Date: Thu, 26 Jan 2023 17:25:14 +0000 From: Mark Rutland To: Will Deacon Cc: cki-project@redhat.com, xiawu@redhat.com, catalin.marinas@arm.com, bhe@redhat.com, linux-arm-kernel@lists.infradead.org, ardb@kernel.org Subject: Re: ? FAIL (91/181 SKIPPED): Test report for for-kernelci (6.2.0-rc5, arm-next, 2e84eedb) Message-ID: References: <29992.123012504212600261@us-mta-139.us.mimecast.lan> <20230126125202.GA29102@willie-the-truck> <20230126151715.GA29322@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230126151715.GA29322@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230126_092528_266385_48CFADD3 X-CRM114-Status: GOOD ( 26.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 26, 2023 at 03:17:16PM +0000, Will Deacon wrote: > On Thu, Jan 26, 2023 at 03:09:58PM +0000, Mark Rutland wrote: > > On Thu, Jan 26, 2023 at 12:52:03PM +0000, Will Deacon wrote: > > > [+Mark and Ard in case they have ideas] > > > > > > On Wed, Jan 25, 2023 at 09:21:19AM -0000, cki-project@redhat.com wrote: > > > > Hi, we tested your kernel and here are the results: > > > > > > > > Overall result: FAILED > > > > Merge: OK > > > > Compile: OK > > > > Test: FAILED > > > > > > > > > > > > Kernel information: > > > > Commit message: Merge branch 'for-next/core' into for-kernelci > > > > > > > > You can find all the details about the test run at > > > > https://datawarehouse.cki-project.org/kcidb/checkouts/66828 > > > > > > > > One or more kernel tests failed: > > > > Unrecognized or new issues: > > > > aarch64 - kdump - kexec_boot > > > > Logs: https://datawarehouse.cki-project.org/kcidb/tests/6799495 > > > > > > This looks like we run into an undefined instruction when we jump to the > > > kexec relocation code. Do you know if the failure is reproducible, and is > > > the log identical each time? > > > > I had a go in a QEMU KVM VM on ThunderX2, and a QEMU KVM TCG VM. With defconfig > > I don't see the issue, but with the config from the test run link above I > > consistently see the issue both under KVM and TCG (logs below). > > > > It should be simple enough to figure out which config option is tickling this; > > I'll go dig in to that.. > > Cheers, Mark. If you get a chance, it's probably also worth testing vanilla > -rc5 to confirm that it's a regression in our queue (which we could > assumedly bisect if necessary). I have met the enemy, and he is me: | git bisect start | # good: [2241ab53cbb5cdb08a6b2d4688feb13971058f65] Linux 6.2-rc5 | git bisect good 2241ab53cbb5cdb08a6b2d4688feb13971058f65 | # bad: [2e84eedb182e43a9113c2c83cc3373c2ae99ce19] Merge branch 'for-next/core' into for-kernelci | git bisect bad 2e84eedb182e43a9113c2c83cc3373c2ae99ce19 | # good: [3eb1b41fba97a1586e3ecca8c10547071f541567] kselftest/arm64: Add coverage of SME 2 and 2.1 hwcaps | git bisect good 3eb1b41fba97a1586e3ecca8c10547071f541567 | # good: [daac835347a52d9d141be281e4657cc08a360e97] kselftest/arm64: Correct buffer size for SME ZA storage | git bisect good daac835347a52d9d141be281e4657cc08a360e97 | # bad: [baaf553d3bc330697c68a00f96cf11f4edfeac7e] arm64: Implement HAVE_DYNAMIC_FTRACE_WITH_CALL_OPS | git bisect bad baaf553d3bc330697c68a00f96cf11f4edfeac7e | # good: [47a15aa544279d34e14e17ca3b5855e39b946cec] arm64: Extend support for CONFIG_FUNCTION_ALIGNMENT | git bisect good 47a15aa544279d34e14e17ca3b5855e39b946cec | # good: [e4ecbe83fd1a5428d5458de04a3404f1b5444429] arm64: patching: Add aarch64_insn_write_literal_u64() | git bisect good e4ecbe83fd1a5428d5458de04a3404f1b5444429 | # good: [90955d778ad7873964a271852b1f24d31e00248b] arm64: ftrace: Update stale comment | git bisect good 90955d778ad7873964a271852b1f24d31e00248b | # first bad commit: [baaf553d3bc330697c68a00f96cf11f4edfeac7e] arm64: Implement HAVE_DYNAMIC_FTRACE_WITH_CALL_OPS It looks like this is down to the function alignment; reverting that commit makes it go away, but if ia add: | diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig | index 6914f6bf41e22..8dafeea05864e 100644 | --- a/arch/arm64/Kconfig | +++ b/arch/arm64/Kconfig | @@ -123,7 +123,7 @@ config ARM64 | select DMA_DIRECT_REMAP | select EDAC_SUPPORT | select FRAME_POINTER | - select FUNCTION_ALIGNMENT_4B | + select FUNCTION_ALIGNMENT_8B # HACK HACK HACK | select GENERIC_ALLOCATOR | select GENERIC_ARCH_TOPOLOGY | select GENERIC_CLOCKEVENTS_BROADCAST ... then it blows up again. So we're probably doing a clever address calculation in the kexec idmap code that ends up being wrong when the code gets shuffled a bit; possibly a mismatched caller/callee alignment. I'll dig a bit more... Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel