Re: [PATCH v2 2/3] media: rkisp1: Make local immutable array variables static const

Laurent Pinchart
2023-01-26T23:29:34Z

Hi Dafna,

On Sun, Nov 20, 2022 at 12:28:01AM +0200, Laurent Pinchart wrote:
> Hi Dafna,
>
> Are you fine with this patch, can I include it in my next pull request
> along with the other ones from the series ?

Ping.

> On Thu, Nov 17, 2022 at 05:42:16PM +0900, Paul Elder wrote:
> > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > The max_widths and max_heights variables in rkisp1_try_fmt() are
> > immutable and don't need to be allocated on the stack every time the
> > function is called. Make them static.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
> > ---
> > .../media/platform/rockchip/rkisp1/rkisp1-capture.c | 12 ++++++++----
> > 1 file changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
> > index 7695ef134908..91e685fdbbe9 100644
> > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
> > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
> > @@ -1150,13 +1150,17 @@ static void rkisp1_try_fmt(const struct rkisp1_capture *cap,
> > const struct rkisp1_capture_fmt_cfg **fmt_cfg,
> > const struct v4l2_format_info **fmt_info)
> > {
> > + static const unsigned int max_widths[] = {
> > + RKISP1_RSZ_MP_SRC_MAX_WIDTH,
> > + RKISP1_RSZ_SP_SRC_MAX_WIDTH,
> > + };
> > + static const unsigned int max_heights[] = {
> > + RKISP1_RSZ_MP_SRC_MAX_HEIGHT,
> > + RKISP1_RSZ_SP_SRC_MAX_HEIGHT,
> > + };
> > const struct rkisp1_capture_config *config = cap->config;
> > const struct rkisp1_capture_fmt_cfg *fmt;
> > const struct v4l2_format_info *info;
> > - const unsigned int max_widths[] = { RKISP1_RSZ_MP_SRC_MAX_WIDTH,
> > - RKISP1_RSZ_SP_SRC_MAX_WIDTH };
> > - const unsigned int max_heights[] = { RKISP1_RSZ_MP_SRC_MAX_HEIGHT,
> > - RKISP1_RSZ_SP_SRC_MAX_HEIGHT};
> >
> > fmt = rkisp1_find_fmt_cfg(cap, pixm->pixelformat);
> > if (!fmt) {

--
Regards,

Laurent Pinchart