From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59888C54EAA for ; Fri, 27 Jan 2023 09:28:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xMXl/P24fY90AURnqjBMWWYt26srp9PiQzonQqSytPs=; b=AwZfkAc6SbhKKu psDnagbtkPB6J8UyAKzEqy8vWvAig3H/OsifP3hL+Gvzcxjlrui3GPCre13OfaTag8G2AFX6psp+U rvJJov1WBBn/6zD3Vh8KAVaeogbDrUb/ORcp87bTsc9s8DzxAWaQJ741ldn3aMFTEfVh23dN91443 mO/ygonVClyY5TI10FEj+gw2My1cvErv6ssPQ1VZ/Y3nUMWnX6CalnTUMqrQ/xShVMmtnY2h4/ld1 Ncwjjdd5aCYMSfRWiN6Gb8SxAijRV68QNT0DiBha0iQvaN32y23VEQbaPiHUjUSQNu7yGw5K+biBT 5Mf/WTF//VhBldsGlczQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLL1Z-00Delg-Uk; Fri, 27 Jan 2023 09:27:58 +0000 Received: from mga04.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLL1U-00Deje-Fz for linux-arm-kernel@lists.infradead.org; Fri, 27 Jan 2023 09:27:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674811672; x=1706347672; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=irOFwGOpCdgiAWhOEXeba39LtNKCJ17Fddk8cCsao5I=; b=EQ/tr08Otk1Dg0J1e5sOT5KRZv58/hHcvAdP09KJ8VUI0ecXQX5TdB2f qL/Vyuvf7gDXjtqg9Qw4V03i2+k3R/4pH8UsTr64XF/ndNQdaOibnZm5F ViTVEg7qn5fi7GCgShmH2T7ihnzznMp+QI0QDKH+EdhNq7lrmwN6TucgE C0vIxknLYew1D0v9UdW/iJCt9m2AqKnYol0rEEYob0faFfps6M/lqJLPp FwgOJaSwQBfV3NVTbLrwSsxuBuIhCHBpblitBLW0DcI6MLpsyYat+WhUO e0QVDxnjuccNclxpE3GWTOZu1HKFAgaGNBc+JkhNxdrELsbOKq1fsK49e g==; X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="325723995" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="325723995" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2023 01:27:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10602"; a="787159567" X-IronPort-AV: E=Sophos;i="5.97,250,1669104000"; d="scan'208";a="787159567" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP; 27 Jan 2023 01:27:10 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pLL0k-00FtTe-1I; Fri, 27 Jan 2023 11:27:06 +0200 Date: Fri, 27 Jan 2023 11:27:06 +0200 From: Andy Shevchenko To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Tony Lindgren , Linux Kernel Functional Testing , Naresh Kamboju , Abel Vesa , Alexander Stein , Geert Uytterhoeven , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Miquel Raynal , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 04/11] gpiolib: Clear the gpio_device's fwnode initialized flag before adding Message-ID: References: <20230127001141.407071-1-saravanak@google.com> <20230127001141.407071-5-saravanak@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230127001141.407071-5-saravanak@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230127_012752_629128_4CCF1BAE X-CRM114-Status: GOOD ( 15.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 26, 2023 at 04:11:31PM -0800, Saravana Kannan wrote: > Registering an irqdomain sets the flag for the fwnode. But having the > flag set when a device is added is interpreted by fw_devlink to mean the > device has already been initialized and will never probe. This prevents > fw_devlink from creating device links with the gpio_device as a > supplier. So, clear the flag before adding the device. ... > + /* > + * If fwnode doesn't belong to another device, it's safe to clear its > + * initialized flag. > + */ > + if (!gdev->dev.fwnode->dev) > + fwnode_dev_initialized(gdev->dev.fwnode, false); Do not dereference fwnode in struct device. Use dev_fwnode() for that. struct fwnode_handle *fwnode = dev_fwnode(&gdev->dev); if (!fwnode->dev) fwnode_dev_initialized(fwnode, false); + Blank line. > ret = gcdev_register(gdev, gpio_devt); > if (ret) > return ret; -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel