From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BB92C54EAA for ; Mon, 30 Jan 2023 14:03:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q9PvOJb4EKpG1NS2V4CgNfMGXZjfiZfMIgt5GXgG0cQ=; b=kfyEIdT3Op8kk6 FwWyH9LegshPJq2lTpyYXIUhk/9krOEy3Z8K3bYYC2NGEhnoVcrcZyTGZdOdpr/8c/ZNz+KTFMCok nOLm4t6khEdXxjMowfIdIEgSMPUBlzvxdqWUn0y99RegCAyRw6UoDsmsANATAMOf2ZJW5NRYVWaBb qNp4QDo28TR7OenVQSkSTAcMxXN9Eozim7v8oNnqQPWvM3bz0rMs5A2P98xTrob/zzlHqYrMSzwZa jmrxgbW3DSnDkCrhHDYdUo8lk/Vw2vZ0BqFG6RgOyvRw3hZUpAg3FMUlP6a6glsqQQdJkIrSPCY2y LqjzVk/VzWqP9bwiiNJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMUiH-003mrE-Cs; Mon, 30 Jan 2023 14:00:49 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMUhW-003mnF-8C for linux-arm-kernel@bombadil.infradead.org; Mon, 30 Jan 2023 14:00:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=djrwZ+3eyXOsjZksG0LVhDhzFj1zexPlC0C6FLLX3Jk=; b=nElUzceUCTb9jzIuoWbIKweUxw GPmdPNO7r7iqhdJIUQ6v8cza0YE8DWBOqG3fMJ9PUjZcsj8t/NuqwR2c1RB0g5nCdBkgBZz/OHe68 rMdeN4M8EGujTJIxELkMUYmNtlbmnbpfPK9H46r2PeVNYH5Q4pT/o5n8Y+ZRWxts7XgBGDp4uM4jJ 0RVL4254X7utuDxnIMJLHArYWc4+0JOYwP9znn04C12OHEyp9aS8j7Whs6lTcEdyGiBWwSVDsZDRD Ff2+t5ya2V9T6ypA+GTF7AnLVp5dnOYpm+XVpjv4xqR5lMyDFyM6R+Po3X95WQk0m/fDsUvlIYoIx PIOhLIIw==; Received: from [187.65.29.133] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMUhT-00APAL-LH; Mon, 30 Jan 2023 14:00:00 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 00BFC405BE; Mon, 30 Jan 2023 10:59:54 -0300 (-03) Date: Mon, 30 Jan 2023 10:59:54 -0300 From: Arnaldo Carvalho de Melo To: James Clark Cc: Mike Leach , linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, mathieu.poirier@linaro.org, linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, Ian Rogers Subject: Re: [PATCH] perf: cs-etm: Update decoder code for OpenCSD version 1.4 Message-ID: References: <20230120153706.20388-1-mike.leach@linaro.org> <77f9eab5-4fb2-cf96-9628-2a816d519d61@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Mon, Jan 30, 2023 at 12:05:53PM +0000, James Clark escreveu: > On 24/01/2023 21:50, Ian Rogers wrote: > > On Fri, Jan 20, 2023 at 7:47 AM James Clark wrote: > >> On 20/01/2023 15:37, Mike Leach wrote: > >>> OpenCSD version 1.4 is released with support for FEAT_ITE. > >>> This adds a new packet type, with associated output element ID in > >>> the packet type enum - OCSD_GEN_TRC_ELEM_INSTRUMENTATION. > >>> > >>> As we just ignore this packet in perf, add to the switch statement > >>> to avoid the "enum not handled in switch error", but conditionally > >>> so as not to break the perf build for older OpenCSD installations. > >>> > >>> Signed-off-by: Mike Leach > >>> --- > >>> tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 3 +++ > >>> 1 file changed, 3 insertions(+) > >>> > >>> diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > >>> index fa3aa9c0fb2e..48e7121880a9 100644 > >>> --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > >>> +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > >>> @@ -604,6 +604,9 @@ static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer( > >>> case OCSD_GEN_TRC_ELEM_CUSTOM: > >>> case OCSD_GEN_TRC_ELEM_SYNC_MARKER: > >>> case OCSD_GEN_TRC_ELEM_MEMTRANS: > >>> +#if (OCSD_VER_NUM >= 0x010400) > >>> + case OCSD_GEN_TRC_ELEM_INSTRUMENTATION: > >>> +#endif > >>> default: > >>> break; > >>> } > >> > >> Checked the build with both old and new versions of OpenCSD and it's ok: > >> > >> Reviewed-by: James Clark > > > > Acked-by: Ian Rogers > > > > Thanks, > > Ian > > Hi Arnaldo, > > Is it ok to merge this change? If anyone is building with the latest > OpenCSD they will get a build error on the unhandled switch case, and we > just got it in our CI too. > > I suppose we could disable the warning around this switch, but it's > pretty rare to add new packets so might be best to leave it. Thanks, applied. - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel