From: Mark Rutland <mark.rutland@arm.com>
To: Peter Hoyes <Peter.Hoyes@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, andre.przywara@arm.com,
diego.sueiro@arm.com, jaxson.han@arm.com,
vladimir.murzin@arm.com, robbie.cao@arm.com
Subject: Re: [boot-wrapper PATCH] Makefile: Change COUNTER_FREQ to 100 MHz
Date: Mon, 30 Jan 2023 14:38:59 +0000 [thread overview]
Message-ID: <Y9fWgzao48+PSGnx@FVFF77S0Q05N> (raw)
In-Reply-To: <9dd03939-ffbd-9b2d-055a-c3d70b0ff439@arm.com>
Hi Peter,
On Tue, Mar 01, 2022 at 11:18:54AM +0000, Peter Hoyes wrote:
> On 15/02/2022 12:29, Mark Rutland wrote:
> > On Tue, Feb 15, 2022 at 11:54:18AM +0000, Peter Hoyes wrote:
> > > From: Peter Hoyes <Peter.Hoyes@arm.com>
> > >
> > > Older Arm Fast Models (AEM < RevC) had a base frequency of 24 MHz. but
> > > the RevC base models use 100 MHz. There is not a robust method of
> > > determining the configured base frequency at runtime, so update
> > > COUNTER_FREQ to be 100 MHz.
> > This looks right to me; if no-one shouts in the next day or two I'll apply
> > this.
> >
> > In future, if we need this to be configurable, I reckon we can either add a
> > specific option for this or a more general "platform" option which can also
> > know about other things which aren't in the DTB.
> >
> > Thanks,
> > Mark.
>
> I don't think there have been any further comments - would it be possible to
> apply this?
Apologies for the extremely long delay; I've applied this and pushed it out
now.
Thanks,
Mark.
> Peter
>
> > > Signed-off-by: Peter Hoyes <Peter.Hoyes@arm.com>
> > > ---
> > > Makefile.am | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/Makefile.am b/Makefile.am
> > > index 08e304a..6ebece2 100644
> > > --- a/Makefile.am
> > > +++ b/Makefile.am
> > > @@ -13,7 +13,7 @@ SCRIPT_DIR := $(top_srcdir)/scripts
> > > PHYS_OFFSET := $(shell perl -I $(SCRIPT_DIR) $(SCRIPT_DIR)/findmem.pl $(KERNEL_DTB))
> > > UART_BASE := $(shell perl -I $(SCRIPT_DIR) $(SCRIPT_DIR)/findbase.pl $(KERNEL_DTB) 0 'arm,pl011')
> > > SYSREGS_BASE := $(shell perl -I $(SCRIPT_DIR) $(SCRIPT_DIR)/findbase.pl $(KERNEL_DTB) 0 'arm,vexpress-sysreg' 2> /dev/null)
> > > -COUNTER_FREQ := 24000000
> > > +COUNTER_FREQ := 100000000
> > > CPU_IDS := $(shell perl -I $(SCRIPT_DIR) $(SCRIPT_DIR)/findcpuids.pl $(KERNEL_DTB))
> > > NR_CPUS := $(shell echo $(CPU_IDS) | tr ',' ' ' | wc -w)
> > > --
> > > 2.25.1
> > >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-01-30 17:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 11:54 [boot-wrapper PATCH] Makefile: Change COUNTER_FREQ to 100 MHz Peter Hoyes
2022-02-15 12:29 ` Mark Rutland
2022-03-01 11:18 ` Peter Hoyes
2023-01-30 14:38 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9fWgzao48+PSGnx@FVFF77S0Q05N \
--to=mark.rutland@arm.com \
--cc=Peter.Hoyes@arm.com \
--cc=andre.przywara@arm.com \
--cc=diego.sueiro@arm.com \
--cc=jaxson.han@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robbie.cao@arm.com \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox