From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 861C3C54EAA for ; Mon, 30 Jan 2023 20:01:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HMt+58eGzBySn8iSp7dQkFeKCovm5YqCLMNBXDtEW58=; b=3hi0RpwYywPwR/ nx+D5AnUJumsqBnl0G73n6WALmK7obOZyTR+hZ9ZexzYk9rCoxJfwZom5znqA2DvERAxlnRga6bK+ RsyAN5qJSSaKkoTiv1ZjG5vWM/Wd/nbIrwXTOd4XmKPXzhEhyLj1naoPJXCbE3k2GyrlsDxRCgR9V /4+NPFLQsm0ZkVI2Hzn00GRTb6SwdwcThEgj6ubCcirYC8xJCNx3iHc4BJ0ykZ5issCN82WCeEAxI NH26uFa0fLr7mwv/jCk/N+Tx6MkXmLrj9MvTZdPloKRqrL+/xEyQLWMWWy0YN4Go56I/K5edI8rUI mHzaTLyGJffzNkTCqjTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMaJi-005GcD-1K; Mon, 30 Jan 2023 19:59:50 +0000 Received: from out-252.mta0.migadu.com ([91.218.175.252]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMaJc-005Gao-PT for linux-arm-kernel@lists.infradead.org; Mon, 30 Jan 2023 19:59:47 +0000 Date: Mon, 30 Jan 2023 20:59:35 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=grimler.se; s=key1; t=1675108779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oDXEr4tevG+VL9CgJZUG91in/A0kV3NohS4+eilPyY0=; b=Dk9hrcKLg6J15nt1uvUwiH2WNSHjrXjxdfBe9kav2HVwNfuGuB46meRfLu0ATP714SBYmM 5mBixVUdN+gnXm6mmBATYA/VwWWbAEmbE6WbEpiM4B990lSV3N0zbh4iQvVDa7TcAl/DR6 H3y/OSaK96QSmwwFPqc3M8TBzdbTXNg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Henrik Grimler To: Marek Szyprowski Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, alim.akhtar@samsung.com, jenneron@protonmail.com, markuss.broks@gmail.com, martin.juecker@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH v2 0/2] ARM: dts: add mmc aliases for Exynos devices Message-ID: References: <20230128133151.29471-1-henrik@grimler.se> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230130_115946_068498_78C6368B X-CRM114-Status: GOOD ( 26.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marek, On Mon, Jan 30, 2023 at 02:28:27PM +0100, Marek Szyprowski wrote: > On 28.01.2023 14:31, Henrik Grimler wrote: > > It is convenient to have fixed mmcblk numbering of the eMMC and sdcard > > so that assigned numbers will not change from boot-to-boot or > > depending on if storage devices are actually attached or not. > > > > Anton Bambura has done the work for the chromebooks while I have > > looked at the other devices. On the chromebooks, mmc0 is used for > > eMMC and mmc1 for sdcard, while mmc0 is used for eMMC and mmc2 for > > sdcard on the other boards, simply because Anton and I had different > > preferences. > > > > Also remove mshc aliases, as they should not be needed after [1] as > > I understand it. > > Thanks for this patchset. Long time ago I've tried to submit something > similar, but that time it has been rejected: > > https://lore.kernel.org/all/20201105114804.18326-1-m.szyprowski@samsung.com/ Thanks for testing! I missed that you had sent it before, Krzysztof pointed it out in v1 as well. > I hope that the mshc alias removal will help here. > > BTW, similar patchset is needed for arch/arm64/boot/dts/exynos Sure, I do not have any of the currently supported arm64 boards to test with, but can send the same type of patch for arm64 as well. [1] Best regards, Henrik Grimler > > [1] https://lkml.kernel.org/lkml/20211124184603.3897245-1-john@metanate.com > > > > --- > > > > Changes since v1: > > * Move mshc alias cleanup to a separate commit > > * Use mmc0 and mmc1 (instead of mmc0 and mmc2) for eMMC and sdcard on > > chromebooks > > * Address Krzysztof's review comments: > > - Make changes per device rather than in soc dtsi > > > > > > Henrik Grimler (2): > > ARM: dts: exynos: drop mshc aliases > > ARM: dts: exynos: add mmc aliases > > > > arch/arm/boot/dts/exynos3250-artik5-eval.dts | 5 +++++ > > arch/arm/boot/dts/exynos3250-artik5.dtsi | 5 +++++ > > arch/arm/boot/dts/exynos3250-monk.dts | 1 + > > arch/arm/boot/dts/exynos3250-rinato.dts | 2 ++ > > arch/arm/boot/dts/exynos3250.dtsi | 3 --- > > arch/arm/boot/dts/exynos4210-i9100.dts | 6 ++++++ > > arch/arm/boot/dts/exynos4210-origen.dts | 5 +++++ > > arch/arm/boot/dts/exynos4210-smdkv310.dts | 4 ++++ > > arch/arm/boot/dts/exynos4210-trats.dts | 6 ++++++ > > arch/arm/boot/dts/exynos4210-universal_c210.dts | 6 ++++++ > > arch/arm/boot/dts/exynos4412-itop-elite.dts | 5 +++++ > > arch/arm/boot/dts/exynos4412-midas.dtsi | 3 +++ > > arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 5 +++++ > > arch/arm/boot/dts/exynos4412-origen.dts | 5 +++++ > > arch/arm/boot/dts/exynos4412-p4note.dtsi | 6 ++++++ > > arch/arm/boot/dts/exynos4412-smdk4412.dts | 4 ++++ > > arch/arm/boot/dts/exynos4412-tiny4412.dts | 4 ++++ > > arch/arm/boot/dts/exynos4412.dtsi | 1 - > > arch/arm/boot/dts/exynos5250-arndale.dts | 5 +++++ > > arch/arm/boot/dts/exynos5250-smdk5250.dts | 2 ++ > > arch/arm/boot/dts/exynos5250-snow-common.dtsi | 3 +++ > > arch/arm/boot/dts/exynos5250-spring.dts | 5 +++++ > > arch/arm/boot/dts/exynos5250.dtsi | 4 ---- > > arch/arm/boot/dts/exynos5260-xyref5260.dts | 5 +++++ > > arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 ++ > > arch/arm/boot/dts/exynos5410-smdk5410.dts | 5 +++++ > > arch/arm/boot/dts/exynos5420-arndale-octa.dts | 5 +++++ > > arch/arm/boot/dts/exynos5420-galaxy-tab-common.dtsi | 5 +++++ > > arch/arm/boot/dts/exynos5420-peach-pit.dts | 3 +++ > > arch/arm/boot/dts/exynos5420-smdk5420.dts | 5 +++++ > > arch/arm/boot/dts/exynos5420.dtsi | 3 --- > > arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 5 +++++ > > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 4 ++++ > > arch/arm/boot/dts/exynos5422-samsung-k3g.dts | 4 ++++ > > arch/arm/boot/dts/exynos5800-peach-pi.dts | 3 +++ > > 35 files changed, 133 insertions(+), 11 deletions(-) > > > > > > base-commit: 9ca5a7ce492d182c25ea2e785eeb72cee1d5056b > > Best regards > -- > Marek Szyprowski, PhD > Samsung R&D Institute Poland > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel