From: Greg KH <gregkh@linuxfoundation.org>
To: Ruan Jinjie <ruanjinjie@huawei.com>
Cc: catalin.marinas@arm.com, will@kernel.org,
haibinzhang@tencent.com, hewenliang4@huawei.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5.10] arm64: fix a concurrency issue in emulation_proc_handler()
Date: Tue, 31 Jan 2023 09:25:51 +0100 [thread overview]
Message-ID: <Y9jQj4tnDOOPNn92@kroah.com> (raw)
In-Reply-To: <78883f84-dceb-9b24-b1f3-321d84091a85@huawei.com>
On Tue, Jan 31, 2023 at 04:23:19PM +0800, Ruan Jinjie wrote:
>
>
> On 2023/1/31 15:27, Greg KH wrote:
> > On Tue, Jan 31, 2023 at 02:52:11PM +0800, ruanjinjie wrote:
> >> This patch is addressing an issue in stable linux-5.10 only.
> >>
> >> In linux-6.1, the related code is refactored in 124c49b1b("arm64:
> >> armv8_deprecated: rework deprected instruction handling") and
> >> this issue was incidentally fixed. However, the patch changes a lot and
> >> is not specific to this issue.
> >
> > Then what about 5.15.y? You can not upgrade to that kernel and have a
> > regression, right?
>
> This patch has a pre-dependency af483947d ("arm64: fix oops in
> concurrently setting insn_emulation sysctls"), which has not merged into
> branches except 5.10.y, so the other branches don't apply.
So there is no bug in 5.15.y? That's confusing.
> > And nit, you need a ' ' before the '(' character.
> >
> > But why can we just not take the original commit that fixed this issue?
> > That way almost always is the best (prevents regressions, makes
> > backports easier, is actually tested, etc.) ?
>
> Thank you! It is ok to take the original commit to fix this issue.
Please submit it after testing.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-01-31 8:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 6:52 [PATCH v5.10] arm64: fix a concurrency issue in emulation_proc_handler() ruanjinjie
2023-01-31 7:27 ` Greg KH
2023-01-31 8:23 ` Ruan Jinjie
2023-01-31 8:25 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9jQj4tnDOOPNn92@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=catalin.marinas@arm.com \
--cc=haibinzhang@tencent.com \
--cc=hewenliang4@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).