From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABD9AC636CC for ; Tue, 31 Jan 2023 08:27:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+BLtqlLKitwjXUxaxLQVecQQml45dILOe3D7KxAmcSQ=; b=icqvO6DnHC/n+a IiAWxdhrYIC9tYj5Z8ESLBBzopZRZsccM94xFVzEF66eAq+Z0NEaA/5g30EP8k9i5XdIqE9MmwdYq XuUy8Omqw+E3qYsc65bXsQOPdKqlmvgD7k0n/TT/IsvPEGiF95BynAlQ60rsnni4nV/c6xiJGWoXh YeFGZ3/poGpfJa9PK5cGbsjRaFSh6jjN33UMuCp8dILb92TLGJkxCa6nS6uqHank5i2+SOs4vEetw RteZsf/W+AjgUkxGFM72piceiPgb4CXW0P1sEUcv/iXpsr7zQa7OA2L9WjVMbRbcbsDS5MkZqf0z+ X+7ed9lPj7OYiLrj+ykg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMlxo-006i9o-GJ; Tue, 31 Jan 2023 08:26:00 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMlxj-006i8L-Sy for linux-arm-kernel@lists.infradead.org; Tue, 31 Jan 2023 08:25:57 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E1AA861445; Tue, 31 Jan 2023 08:25:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8F9FC433D2; Tue, 31 Jan 2023 08:25:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675153554; bh=sQYpsRn0336Uppe33iacTmEelJCp6JM/JUY3m63RleI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D1X/gulwL55O4a9HXBGFaKpziyp4d5PtbaSvQiypLOF23ESw41Du33mJIje4HTLXY QymXNMNl8NUlr4g+AdRkE9ASjKlgI2K48sxEC23L6PUNwawSIfBwQu+CDcvxcNdb7r i2toNqO4XqPA0QuV5OznSwGhJbBy3ppXQf0nPO1A= Date: Tue, 31 Jan 2023 09:25:51 +0100 From: Greg KH To: Ruan Jinjie Cc: catalin.marinas@arm.com, will@kernel.org, haibinzhang@tencent.com, hewenliang4@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5.10] arm64: fix a concurrency issue in emulation_proc_handler() Message-ID: References: <20230131065211.2826133-1-ruanjinjie@huawei.com> <78883f84-dceb-9b24-b1f3-321d84091a85@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <78883f84-dceb-9b24-b1f3-321d84091a85@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230131_002555_990903_BB0AE7DD X-CRM114-Status: GOOD ( 23.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 31, 2023 at 04:23:19PM +0800, Ruan Jinjie wrote: > > > On 2023/1/31 15:27, Greg KH wrote: > > On Tue, Jan 31, 2023 at 02:52:11PM +0800, ruanjinjie wrote: > >> This patch is addressing an issue in stable linux-5.10 only. > >> > >> In linux-6.1, the related code is refactored in 124c49b1b("arm64: > >> armv8_deprecated: rework deprected instruction handling") and > >> this issue was incidentally fixed. However, the patch changes a lot and > >> is not specific to this issue. > > > > Then what about 5.15.y? You can not upgrade to that kernel and have a > > regression, right? > > This patch has a pre-dependency af483947d ("arm64: fix oops in > concurrently setting insn_emulation sysctls"), which has not merged into > branches except 5.10.y, so the other branches don't apply. So there is no bug in 5.15.y? That's confusing. > > And nit, you need a ' ' before the '(' character. > > > > But why can we just not take the original commit that fixed this issue? > > That way almost always is the best (prevents regressions, makes > > backports easier, is actually tested, etc.) ? > > Thank you! It is ok to take the original commit to fix this issue. Please submit it after testing. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel