From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 484F7C636CD for ; Wed, 1 Feb 2023 12:47:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MZhaIxTvFuhzkWw08aIcCmz695J6dTE2ZL8jiQzjQXc=; b=yRyU7IUZoav75s+7arw7hFdlbs MtuMaES8Lumsu7asFEfucgyHnyG2NUL7qlmA4UVqsXXgtZIe3uG6OyFI5AxlfnoW1FBSnxNMUHaoN V8EAEGtuiHw69XgSZkhaG+vQuUZ8m9+xingqBn63XGqom8Tsbi199XAR0bf71SrLiT3KyWnPG+/9C TdYnwD/npFF9MnTsb4zNcvXc12nSr36O/fSDE7b9aT3n7V+tXNj8y67rL7pNEDytUBcElUldeVy0n G0e2h5Yx1me6b9tOAWKdQThyv5irDGzsqp2kDGlxiUtnuqjxGGduX4oN2ncRxK9wExCEktEeUs134 nckumg9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNCVB-00BlNc-U2; Wed, 01 Feb 2023 12:46:14 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNCV8-00BlMZ-Kk; Wed, 01 Feb 2023 12:46:12 +0000 Received: by mail-pj1-x1031.google.com with SMTP id l4-20020a17090a850400b0023013402671so2040950pjn.5; Wed, 01 Feb 2023 04:46:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fkTFIuSPLKfoCtXCCCEyL+yG+V8An1lDoLyWCS7QCCE=; b=mA4Ut5jbcgfFDPIma8gjZ/ALtxNk0qxYXRSplQ+1PZ27gYHRY8MUQ9yaB1G2bJ9qYy OjlHRtdx6ChK8qhX96A8+RNKb8BQeA7mRIndjrvkzMw1LVuTSXNNTMuopzazWvzQ9TYs RirB4uVo4tRbqoHUJKUsLj/CAs0Np8s2PO/wyV/79UHa1P2KFvehZf8YisTrTwZ41Aan BaKYGT6SyTcdSKyaoR9kEiksSv8YT1MIy0uOF71d1d/8FBEkGckQEg7Xj+K6H/P5jHE/ dYgl9QNubSBQ0Ss72V2FOXH7E4hbahlOL2TJgtCo4uXk5t44NCSA+wjSS4+Fk6issw1Z JA/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fkTFIuSPLKfoCtXCCCEyL+yG+V8An1lDoLyWCS7QCCE=; b=j5Sm4cr5FIsoE5LB+H4jMA7EUKTZEdGY2X3TWE3MqK3xDs5eGDCvpJeXCcrgyeZv/q e8bqoRXTvafbZoNOBkaSs4B/+jfKGxXWVOycRpLu9h5M2DbbvxJG6xnzYXuJ+B0H+OJ5 ZGU5RrVqI/d4ctn7LhD6lxIOcYYEGj8fGLHnGnDorQ5UXR19yMpx0E4dJiet5EYqpq0u b7P1cylasgdZ6M/ZNnNffVsT+EtTXJcZe6VeBsZbb5HogtDkAs2l5p8+MQ39OYyHD28C z6dElsMD3INMR22wjFMJqlNFTRIWQbCkg7bBKATX6XdbdHmGOelXP5Xb+SB2gL4MEYaJ rTzw== X-Gm-Message-State: AO0yUKVSM2/jHJDWjvatmi3rSa+TB48MJM9kSX+IN3DZT/LwMK3alDuz NjoNgTTlgEWxVE//DYZvOUo= X-Google-Smtp-Source: AK7set/+oQpZ3sqH5WEgSzWEjuYdwtIXqhHCYm96eYbih6oxEetY39DrwiJaHfMPJWJ5/5eWaj2RpA== X-Received: by 2002:a05:6a20:8e22:b0:bc:3290:5759 with SMTP id y34-20020a056a208e2200b000bc32905759mr2910934pzj.34.1675255566873; Wed, 01 Feb 2023 04:46:06 -0800 (PST) Received: from pek-khao-d2 (unknown-105-121.windriver.com. [147.11.105.121]) by smtp.gmail.com with ESMTPSA id h10-20020a056a001a4a00b0058df440d51esm11315252pfv.193.2023.02.01.04.46.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 04:46:06 -0800 (PST) Date: Wed, 1 Feb 2023 20:45:58 +0800 From: Kevin Hao To: Jakub Kicinski Cc: Heiner Kallweit , Andrew Lunn , Russell King - ARM Linux , David Miller , Paolo Abeni , Eric Dumazet , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Amlogic Meson..." , Chris Healy Subject: Re: [PATCH net] net: phy: meson-gxl: use MMD access dummy stubs for GXL, internal PHY Message-ID: References: <23ecd290-56fb-699a-8722-f405b723b763@gmail.com> <20230131215528.7a791a54@kernel.org> MIME-Version: 1.0 In-Reply-To: <20230131215528.7a791a54@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230201_044610_723967_ACA977EA X-CRM114-Status: GOOD ( 14.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2048506325736349493==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2048506325736349493== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Mk4AfqfvQZZ1jb0O" Content-Disposition: inline --Mk4AfqfvQZZ1jb0O Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 31, 2023 at 09:55:28PM -0800, Jakub Kicinski wrote: > On Tue, 31 Jan 2023 22:03:21 +0100 Heiner Kallweit wrote: > > Jerome provided the information that also the GXL internal PHY doesn't > > support MMD register access and EEE. MMD reads return 0xffff, what > > results in e.g. completely wrong ethtool --show-eee output. > > Therefore use the MMD dummy stubs. > >=20 > > Note: The Fixes tag references the commit that added the MMD dummy > > access stubs. > >=20 > > Fixes: 5df7af85ecd8 ("net: phy: Add general dummy stubs for MMD registe= r access") >=20 > Please make sure to CC the author. Adding Kevin Hao The changes look fine to me, but the using of the "Fixes" tag seems a bit w= eird. The "Fixes" tag is used to specify the commit causing regression instead of= patch prerequisite. Thanks, Kevin --Mk4AfqfvQZZ1jb0O Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEHc6qFoLCZqgJD98Zk1jtMN6usXEFAmPaXwYACgkQk1jtMN6u sXGSEAf/aq9hSch/hWtBwo81OFaSkRoIMDg4Dc2g5ql9SQMc8Nxvd+o540SbCXuX h988OPOrvw7JXUEswqX2GJMIwgJAYpDQsfmzkAkwszgMY4Vh8ZepoUvMQK6fjxUU lipFEBekx5ZWL8WPQSbsXjx9TUvi30qTq3KIXc32UyBA/OqQDyrjOEv8LmaLlZj8 nJFeiF999+tvG7yXAmczxbsfvV2tl29FB/SwyTT2UsYeVuPp5klPkumyzHBmfCXg tv7938MAL+5gF80jAUhbj4yaUPXhxGA0/DE4pv+9iV7eHDT2m4fWxrzISprylzzF EbExviPu5xzwIzcJd3xdJo11wX60KA== =YW6S -----END PGP SIGNATURE----- --Mk4AfqfvQZZ1jb0O-- --===============2048506325736349493== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2048506325736349493==--