From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5C71C05027 for ; Wed, 1 Feb 2023 16:58:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XiwL6uZQldEzLkmmo+6ZgsuaCh777FlGR+IpGJ4Lt94=; b=mHJPFfamc7jjDq PeK0nL7dxEuLXP3qsLrQGxKQ3QTdH03/MaolNinVLBou4/3qsUFQY4KjFmG7Usej86/hWO2oLOKI6 8UFYM0t7t8Xo7JY6DvMYfzpP6bsygc9qp5o8l/IMO02uBeYbUqGvYwlWG/kEIFc1ELqsyfwX98FcU 2C1UAjq11tiS0Yy6JG4PyD7Aka1sJx0VjrOnGuIcHgQG4ultG3HjJmFcwllyy2/a5AlsJ0MnIdaFB OdPv4aQkbteMvT4rVlTK3ZW9JSU5za9IOoIiNJ2htFvo8kdK5fs17lTScSDHxOmoHx6X6BMTml6ml yiciWK0lZzCHGl2gtRlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNGQH-00Cupd-GV; Wed, 01 Feb 2023 16:57:25 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNGQE-00Cukx-54 for linux-arm-kernel@lists.infradead.org; Wed, 01 Feb 2023 16:57:23 +0000 Received: by mail-ej1-x62f.google.com with SMTP id k4so47814919eje.1 for ; Wed, 01 Feb 2023 08:57:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5QwLG2T0p0/wJ6lz+hF7UZawl4kCGwRAecIdikVjtEo=; b=FjiELNOx4rVbcVrAuGwCv258MtT3ykNsIol/GqUpI0nt+Edk0r1icdxutjlmTcXBWW GZ0V9voJ08dFm3E2wMYq6E7SMJ9cZWjL2ObcTY7C1ggoWR7sihQ/Afp4BDOKJGDCotPv D4Jdlut/yMLyzF9tvIMo4sXDiX9IdrBmHptId5qYX8Q6tKdFCufPLxz/0/jSaarruZ9e YftF69lT280fZq2surf4jBOozRQOl8Huf+8cVVp6k6pCXbi5EQQp6IZJW+2J3x1TTvJZ Q7GuvvU7UTTVyyvsoKlHyf1jcZMugXO52qvphTuNl2WtYU2DriOkvH0D53/yQc8Vwpeb CIKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5QwLG2T0p0/wJ6lz+hF7UZawl4kCGwRAecIdikVjtEo=; b=NV6QNhpedb9pGawnOiN1SRx6MHpmFYlZdsfMf5TGQ1prZdMJr6Yr+h9Z22xivsPS9+ TTlz8UUE5wMOZooMR9WludyaIXCXcMWES9hh/4et/SYiFFri6Jdyzl8qVE4KKGzj8sjx MHLEGnsCSCycQfuHpvfIHMUs7ya2v/+FPp0t7GayU6EdKgCQkKy5f0OdegoGbjxcjN9M 3hhSCvYMify0sGJSUtTtbt99MBC3nHrJ9+FfnBRpU8sXNGVsa1oPkBA2IUQPzGSpdvrB py8MC2028iBRSxF7wG+KexZKTK27tT6AiIrKfVmBUIbyt6MXeMTGTKifjehT8OsFJzKz Fj5A== X-Gm-Message-State: AO0yUKVcCZgYry+0uytDjsGNmutjjMff4+M0qr79/OooPe+K9MZ0Tunz ugPouDjPnEEyCVwGuuG+TeSfrA== X-Google-Smtp-Source: AK7set9KH3KAy6EZVpBWgeg+qNgCuSj1hLv7Q2CPEU+vYqF8yGOPPNkySgRFVjuyZvEfvpW8fknKDg== X-Received: by 2002:a17:906:2c6:b0:887:87e2:5102 with SMTP id 6-20020a17090602c600b0088787e25102mr7004327ejk.13.1675270634684; Wed, 01 Feb 2023 08:57:14 -0800 (PST) Received: from google.com (64.227.90.34.bc.googleusercontent.com. [34.90.227.64]) by smtp.gmail.com with ESMTPSA id d13-20020a170906344d00b0088385cd6166sm7094168ejb.195.2023.02.01.08.57.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 08:57:13 -0800 (PST) Date: Wed, 1 Feb 2023 16:57:09 +0000 From: Quentin Perret To: Marc Zyngier Cc: Catalin Marinas , Will Deacon , James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu, kernel-team@android.com Subject: Re: [PATCH 0/4] KVM: arm64: Fix CPU resume/on with pKVM Message-ID: References: <20230201103755.1398086-1-qperret@google.com> <86bkmd1ly4.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <86bkmd1ly4.wl-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230201_085722_211239_4A6C096C X-CRM114-Status: GOOD ( 25.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wednesday 01 Feb 2023 at 14:48:03 (+0000), Marc Zyngier wrote: > On Wed, 01 Feb 2023 10:37:50 +0000, > Quentin Perret wrote: > > > > When using pKVM, we do not reset the EL2 exception vectors back to the > > stubs for e.g. Power Management or CPU hotplug as we normally do in KVM. > > As consequence, the initialisation perfomed by __finalise_el2 is missing > > on e.g. the CPU_RESUME path with pKVM, hence leaving certain registers > > in an incorrect state. > > > > One such example is ZCR_EL2 which remains configured with SVE traps > > enabled. And so using SVE on a CPU that has gone through a hotplug > > off/on cycle leads to a hyp panic. Not good. > > > > This series fixes this by macroizing the first half of __finalise_el2 > > (that is, the part that is not specific to VHE) to allow its re-use > > from pKVM's PSCI relay. > > For the series: > > Reviewed-by: Marc Zyngier > > I think it might be a bit late to send this as fixes for 6.2 (my > latest pull request for kvmarm-fixes-6.2-3 is still in limbo), so I'd > suggest we take it for 6.3. Works for me. > How do you want to deal with the backports? None of the patches have a > Cc: stable, and only the last one has a Fixes: tag, but cannot be > applied standalone. Right, I wasn't sure what was best -- the first patches aren't really fixing anything per se but yeah, we kinda need them... Happy to re-post a version with the same 'Fixes:' tag on all patches and 'Cc: stable' everywhere if that makes things easier. Wdyt? Cheers, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel