From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47EB3C61DA4 for ; Thu, 2 Feb 2023 16:10:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UJQfw0xRnhVOqRAnsFYb5FOuuADhaYYb0Nt2XDL3aeg=; b=jAUyCQkCxFiXC/ LlL6HHiJYmibuIuJJYspC+AhGax0X2EO+n5f5FWH9/uXjmcWWlJUeIgL5luz1uJmtBFsSIwG6aYsE Bfaq36utV8GWoTFAyUcnG+D9CoGH+RwBmohsuaD9fR9wujJLppHWNv0Oto4Pa4Evn2QYXmJUybe7n M/LKHLNnMiyaJ0QLTnX3QRuRzCR0LlCuCecXLhBG1CZXG+8Aq99BgeEJ/eORnlRsyVfmVLoNDNd6j ilMjxrjLrOPZphSoblDdmgghmCBmbpsE6ZGBmY9NmzcCNSTRsAoEc3J6M2YmizrbTofGaqO+peQTM tsdJDIjZh/BWJIoKV9NA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNc9g-00GaS7-BH; Thu, 02 Feb 2023 16:09:44 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNc9c-00GaPx-V3 for linux-arm-kernel@lists.infradead.org; Thu, 02 Feb 2023 16:09:42 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 203BEB8265E; Thu, 2 Feb 2023 16:09:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54ABEC433EF; Thu, 2 Feb 2023 16:09:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675354177; bh=xjNBvclZKFnIHn9hRQhrxBHvSbPwMKJe/L5bKZulUDM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YKwX9vpOm7OPqRcBWD60/Kcla5InDbtRaafHfflIRtWCcFuEscArPK7Z1O2px2hiz PoR6bR4dy7UePHOGngn1BGINwwcmRhCjt9xulXO+gV8O909OctHENGX9EkKynHVP2p 2plz2lqZrjOnkQYxDzcW1yxDPGTYLhyE+nX28LtVHKf3D+DxFZc718+NZ+KtscHv8S 6O9DQoTp1gtB7frsriKqaBoNdirBk5ktfBq1FKK3FayD7GZR5M0EKUqE5vUkotW2YM m0/DTMLvSCDVVDKpOiBpxhTXOO8rhXuitPP2kImZ+oZTk5LzApRg94WusgYUrXP2n9 aw3zRwi7sStQg== Date: Thu, 2 Feb 2023 17:09:31 +0100 From: Lorenzo Pieralisi To: Matt Ranostay , robh@kernel.org Cc: rogerq@kernel.org, kw@linux.com, bhelgaas@google.com, krzysztof.kozlowski@linaro.org, vigneshr@ti.com, tjoseph@cadence.com, sergio.paracuellos@gmail.com, pthombar@cadence.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 3/5] PCI: j721e: Add PCIe 4x lane selection support Message-ID: References: <20221124081221.1206167-1-mranostay@ti.com> <20221124081221.1206167-4-mranostay@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221124081221.1206167-4-mranostay@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230202_080941_314904_4137F073 X-CRM114-Status: GOOD ( 21.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, I think your comment: https://lore.kernel.org/linux-pci/CAL_JsqJ5cOLXhD-73esmhVwMEWGT+w3SJC14Z0jY4tQJQRA7iw@mail.gmail.com was related to the commit log wording and not necessarily the actual diff. Please let me know if you are happy with this change and I shall merge the series. Thanks, Lorenzo On Thu, Nov 24, 2022 at 12:12:19AM -0800, Matt Ranostay wrote: > Add support for setting of two-bit field that allows selection of 4x lane > PCIe which was previously limited to only 2x lanes. > > Signed-off-by: Matt Ranostay > Reviewed-by: Vignesh Raghavendra > --- > drivers/pci/controller/cadence/pci-j721e.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c > index 8990f58d64d5..dab3db9be6d8 100644 > --- a/drivers/pci/controller/cadence/pci-j721e.c > +++ b/drivers/pci/controller/cadence/pci-j721e.c > @@ -42,7 +42,6 @@ enum link_status { > }; > > #define J721E_MODE_RC BIT(7) > -#define LANE_COUNT_MASK BIT(8) > #define LANE_COUNT(n) ((n) << 8) > > #define GENERATION_SEL_MASK GENMASK(1, 0) > @@ -52,6 +51,7 @@ struct j721e_pcie { > struct clk *refclk; > u32 mode; > u32 num_lanes; > + u32 max_lanes; > void __iomem *user_cfg_base; > void __iomem *intd_cfg_base; > u32 linkdown_irq_regfield; > @@ -205,11 +205,15 @@ static int j721e_pcie_set_lane_count(struct j721e_pcie *pcie, > { > struct device *dev = pcie->cdns_pcie->dev; > u32 lanes = pcie->num_lanes; > + u32 mask = GENMASK(8, 8); > u32 val = 0; > int ret; > > + if (pcie->max_lanes == 4) > + mask = GENMASK(9, 8); > + > val = LANE_COUNT(lanes - 1); > - ret = regmap_update_bits(syscon, offset, LANE_COUNT_MASK, val); > + ret = regmap_update_bits(syscon, offset, mask, val); > if (ret) > dev_err(dev, "failed to set link count\n"); > > @@ -439,6 +443,8 @@ static int j721e_pcie_probe(struct platform_device *pdev) > ret = of_property_read_u32(node, "num-lanes", &num_lanes); > if (ret || num_lanes > data->max_lanes) > num_lanes = 1; > + > + pcie->max_lanes = data->max_lanes; > pcie->num_lanes = num_lanes; > > if (dma_set_mask_and_coherent(dev, DMA_BIT_MASK(48))) > -- > 2.38.GIT > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel