From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 567CAC433E9 for ; Thu, 14 Jan 2021 18:59:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F20E523B31 for ; Thu, 14 Jan 2021 18:59:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F20E523B31 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2Jcs+xHA953diw3JOoMtDvyQXUkJhlpJDfGWYkAp9u0=; b=0M+qyQ6hmeDswr9NCLTVNXU5z bzEfeqmbh+Ouz3LWF+twPOoZAam97/5We2fEpX7DhsDlhFNMUul9ESRwxV0JpXyAvtSTQJpOXW27e lw3bdjQ0SU3kDd5GfTn/ChdyCCFa2etFhyjWPn/w6mo0W1fDZSAqUXRrQjhP0G2MI3jYwtu5R92Ck sD72AOILoUEPMZScKDs3ydHZmQjYnuolgeKwrJXCc6J5YwGul3wOkc5T/o92BCM9VQgmsRCUcGXUH 3b9vnEqTLD0a+uebgdBPahq14xmPntHLTDWEien+17byspo+kdRmeGLw7hWYHtX7jX5wAHbHgqwxw +H/BH6xKQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l07oY-0005f2-Np; Thu, 14 Jan 2021 18:57:46 +0000 Received: from mout.gmx.net ([212.227.15.19]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l07oW-0005eU-75 for linux-arm-kernel@lists.infradead.org; Thu, 14 Jan 2021 18:57:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1610650622; bh=qTnwybr7PbsPLKQjkyg5ukkUUsz3nfbiEC4dr4IScgk=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=WE6yu5cBKqBlZd+2auacjujUWLevlLZZmWkpwCVHpWDNprXL0Vtof3vNJ44NMAjHZ ORRi5dByXY+wcMZvsCeuLt02YGf0cyXzTpBfcS8SrXRdcevt1ug/sBfxoq2SLUsDEy fHMhD6UgaAs9vfROLDBfpUB2dXAwdOblNJvuGIfA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from longitude ([5.146.194.208]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M3UUy-1l0flf2kUM-000c5l; Thu, 14 Jan 2021 19:57:02 +0100 Date: Thu, 14 Jan 2021 19:56:51 +0100 From: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= To: Andreas Kemnade Subject: Re: [PATCH v7 3/7] mfd: Add base driver for Netronix embedded controller Message-ID: References: <20210109180220.121511-1-j.neuschaefer@gmx.net> <20210109180220.121511-4-j.neuschaefer@gmx.net> <20210112203649.67f66996@aktux> MIME-Version: 1.0 In-Reply-To: <20210112203649.67f66996@aktux> X-Provags-ID: V03:K1:cfFZLGgxjJbjT3NU7hnDESPThEwx2O8w4wIxZ67/Uqiws1AR9t0 9FCBqnb6Kyvt6JlTv8eQOjBDHYyEyJymQBOzSJCjcvUALYN6khskivau2zg385i+XZL/OR7 TEBIR8vN6ySlqPIlSXiiRdRlxiiicZlH24xk0SJRik4ZLuXZQmowI9QeN2Os7OzLmxL681M d/fPe6Rbzr4mPKsTc354Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:wUOO+tWvK3k=:7eZPRXsOhlOSHNHavMx/JP ClzFnZRTnPvgBvfuhyuzNjXEGj9LY57QS8xSJ/gk6/D3eqT9/GkhC4lgrg3ufdfPbF+andw7x UW9A4DYAU3rjdbB9PrMOm4lzEl+9oNeMWSQKzoB25Mw9imgIa6EL+qfbObvePCuTrFH4bCSWf S2WPzSkb3gVhTAbfn8zHHpnAA4qUkz/SNuBq6/w4AkbQ+ngpHcJdfh3TPqoGUz97vFYM4+DUu oODoi683Sqs0qry53f6jt1V7f/+gtyhbFvvSpI8z2EwWLjogQC8x7nqlDYZWHdOz3i+R89W24 dC2ixfzuuxumJ5anpdHkbbjl4a17lhrC5BSC901cf/qY4o+VL4MjezMCXb1TbzjEN6VRZfh6v pNIKw918k7l6CpAGr5fB7Mt0SA8tcu03RhDWTYMq5EXnZeEiEdSD5jX2gY18HZQIgWJSoKzWc rV3V87ltBPTCDQeCzOqM/TUeO89+J29LUAAJqrgAwCDXk/N0ZlgziG0NX2XqZtuoDby2hVlK9 BYEJzYK19deX1gTYF3R8jVEFNnDoPcagC1KwOwGqFhw1cXvNe1GAwY1cOjryg6p5VWTe3Sdq6 l/iVxkFnpSeLUnL/rV0Fbowmw4uSwGO1T6jbr0JKqevhQSPFOIinDg9XGZvQYx08qEd7y8U9h /aCbHZfiCqdAJ3siVXDZbAZuVpIsbKn9YazVW5DSXkTATq0zDnr9L8mq0gM5EMJdbuSqKd4ZA 708TAgBvjInsb9AL5KGMerlUjEP/XGyLv4FRXov83lrhcKMcX151OLIZJSA52BNfZ6y2fuMCC gbeXYJvKqeZzc4E3qM29xV6upyu6NI13wTyMeEV2fVwQxzXlXEUDVczXQbwyOiIMjzFP4zfdu MdKhj+NggeNW0A11FlDg== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210114_135744_563874_0B8CD39F X-CRM114-Status: GOOD ( 15.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Heiko Stuebner , linux-pwm@vger.kernel.org, Linus Walleij , Thierry Reding , Fabio Estevam , linux-rtc@vger.kernel.org, Arnd Bergmann , Mauro Carvalho Chehab , Sam Ravnborg , Daniel Palmer , Andy Shevchenko , NXP Linux Team , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , devicetree@vger.kernel.org, Stephan Gerhold , allen , Sascha Hauer , Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , Lubomir Rintel , Rob Herring , Lee Jones , linux-arm-kernel@lists.infradead.org, Alessandro Zummo , linux-kernel@vger.kernel.org, Mark Brown , Pengutronix Kernel Team , Heiko Stuebner , Josua Mayer , Shawn Guo , "David S. Miller" Content-Type: multipart/mixed; boundary="===============7023065226913443534==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7023065226913443534== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HZCy9zKgDQy/QBjw" Content-Disposition: inline --HZCy9zKgDQy/QBjw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 12, 2021 at 08:36:49PM +0100, Andreas Kemnade wrote: > On Sat, 9 Jan 2021 19:02:16 +0100 > Jonathan Neusch=C3=A4fer wrote: [...] > > +static const struct of_device_id of_ntxec_match_table[] =3D { > > + { .compatible =3D "netronix,ntxec", }, > > + {} > > +}; > > + > MODULE_DEVICE_TABLE? Yes, good idea. > > +static struct i2c_driver ntxec_driver =3D { > > + .driver =3D { > > + .name =3D "ntxec", > > + .of_match_table =3D of_ntxec_match_table, > > + }, > > + .probe_new =3D ntxec_probe, > > + .remove =3D ntxec_remove, > > +}; > > +module_i2c_driver(ntxec_driver); >=20 > MODULE_LICENSE()? >=20 > modpost moans about that here. I forgot those. Thanks for noticing. I'll add the MODULE_ lines in v8. Thanks, Jonathan --HZCy9zKgDQy/QBjw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmAAk+oACgkQCDBEmo7z X9szGg//QvOXORc7uh9Jjyie8pM10KL+AGsOtYoNGGd6pZu/uUmCTdY3bJ3PsYNS tFEETWnnlg7zvIvi5ct92QGwmIYtg2zd1gYQbwOh513AGCArH94ow7g6aJtxk3HA I8Xd/4pMrMaDZpv9S6xc09EBCLvniWaUxQ+1b/NAf4PgHDQpH/aOcoxG8PxxxsDD dfBEqCOWR6rAKAy1wA0gdzzSX+v7QMoYnejpAjLdi1Lhnu6v2GhzYsPMiSxC95i+ ZzZna44PPaVE8LiwC2PqORimyXsF63srsY93kZEFfd10qe+zGCZx7qLjBLiKeTK8 JMt7QUz3ll9SWF8oYlMdofO7HHrtmqnWTMjgaYbhYqr2oqOunLWKyF2RUF1OMlU2 0HZS+wX3PGODLsPeyVup3Qx9hrkqQI2AOsQyW1nyDu/idUjC4bPGTK/7QpOGWFwx eI3riV02jUpETGg93V3OrcHhefNdLJIPd9FGNDuz4gI1nmSggzfcnNlGIWvk1Pdi ELV+NBvGXnxKPHvjlKSyiI5/oqw4Ernexb+yRnn0spfB8zGzomzUXOkp0WD8a0FA 5KT3UW/KnYg9kAl41zZksLacmuj4gQ7ZKRd2M2rakue0gi7mji1Zd8LZO7K6W4lb LV4K5c05oLVqjumvUDXEzlrb9KfRz18HrBZs/F1d3+iV/6k0r74= =fKvQ -----END PGP SIGNATURE----- --HZCy9zKgDQy/QBjw-- --===============7023065226913443534== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7023065226913443534==--