From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5C05C433DB for ; Mon, 18 Jan 2021 08:43:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5714F206B5 for ; Mon, 18 Jan 2021 08:43:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5714F206B5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yjU0eUZDzqqXtpEwMT72AgdD4jCmmxl+62UUztiuGVs=; b=q3qrc4H/0Qu3cUpPZQUDqOnKl N3fA4OZtxt4GZjp67QcGxOtQXTzDu0iHd804oHlhgiCU4PvK+AsCgEl60rNHrjm04LKxmqP+vuVRr Y+eWWPTwT5aultpuqODTtor2WCKQOtYEG8f6dD6X2XUM+ON5K3Vq94bYWz8qRCYiAcKkiMrWySC7D 1JoyNq7S5hGSzdbKg6wa1eoIZJvayIJbAh03EOnV1pqLzwpYQ1/Nbyv7O6a9yMGUB2ATWQL6+KNos nQi5exhijtiBH7xhJczfrWX2tfj6Pjl22wAzNelf/rjE92ggqWxhFaBw0haZofYNFAPDKrYRX7Afq AO+RcGC+g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1Q6m-0002C8-MT; Mon, 18 Jan 2021 08:41:56 +0000 Received: from muru.com ([72.249.23.125]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1Q6k-0002BP-LG for linux-arm-kernel@lists.infradead.org; Mon, 18 Jan 2021 08:41:55 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 4C0EE80AE; Mon, 18 Jan 2021 08:41:49 +0000 (UTC) Date: Mon, 18 Jan 2021 10:41:46 +0200 From: Tony Lindgren To: Arnd Bergmann Subject: Re: [PATCHv2] drivers: bus: simple-pm-bus: Fix compatibility with simple-bus for auxdata Message-ID: References: <20210118073340.62141-1-tony@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210118_034154_733193_EFBB6694 X-CRM114-Status: GOOD ( 23.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: DTML , Arnd Bergmann , Geert Uytterhoeven , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Rob Herring , linux-omap , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Arnd Bergmann [210118 08:30]: > On Mon, Jan 18, 2021 at 8:33 AM Tony Lindgren wrote: > > > > After converting am335x to probe devices with simple-pm-bus I noticed > > that we are not passing auxdata for of_platform_populate() like we do > > with simple-bus. > > > > While device tree using SoCs should no longer need platform data, there > > are still quite a few drivers that still need it as can be seen with > > git grep OF_DEV_AUXDATA. We want to have simple-pm-bus be usable as a > > replacement for simple-bus also for cases where OF_DEV_AUXDATA is still > > needed. > > > > Let's fix the issue by passing auxdata as platform data to simple-pm-bus. > > That way the SoCs needing this can pass the auxdata with OF_DEV_AUXDATA. > > And let's pass the auxdata for omaps to fix the issue for am335x. > > > > As an alternative solution, adding simple-pm-bus handling directly to > > drivers/of/platform.c was considered, but we would still need simple-pm-bus > > device driver. So passing auxdata as platform data seems like the simplest > > solution. > > > > Fixes: 5a230524f879 ("ARM: dts: Use simple-pm-bus for genpd for am3 l4_wkup") > > Signed-off-by: Tony Lindgren > > --- > > Changes since v1: Updated description, added devicetree list to Cc > > This looks fine to me for now > > Acked-by: Arnd Bergmann Thanks for the review. > But I think we should take the time to discuss how to phase out auxdata > over time. There are still a number of users, but it's not that many in the > end. For some of them I see a clear solution, for other ones I do not: Yes agreed we should remove the auxdata use. > omap2: I'll leave these for Tony to comment The three hardest ones to update (because of PM dependencies): - PRM power managment interrupts that also pinctrl driver uses - The enable/disable of clockdomain autoidle that at least ti-sysc uses - Smartreflex PM dependencies to voltage controller For the ones above, I'll try to come up with something eventually. The others should be just straight forward driver updates needed. The hsmmc dependencies would be ideally fixed by moving to use sdhci driver, but at least custom voltage handling and sdio support needs work. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel