From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF072C433DB for ; Tue, 19 Jan 2021 00:35:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C15121D42 for ; Tue, 19 Jan 2021 00:35:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C15121D42 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rDRvaIAtSG6HD55oRmVFyoYoTTd4pGcERERe8Te9mw8=; b=gjLfHIxOOWIaYmZ0cf2dSkJ1S OWSH5MWwPi9ETT2RZn7CHJv7bNFv/4i6Jun+/5wviJz2q7HI76Rtf4vtOpaUzlhSgwmICWD+FyvaS 7W8M5/LL23z0tsJWl4AKSm6d7fRyg46l2StkJOeRj6eoN0tn6Y7/CBLP7tJR2f4bFgOrSpqFLIl+e yYydQh4UURZ3z5jfRiGCgWpUr5bGtrZPK+XcP8th7CWExKJZAliSa0QNDAVzZZZspF8Mcmdr0AiW9 rdUpv9lAryka6n7D7ASlz4VL6IwXrZrTko7sE7LIL2guk6cwKuzBIPx08yaMQIhAE35Tb8Bf06m+J s/VxjZ6bQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1exl-0007fU-ER; Tue, 19 Jan 2021 00:33:37 +0000 Received: from mail-pj1-f45.google.com ([209.85.216.45]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1exh-0007ej-Ne for linux-arm-kernel@lists.infradead.org; Tue, 19 Jan 2021 00:33:34 +0000 Received: by mail-pj1-f45.google.com with SMTP id l23so10985062pjg.1 for ; Mon, 18 Jan 2021 16:33:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7rDRopC82DR8SCQXLHu8GoZEQ0kPieDkm9TRSwV7rgQ=; b=jcpAMM+h2qTOmIIYyDYxRIY0Q/3ux9AcsjkkhKNhQW2IJpdjTTR5wmBIq5ZGOVeYqV 1tHaTywPHF3LUoZBf45d2lk914Q7pBnFZEU4KXbU/PbN31pFlO0mkdlJenqyqjAM6EF4 MFB9LLT1sF4kJtqieJf2gBj07pSWmdoNj1agn9lf5haUIXwTtqV/a/vnY8L/A0pp3trL mSfZ8XJV6JY9XrccRnnh/RDTSneWpVT/n/QSH+C8CvRIfl1vyTx9hLLUAy8y0vrGtsLx NMBrufAllb5VKlm3OrHM/+rzIZGjzSiFatEP5GR7uoy2bD1pXx0yo+ip/AT+JWwcp3C4 gQBw== X-Gm-Message-State: AOAM532USSq4RzvwVwJHx51e9vxWNxrxbQMwZ3pM1Bptz+rdzP5u32h0 DocSOIh/a3nagIVRKUvJT1c= X-Google-Smtp-Source: ABdhPJyBXIZoQqYjC0C0/6S4LO7EIwuy8qQ6NnQiHWF1V75m5VxXkjNQNn9E7wQwxr++clKqK5IfgQ== X-Received: by 2002:a17:90a:5209:: with SMTP id v9mr2126839pjh.8.1611016409366; Mon, 18 Jan 2021 16:33:29 -0800 (PST) Received: from localhost ([2601:647:5b00:1161:a4cc:eef9:fbc0:2781]) by smtp.gmail.com with ESMTPSA id x81sm6844446pfc.46.2021.01.18.16.33.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jan 2021 16:33:28 -0800 (PST) Date: Mon, 18 Jan 2021 16:33:26 -0800 From: Moritz Fischer To: Nava kishore Manne Subject: Re: [PATCH 3/3] fpga: versal-fpga: Add versal fpga manager driver Message-ID: References: <20210118024318.9530-1-nava.manne@xilinx.com> <20210118024318.9530-3-nava.manne@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210118024318.9530-3-nava.manne@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210118_193333_783312_56129FA0 X-CRM114-Status: GOOD ( 32.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, trix@redhat.com, linux-fpga@vger.kernel.org, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, mdf@kernel.org, git@xilinx.com, Appana Durga Kedareswara rao , linux-arm-kernel@lists.infradead.org, chinnikishore369@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nava, On Mon, Jan 18, 2021 at 08:13:18AM +0530, Nava kishore Manne wrote: > This patch adds driver for versal fpga manager. Nit: Add support for Xilinx Versal FPGA manager > > PDI source type can be DDR, OCM, QSPI flash etc.. No idea what PDI is :) > But driver allocates memory always from DDR, Since driver supports only > DDR source type. > > Signed-off-by: Appana Durga Kedareswara rao > Signed-off-by: Nava kishore Manne > --- > drivers/fpga/Kconfig | 8 ++ > drivers/fpga/Makefile | 1 + > drivers/fpga/versal-fpga.c | 149 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 158 insertions(+) > create mode 100644 drivers/fpga/versal-fpga.c > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig > index 5645226ca3ce..9f779c3a6739 100644 > --- a/drivers/fpga/Kconfig > +++ b/drivers/fpga/Kconfig > @@ -216,4 +216,12 @@ config FPGA_MGR_ZYNQMP_FPGA > to configure the programmable logic(PL) through PS > on ZynqMP SoC. > > +config FPGA_MGR_VERSAL_FPGA > + tristate "Xilinx Versal FPGA" > + depends on ARCH_ZYNQMP || COMPILE_TEST > + help > + Select this option to enable FPGA manager driver support for > + Xilinx Versal SOC. This driver uses the versal soc firmware > + interface to load programmable logic(PL) images > + on versal soc. > endif # FPGA > diff --git a/drivers/fpga/Makefile b/drivers/fpga/Makefile > index d8e21dfc6778..40c9adb6a644 100644 > --- a/drivers/fpga/Makefile > +++ b/drivers/fpga/Makefile > @@ -18,6 +18,7 @@ obj-$(CONFIG_FPGA_MGR_TS73XX) += ts73xx-fpga.o > obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o > obj-$(CONFIG_FPGA_MGR_ZYNQ_FPGA) += zynq-fpga.o > obj-$(CONFIG_FPGA_MGR_ZYNQMP_FPGA) += zynqmp-fpga.o > +obj-$(CONFIG_FPGA_MGR_VERSAL_FPGA) += versal-fpga.o > obj-$(CONFIG_ALTERA_PR_IP_CORE) += altera-pr-ip-core.o > obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o > > diff --git a/drivers/fpga/versal-fpga.c b/drivers/fpga/versal-fpga.c > new file mode 100644 > index 000000000000..2a42aa78b182 > --- /dev/null > +++ b/drivers/fpga/versal-fpga.c > @@ -0,0 +1,149 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (C) 2021 Xilinx, Inc. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +/* Constant Definitions */ > +#define PDI_SOURCE_TYPE 0xF > + > +/** > + * struct versal_fpga_priv - Private data structure > + * @dev: Device data structure > + * @flags: flags which is used to identify the PL Image type > + */ > +struct versal_fpga_priv { > + struct device *dev; > + u32 flags; This seems unused ... please introduce them when/if you start using them. > +}; > + > +static int versal_fpga_ops_write_init(struct fpga_manager *mgr, > + struct fpga_image_info *info, > + const char *buf, size_t size) > +{ > + struct versal_fpga_priv *priv; > + > + priv = mgr->priv; > + priv->flags = info->flags; ? What uses this ? It seems this function could just be 'return 0' right now. > + > + return 0; > +} > + > +static int versal_fpga_ops_write(struct fpga_manager *mgr, > + const char *buf, size_t size) > +{ > + struct versal_fpga_priv *priv; > + dma_addr_t dma_addr = 0; > + char *kbuf; > + int ret; > + > + priv = mgr->priv; > + > + kbuf = dma_alloc_coherent(priv->dev, size, &dma_addr, GFP_KERNEL); > + if (!kbuf) > + return -ENOMEM; > + > + memcpy(kbuf, buf, size); > + > + wmb(); /* ensure all writes are done before initiate FW call */ > + > + ret = zynqmp_pm_load_pdi(PDI_SOURCE_TYPE, dma_addr); > + > + dma_free_coherent(priv->dev, size, kbuf, dma_addr); > + > + return ret; > +} > + > +static int versal_fpga_ops_write_complete(struct fpga_manager *mgr, > + struct fpga_image_info *info) > +{ > + return 0; > +} > + > +static enum fpga_mgr_states versal_fpga_ops_state(struct fpga_manager *mgr) > +{ > + return FPGA_MGR_STATE_OPERATING; Is that always the case? Shouldn't that be FPGA_MGR_STATE_UNKNOWN? > +} > + > +static const struct fpga_manager_ops versal_fpga_ops = { > + .state = versal_fpga_ops_state, > + .write_init = versal_fpga_ops_write_init, > + .write = versal_fpga_ops_write, > + .write_complete = versal_fpga_ops_write_complete, > +}; > + > +static int versal_fpga_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct versal_fpga_priv *priv; > + struct fpga_manager *mgr; > + int err, ret; Please pick one, err or ret. 'err' seems unused? > + > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > + priv->dev = dev; > + ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); > + if (ret < 0) { > + dev_err(dev, "no usable DMA configuration"); Nit: "no usable DMA configuration\n" > + return ret; > + } > + > + mgr = devm_fpga_mgr_create(dev, "Xilinx Versal FPGA Manager", > + &versal_fpga_ops, priv); > + if (!mgr) > + return -ENOMEM; > + > + platform_set_drvdata(pdev, mgr); > + Replace this part: > + err = fpga_mgr_register(mgr); > + if (err) { > + dev_err(dev, "unable to register FPGA manager"); > + fpga_mgr_free(mgr); > + return err; > + } with: return devm_fpga_mgr_register(mgr); I tried to get rid of the boilerplate, since every driver repeats it (and above calling fpga_mgr_free(mgr) on a devm_fpga_mgr_create() created FPGA manager is wrong?) :) > + > + return 0; > +} > + Then > +static int versal_fpga_remove(struct platform_device *pdev) > +{ > + struct fpga_manager *mgr = platform_get_drvdata(pdev); > + > + fpga_mgr_unregister(mgr); > + fpga_mgr_free(mgr); > + > + return 0; > +} drop this since cleanup is now automatic. > + > +static const struct of_device_id versal_fpga_of_match[] = { > + { .compatible = "xlnx,versal-fpga", }, > + {}, > +}; > + Nit: Drop the newline > +MODULE_DEVICE_TABLE(of, versal_fpga_of_match); > + > +static struct platform_driver versal_fpga_driver = { > + .probe = versal_fpga_probe, > + .remove = versal_fpga_remove, > + .driver = { > + .name = "versal_fpga_manager", > + .of_match_table = of_match_ptr(versal_fpga_of_match), > + }, > +}; > + Nit: Drop the newline > +module_platform_driver(versal_fpga_driver); > + > +MODULE_AUTHOR("Nava kishore Manne "); > +MODULE_AUTHOR("Appana Durga Kedareswara rao "); > +MODULE_DESCRIPTION("Xilinx Versal FPGA Manager"); > +MODULE_LICENSE("GPL"); > -- > 2.18.0 > Thanks, Moritz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel