From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5E69C433DB for ; Wed, 20 Jan 2021 01:33:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77E332222F for ; Wed, 20 Jan 2021 01:33:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77E332222F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y5CmwyE3VpZ2iE74Bq7Aov80atlC2wSMStQRLDW61e0=; b=Adu+hCgxSllOSMO6oKWW1WPpO UciJUkEozxe49EVvfwdmEwh/TqojVt1wOxSGHsCotS0/CZLGOrlR/RymzBgKzxNcz29VR1EwPAg9y hD+PXm52wk8OpePDHhZifRuGeNwObEbFEjZ7csQ4jN3pcRrP6idwbna7S3Di/qhOIHiEGhf+YPoGE h2+lKETgQjL9S2pdRJ7jO7wPCq0XKbsryzkra/zPaIZMzQWcc+qGq/cHVbjkR6esSNp8na4Cbd3id 9+W7q7w4cOc87VjGqQpRLD4l3hWoeJu7L5Y4FdIMghh7cU+M1NCdP8DQQGyPMErSSbxav21T5I0TG UXVn2qzzA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l22MB-0006EZ-Ir; Wed, 20 Jan 2021 01:32:23 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l22L7-0005hC-1A for linux-arm-kernel@lists.infradead.org; Wed, 20 Jan 2021 01:31:20 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 09B40206F9; Wed, 20 Jan 2021 01:31:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611106273; bh=1HkPn5jT7T+qZpeISImoewLL4KyY3IkZxz+hihW1ZXg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VjiUrvI6DCa3D9FgTg2N8RBQma5pmCVL54EtIdiGTGdMOlGUz27B5xOiGEui6cpM9 tUNIi5tTPpZYlzeXBMYsHIWJwUaOuAcOmOj0BFkzqTUR2XcqkzuoJyEdvSPN1RTtDM enXztVS/o/zRCTmKHscCJQdup/3yraUt/xKRDzwbvxImhrLl6h+/oZigkAzfCW6wEi 7VhaPGU8TtwaThswmyak6o54B7juq+kRggr4iHv34iCEax0wdtf5rbXRust7fhJ/fk Rs4sg/J4Zbs6W1HAACn6ctKIsbOqyFoIJBaffPaJ7X2oRJ8vuv5OYgYPmeXXUB1ap1 PkGaVJ2q0rmPw== Date: Wed, 20 Jan 2021 03:31:06 +0200 From: Jarkko Sakkinen To: Sumit Garg Subject: Re: [PATCH v8 2/4] KEYS: trusted: Introduce TEE based Trusted Keys Message-ID: References: <1604419306-26105-1-git-send-email-sumit.garg@linaro.org> <1604419306-26105-3-git-send-email-sumit.garg@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210119_203117_399552_6C22CA2A X-CRM114-Status: GOOD ( 31.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:SECURITY SUBSYSTEM" , Daniel Thompson , op-tee@lists.trustedfirmware.org, Jonathan Corbet , James Bottomley , Janne Karhunen , Linux Doc Mailing List , James Morris , Mimi Zohar , Linux Kernel Mailing List , David Howells , Luke Hinds , "open list:ASYMMETRIC KEYS" , Jarkko Sakkinen , Markus Wamser , Casey Schaufler , linux-integrity@vger.kernel.org, Jens Wiklander , linux-arm-kernel , "Serge E. Hallyn" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 19, 2021 at 12:30:42PM +0200, Jarkko Sakkinen wrote: > On Fri, Jan 15, 2021 at 11:32:31AM +0530, Sumit Garg wrote: > > On Thu, 14 Jan 2021 at 07:35, Jarkko Sakkinen wrote: > > > > > > On Wed, Jan 13, 2021 at 04:47:00PM +0530, Sumit Garg wrote: > > > > Hi Jarkko, > > > > > > > > On Mon, 11 Jan 2021 at 22:05, Jarkko Sakkinen wrote: > > > > > > > > > > On Tue, Nov 03, 2020 at 09:31:44PM +0530, Sumit Garg wrote: > > > > > > Add support for TEE based trusted keys where TEE provides the functionality > > > > > > to seal and unseal trusted keys using hardware unique key. > > > > > > > > > > > > Refer to Documentation/tee.txt for detailed information about TEE. > > > > > > > > > > > > Signed-off-by: Sumit Garg > > > > > > > > > > I haven't yet got QEMU environment working with aarch64, this produces > > > > > just a blank screen: > > > > > > > > > > ./output/host/usr/bin/qemu-system-aarch64 -M virt -cpu cortex-a53 -smp 1 -kernel output/images/Image -initrd output/images/rootfs.cpio -serial stdio > > > > > > > > > > My BuildRoot fork for TPM and keyring testing is located over here: > > > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/buildroot-tpmdd.git/ > > > > > > > > > > The "ARM version" is at this point in aarch64 branch. Over time I will > > > > > define tpmdd-x86_64 and tpmdd-aarch64 boards and everything will be then > > > > > in the master branch. > > > > > > > > > > To create identical images you just need to > > > > > > > > > > $ make tpmdd_defconfig && make > > > > > > > > > > Can you check if you see anything obviously wrong? I'm eager to test this > > > > > patch set, and in bigger picture I really need to have ready to run > > > > > aarch64 environment available. > > > > > > > > I would rather suggest you to follow steps listed here [1] as to test > > > > this feature on Qemu aarch64 we need to build firmwares such as TF-A, > > > > OP-TEE, UEFI etc. which are all integrated into OP-TEE Qemu build > > > > system [2]. And then it would be easier to migrate them to your > > > > buildroot environment as well. > > > > > > > > [1] https://lists.trustedfirmware.org/pipermail/op-tee/2020-May/000027.html > > > > [2] https://optee.readthedocs.io/en/latest/building/devices/qemu.html#qemu-v8 > > > > > > > > -Sumit > > > > > > Can you provide 'keyctl_change'? Otherwise, the steps are easy to follow. > > > > > > > $ cat keyctl_change > > diff --git a/common.mk b/common.mk > > index aeb7b41..663e528 100644 > > --- a/common.mk > > +++ b/common.mk > > @@ -229,6 +229,7 @@ BR2_PACKAGE_OPTEE_TEST_SDK ?= $(OPTEE_OS_TA_DEV_KIT_DIR) > > BR2_PACKAGE_OPTEE_TEST_SITE ?= $(OPTEE_TEST_PATH) > > BR2_PACKAGE_STRACE ?= y > > BR2_TARGET_GENERIC_GETTY_PORT ?= $(if > > $(CFG_NW_CONSOLE_UART),ttyAMA$(CFG_NW_CONSOLE_UART),ttyAMA0) > > +BR2_PACKAGE_KEYUTILS := y > > > > # All BR2_* variables from the makefile or the environment are appended to > > # ../out-br/extra.conf. All values are quoted "..." except y and n. > > diff --git a/kconfigs/qemu.conf b/kconfigs/qemu.conf > > index 368c18a..832ab74 100644 > > --- a/kconfigs/qemu.conf > > +++ b/kconfigs/qemu.conf > > @@ -20,3 +20,5 @@ CONFIG_9P_FS=y > > CONFIG_9P_FS_POSIX_ACL=y > > CONFIG_HW_RANDOM=y > > CONFIG_HW_RANDOM_VIRTIO=y > > +CONFIG_TRUSTED_KEYS=y > > +CONFIG_ENCRYPTED_KEYS=y > > > > > After I've successfully tested 2/4, I'd suggest that you roll out one more > > > version and CC the documentation patch to Elaine and Mini, and clearly > > > remark in the commit message that TEE is a standard, with a link to the > > > specification. > > > > > > > Sure, I will roll out the next version after your testing. > > Thanks, I'll try this at instant, and give my feedback. I bump into this: $ make run-only ln -sf /home/jarkko/devel/tpm/optee/build/../out-br/images/rootfs.cpio.gz /home/jarkko/devel/tpm/optee/build/../out/bin/ ln: failed to create symbolic link '/home/jarkko/devel/tpm/optee/build/../out/bin/': No such file or directory make: *** [Makefile:194: run-only] Error 1 /Jarkko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel