From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 879B2C433E0 for ; Sat, 23 Jan 2021 13:25:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 351D123331 for ; Sat, 23 Jan 2021 13:25:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 351D123331 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lExJbJn+hHZWUuZ+NfcMaGYSGxF5R+ThkrPOHqsM2c8=; b=ZBpTocwMCOvn1uC87GFEBYwiO GBCn1pgeDSzsWyJ9rRoum6MMdJ4iwvcXXka+8UQAe3UilU6c40qqOgSiZG83rIp5M5vhlUr78I8Ka l5K2WDOnirxIuKfhkreof7119bU7VweZejFi1K9htW8wXkCQXeMTbPBOWD9O/wv380Us/SeqYIdwf bfynFtAFe+gWX5bQAb8hVfkL40kCqiAQw/e/9QCe6aiWek4+6m7XNrZg58TOKY9PSqDCxhoiQDb6m sffWbpI6ZEpOM+iGWyQgUXAChVkXSe5bysqAAluCV8stt6+ngGqFRZpCEmdqsRsR6TtFj0pZ7HUhm 5PounWg3w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3ItF-0002ix-Nx; Sat, 23 Jan 2021 13:23:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3ItA-0002iN-54 for linux-arm-kernel@lists.infradead.org; Sat, 23 Jan 2021 13:23:41 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0AB7E23159; Sat, 23 Jan 2021 13:23:35 +0000 (UTC) Date: Sat, 23 Jan 2021 13:23:33 +0000 From: Catalin Marinas To: Marc Zyngier Subject: Re: [PATCH v4 12/21] arm64: cpufeature: Add an early command-line cpufeature override facility Message-ID: References: <20210118094533.2874082-1-maz@kernel.org> <20210118094533.2874082-13-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210118094533.2874082-13-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210123_082340_286283_5245B71A X-CRM114-Status: GOOD ( 11.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Jing Zhang , Prasad Sodagudi , Srinivas Ramana , Suzuki K Poulose , Alexandru Elisei , linux-kernel@vger.kernel.org, Ard Biesheuvel , James Morse , Julien Thierry , Ajay Patil , kernel-team@android.com, David Brazdil , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 18, 2021 at 09:45:24AM +0000, Marc Zyngier wrote: > diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S > index d74e5f84042e..b3c4dd04f74b 100644 > --- a/arch/arm64/kernel/head.S > +++ b/arch/arm64/kernel/head.S > @@ -435,6 +435,7 @@ SYM_FUNC_START_LOCAL(__primary_switched) > > mov x0, x21 // pass FDT address in x0 > bl early_fdt_map // Try mapping the FDT early > + bl init_shadow_regs > bl switch_to_vhe > #if defined(CONFIG_KASAN_GENERIC) || defined(CONFIG_KASAN_SW_TAGS) > bl kasan_early_init [...] > +void __init init_shadow_regs(void) Do we need an asmlinkage here? And a declaration somewhere to silence sparse (we did this for entry-common.c function even if the .S files don't consume the prototypes). -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel