From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6677C433E0 for ; Fri, 5 Feb 2021 13:34:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49F4864F6C for ; Fri, 5 Feb 2021 13:34:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49F4864F6C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8/5hFMAfYqHfgkgFjTM+73WbrhXeyGJYvbGLmu8HoGE=; b=aiDZFMpdVlP/WwRnZkIiZ7X+Z FJWkbfCx5xY4Wkkz3FhK9eb1ELd6pQSKzZuDD6lynR0QSuAOwULioDGWMhWS9NpOvwkL3qeKR/KPc b9QWiGnH6ERvQuLFlWSLg/gkJvL/7xZ9cV+0Eg8pjgRQWNagwDIJvBKM5oDnywaOue58wRFmY0m/i HIYCoaa2j64P03DxTKRN1Gs2LRNCrCxKhRYI5X38wwOALj+9nWglT8x0XrKZ3EHJ8WZm9+mPZsWVm LDSLeBLpMyyj9KP4gCuT1tXG3oxG6ZDHxJWn0g73s5Hzzcqcy2NK1sMRwHi2j5pFWdD3rwICnHTEj MLcRgi0cg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l81EX-0000bX-HM; Fri, 05 Feb 2021 13:33:13 +0000 Received: from muru.com ([72.249.23.125]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l81EU-0000ao-8N for linux-arm-kernel@lists.infradead.org; Fri, 05 Feb 2021 13:33:10 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id DBD5D8061; Fri, 5 Feb 2021 13:33:22 +0000 (UTC) Date: Fri, 5 Feb 2021 15:33:06 +0200 From: Tony Lindgren To: Grygorii Strashko Subject: Re: [PATCH 1/2] ARM: omap2plus_defconfig: Enable Netfilter components as modules. Message-ID: References: <20210203113426.18964-1-parazyd@dyne.org> <72a4133f-db13-db12-0949-017054bc8265@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <72a4133f-db13-db12-0949-017054bc8265@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210205_083310_343052_3EB6F816 X-CRM114-Status: GOOD ( 13.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-omap@vger.kernel.org, Ivan Jelincic , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Grygorii Strashko [210205 13:18]: > On 03/02/2021 13:34, Ivan Jelincic wrote: > > Enable the majority of the Netfilter components as loadable modules > > in the omap2plus_defconfig file. ... > > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig > > index f250bf1cc022..9847502d2c97 100644 > > --- a/arch/arm/configs/omap2plus_defconfig > > +++ b/arch/arm/configs/omap2plus_defconfig > > @@ -87,6 +87,155 @@ CONFIG_IP_PNP_DHCP=y > > CONFIG_IP_PNP_BOOTP=y > > CONFIG_IP_PNP_RARP=y > > CONFIG_NETFILTER=y > > +CONFIG_NF_CONNTRACK=m > > +CONFIG_NF_LOG_NETDEV=m > > +CONFIG_NF_CONNTRACK_ZONES=y > > +CONFIG_NF_CONNTRACK_EVENTS=y > > +CONFIG_NF_CONNTRACK_TIMEOUT=y > > +CONFIG_NF_CONNTRACK_TIMESTAMP=y > > +CONFIG_NF_CT_NETLINK=m > > [..] > > Do we really want to enable all these not TI specific configs? > The main purpose of omap2plus_defconfig is to enable TI specific HW and HW features and > config options required to tests/demonstrate these features - like support for some networking > HW offloads. Well these are loadable modules. And I'd like to have omap2plus_defconfig and multi_v7_defconfig usable as a base config for distros to use. For built-in options I agree. We should only enable absolute minimum for built-in optoins as otherwise things get even more bloated. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel