From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19F1CC433E0 for ; Wed, 27 Jan 2021 15:24:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C71B2079A for ; Wed, 27 Jan 2021 15:24:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C71B2079A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8BM9IRBBzQYTyk86BAWDco5sdkcr20VzTU4xUELNkNM=; b=XkYecLs2rBGEtaZSM1RpHWL/K QEp7WprbZLiRJvi9sP5LpZECAL+cI0MzsWr/ZCDqnmY7GUlGgFb9eG9lG/CcpC/2eacavJxRiffbQ Mdgl3/Heb0qWptXZW82PVYhqjMXUYaeNc3HrlVYJ1X4o6LpZh2tICSiPP5vlsxPo5lb9JSjwUltT8 G/VsOHBmtTKrAushHhnrHGsmoJ76udemZ8qKZhjY3qXggkTTgL2Wtd+uJn2tYFxNwVIOg4BdBur0C UdbiG/CJRMFhKHmWm21XPnx7UgPVyykYfL4L/aa+t3eEtcqoK1OKwjBCVRbbc/Q45d3GL+NGf05+k MZU3+N1Vw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4meI-0007FN-N4; Wed, 27 Jan 2021 15:22:26 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4mdq-0003be-Hp for linux-arm-kernel@merlin.infradead.org; Wed, 27 Jan 2021 15:21:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=AkjKYkZu/O3ZhL9C1ly1S1R+Lu1EqcZrKzNmqSx7LJM=; b=LbTFYFpOYwLCmqWjC0IloJwATu zlwdBnyG8eq7AWQo6cHXcBrktnVtqKbgpxweAd7Qvp00ehlNAeInCYCnitXvNjeflJFfeZ1iNpp0E ITCYQcVj5S3hDnSobVQHg/el/5O20T4UOCXifKYUC/Kdux5P+mnXVjssdAlZSHwsPHx5B2M/aUSef /k0RxefpQeLhbXvSbhr9Yt1SkoSxDHmyCYotRge+oC2BQRXzb0QdJxFM1oKpb5YO6WNWwFe4jbKq1 cAONxXR/kWo/niWQKC4KvC/sW4JVr9UuyA8Jao4XBLkByzsj+A9Jib+rYoj3hS4QE4NcTzXOjiyO3 Afvkk3vQ==; Received: from mail-ot1-x32d.google.com ([2607:f8b0:4864:20::32d]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1l4ltK-0077jD-SD for linux-arm-kernel@lists.infradead.org; Wed, 27 Jan 2021 14:34:09 +0000 Received: by mail-ot1-x32d.google.com with SMTP id h14so1831118otr.4 for ; Wed, 27 Jan 2021 06:33:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=AkjKYkZu/O3ZhL9C1ly1S1R+Lu1EqcZrKzNmqSx7LJM=; b=ds5cTovti/PtWeJ9L9rKyAOoOCJlHao6cqyS9WX5rNXOcqjvrACFYWilYmHuy7YEyU Zr2gd5FdUeJLOW4mz/aprPbp4jYKkyWlUXgrn9h3WYr3u6hB8NAXTQzpnelYnHsugmKZ 8PMgx78aR3uz8ZN6yPR1Fkrs+Kt5ya4IVDz5OvzISuhkLEicnFWhBEqdIXCZprV357r3 980hdxNsheXU0huewLbFRO07m8egm/Zkuhqmd8q/0jApuDMAriwEoDScJaO8OaW6pD60 J9WcOsudPLTYDO1sGadIy6cBl0PLr/9byY+lSqueuNJHlLE2zEF6GcacqQhYJS9jvbWy qo+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=AkjKYkZu/O3ZhL9C1ly1S1R+Lu1EqcZrKzNmqSx7LJM=; b=pDQH7Ffocm/16A93O3mCCNBfYBd+8GJpr4XexdIUb20m3uogxyiSpBD3HfPCvqB2I8 EOAkFUogGPD7AMjD0p47miORvx5Ffk+BurPIBab75uwQtkygxnpYv4rK59oNQxpz3YMP T+OoW9LheftSoxOCNf/puFvJHVk2xk36f8vHsPhoZ0haSp560u6bMInM/YUlq5yiqTDl 6/Nxuck5wPEcOjbt2IU+ny4fmdBC8HxHIyO9P2YIAP/1WJU5RhFhJlOljPBF/qDy/hMO XEEMUluigvRzsejrGddYngeLDABI4DgWf5OVS6FgIjINcCU0dGxBzmLqhJ/GxKTR98vZ o7mQ== X-Gm-Message-State: AOAM531JPqq51M2jI8Z91V69tLUcY3ZtCYJLbAQEw+65zbYYwbK4iqvZ Wrp9/vgFYAhx2bDBz90UTzciBg== X-Google-Smtp-Source: ABdhPJwmTqQPsWpvtbjcC2msBX3cGjNcoI9u2JDtZqhZPL4fnGyhqt4gHpM29qTSW+yW9tkibHcSxA== X-Received: by 2002:a9d:5cc3:: with SMTP id r3mr8437957oti.286.1611757950813; Wed, 27 Jan 2021 06:32:30 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id o98sm404617ota.0.2021.01.27.06.32.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 06:32:30 -0800 (PST) Date: Wed, 27 Jan 2021 08:32:28 -0600 From: Bjorn Andersson To: "N?colas F. R. A. Prado" Subject: Re: [PATCH v2 4/4] ARM: dts: qcom: pm8941: Add nodes for QCOM SPMI Flash LEDs Message-ID: References: <20210126140240.1517044-1-nfraprado@protonmail.com> <20210126140240.1517044-5-nfraprado@protonmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210126140240.1517044-5-nfraprado@protonmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210127_143409_233256_812D35A3 X-CRM114-Status: GOOD ( 17.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, lkcamp@lists.libreplanetbr.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Andy Gross , Russell King , Luca Weiss , Rob Herring , linux-leds@vger.kernel.org, Pavel Machek , andrealmeid@collabora.com, Brian Masney , Georgi Djakov , linux-arm-kernel@lists.infradead.org, Dan Murphy Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue 26 Jan 08:06 CST 2021, N?colas F. R. A. Prado wrote: > Add the necessary devicetree nodes for the Qualcomm SPMI Flash LEDs > present in PM8941. > = > Signed-off-by: N=EDcolas F. R. A. Prado > --- > Changes in v2: > - Moved from hammerhead dts to pm8941 dtsi, as it was this way downstream > - Now using values from leds-qcom-spmi-flash.h > = > arch/arm/boot/dts/qcom-pm8941.dtsi | 38 ++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > = > diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-= pm8941.dtsi > index c1f2012d1c8b..89309d3c777c 100644 > --- a/arch/arm/boot/dts/qcom-pm8941.dtsi > +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi > @@ -2,6 +2,8 @@ > #include > #include > #include > +#include > +#include > = > &spmi_bus { > = > @@ -189,5 +191,41 @@ pm8941_5vs2: 5vs2 { > regulator-initial-mode =3D <1>; > }; > }; > + > + qcom,spmi-flash@d300 { Please avoid "qcom," in the node names. > + status =3D "okay"; The "default" status is "okay", so no need to specify that if you're not disabling it. That said, there are 8974 devices without flash LED... > + > + compatible =3D "qcom,spmi-flash"; > + reg =3D <0xd300 0x100>; > + flash-boost-supply =3D <&pm8941_5vs1>; > + torch-boost-supply =3D <&pm8941_5v>; > + pm8941_flash0: led0 { > + led-sources =3D <0>; > + function =3D LED_FUNCTION_FLASH; > + color =3D ; > + led-max-microamp =3D <200000>; > + flash-max-microamp =3D <1000000>; > + flash-max-timeout-us =3D <1280000>; > + default-state =3D "off"; > + qcom,clamp-curr =3D <200000>; > + qcom,headroom =3D ; > + qcom,startup-dly =3D ; > + qcom,safety-timer; ...and I would expect that at least some of these properties should be tweaked/tuned/reviewed for each device. So it would probably be a good idea to make the spmi-flash status "disabled" and move some of these properties to the product .dts. Regards, Bjorn > + }; > + > + pm8941_flash1: led1 { > + led-sources =3D <1>; > + function =3D LED_FUNCTION_FLASH; > + color =3D ; > + led-max-microamp =3D <200000>; > + flash-max-microamp =3D <1000000>; > + flash-max-timeout-us =3D <1280000>; > + default-state =3D "off"; > + qcom,clamp-curr =3D <200000>; > + qcom,headroom =3D ; > + qcom,startup-dly =3D ; > + qcom,safety-timer; > + }; > + }; > }; > }; > -- = > 2.30.0 > = > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel