From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33BACC433DB for ; Wed, 27 Jan 2021 19:43:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3E6364DA0 for ; Wed, 27 Jan 2021 19:43:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3E6364DA0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uUV6VEmwEqb0MyeO+mQlQhhZm17k45t6uIcFt7Qp+eI=; b=zBueuzK97jB6b+ZTw6MA8tTr0 9zvdX2w6nUSUeeKF0o81Ek5LxU+g9kpOFW6WYst7fHT9EG5GxBMoEyIIELu40jP0XjY79hhDkhSrl IkH40GdjOKK7/ii7SXg3Mv6DJvBd5FdpLI+A0r4tpH5J4X4QxBhththuMk6u0blXGSOEuVIR8kxG7 VQq96LxdnUWeLiFamOw9Pdy2ihk8WdSaSG7NT2UC29I6yOmZ9WKZ6rZWBTUQEg2iljJa6NTnRgYEU vWy68Ty/jEKvUeUngKFjfPgXZ5Yb/Wu3i6Qr0MeVBKgvQEDsz4Fm0MjZfUau70ejObOv+/AepQJSe c3Es0+TpQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4qhu-0003ca-9t; Wed, 27 Jan 2021 19:42:26 +0000 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4qhr-0003cA-6O for linux-arm-kernel@lists.infradead.org; Wed, 27 Jan 2021 19:42:23 +0000 Received: by mail-pg1-x534.google.com with SMTP id o63so2273705pgo.6 for ; Wed, 27 Jan 2021 11:42:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=X9ffNFlIUOYVUPnD1D6PGLhxnOW/mJ8sX1Tm/n1QVRc=; b=ezPnDL2LMwRcLe65hsEsXmLKlGtJdCsB6uCpnqhGFf696p0/UOcI+4RnnEu/dusIjw KrBR172CEf1HjdgIDWKQx16bTRpBkwGAOge5JFy4TzCCjj69ZNbk3Btd1zg7GA9sCR9x BRw9uAy1DObBWEdjQ73jCstu51vL5uPbuBifN4xRfwgAxJiL3sX8KbEeNMPWIGHKI7Ox 7RyrXnZ3NuHJ0vrQ1nwFyiT5cTi6Ryn45XlNEbjzA8mYWOJdZAcBnhJ2WtrWcAp2qn3A mtworgbfOL8HXHFs2o9uRQyHR1Sj87entcIK4Ryo2FvZBT0LPRigECq0SqPDnKocPTab lPEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=X9ffNFlIUOYVUPnD1D6PGLhxnOW/mJ8sX1Tm/n1QVRc=; b=dG8EvdraU0TdKvg9uwVqFtaQsXjHLNEtHtHwGIkw0gG/hthov67sFIxjw/M0aVXq8S xuo3iyw7qk03NzBEfe6cmykO8Ek5ZwH2/lOrcoMqhGkMCyULzo4REGF5TTVekw/+K/DL mzAF4IgfnvqHZX/M6mzHI98a9JAPPOsNh9ONOuqG+D4ceBiQDUWhVpgcU8y/zAsWEEMv WvAm1+s9VoUEVCMMvBz3Yx7AbhphTuehPUAZ1wR9wkCnijnD7cc9u1Fk58FK2zT5WxCH Agmn3PnzlXuGKW01xNhGaaBgimm1nRXGuKEaOlYRSjEAZjqb71HNj8cey/L6j8/bD6Gb eB2A== X-Gm-Message-State: AOAM532Jalvc9Pd9FMHwEyG6rZuCBe2ui11f+JrS9Uth+ZwRR0qHssXE 1iDOTgZY7nOvKBrcR+SyQKo= X-Google-Smtp-Source: ABdhPJwjLoRW6RHZSMApr5bBgvGKK1SJNLsW6E8ygt4XuhYvFKuiiEzuhh8bLcenhYSg8AEgNq2o3Q== X-Received: by 2002:a62:9248:0:b029:1ae:8b24:34c8 with SMTP id o69-20020a6292480000b02901ae8b2434c8mr11939333pfd.67.1611776540348; Wed, 27 Jan 2021 11:42:20 -0800 (PST) Received: from google.com ([2620:15c:202:201:a6ae:11ff:fe11:fcc3]) by smtp.gmail.com with ESMTPSA id e68sm3222040pfe.23.2021.01.27.11.42.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 11:42:18 -0800 (PST) Date: Wed, 27 Jan 2021 11:42:15 -0800 From: Dmitry Torokhov To: Andre Przywara Subject: Re: [PATCH v5 05/20] Input: axp20x-pek: Bail out if AXP has no interrupt line connected Message-ID: References: <20210127172500.13356-1-andre.przywara@arm.com> <20210127172500.13356-6-andre.przywara@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210127172500.13356-6-andre.przywara@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210127_144223_273889_3A93888F X-CRM114-Status: GOOD ( 14.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Samuel Holland , Yangtao Li , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , =?iso-8859-1?Q?Cl=E9ment_P=E9ron?= , linux-input@vger.kernel.org, Shuosheng Huang , Lee Jones , linux-arm-kernel@lists.infradead.org, Icenowy Zheng Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andre, On Wed, Jan 27, 2021 at 05:24:45PM +0000, Andre Przywara wrote: > On at least one board (Orangepi Zero2) the AXP305 PMIC does not have its > interrupt line connected to the CPU (mostly because the H616 SoC does > not feature an NMI pin anymore). > After allowing the AXP driver to proceed without an "interrupts" > property [1], the axp20x-pek driver crashes with a NULL pointer > dereference (see below). > > Check for the regmap_irqc member to be not NULL before proceeding with > probe. This gets normally filled by the call to regmap_add_irq_chip(), > which we allow to skip now, when the DT node lacks an interrupt > property. No, the driver is not the right place to patch this; regmap should be fixed so it does not crash instead. Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel