From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DCE7C433E0 for ; Thu, 28 Jan 2021 13:32:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B81C764DD8 for ; Thu, 28 Jan 2021 13:32:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B81C764DD8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=boundarydevices.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3otAjnN6RJt+CM/c+CTttD9T+TMSWsL7aYseM2G0tMQ=; b=LDFCBgKKIwcktAAGDpK8unsRL I2pmxJ15n4gvuhDS17nbI8q/GmkK72P6wDl0qTilG+XRCyMbVuiS3q23XbClxx4WEw2nNQtgDwgQG TKgmsbz/mc8RblVwAEqkhOio40bsHMhdKytfVrD1lsQ39kOdzZjnFAnU06LY6lE7E+Jho0VNjhcbZ 244PjIiq31wb1O9V/s3OUfqTm35i4OL89HW6ER97hKLfVUUqLn2rimb1t2+QDtQjEvPiduLknXDkA jkOMIY7WKZK7SIozx4cZd8Ei5ToRo/qyxDC94k/NQDC8IEpHk+rMWg5CEcRHRff+vhsu4CmPojIE4 mWyT7paLQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l57Nt-0001Gy-SG; Thu, 28 Jan 2021 13:30:53 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l57Nq-0001Ff-PL for linux-arm-kernel@lists.infradead.org; Thu, 28 Jan 2021 13:30:51 +0000 Received: by mail-wm1-x336.google.com with SMTP id m1so1312554wml.2 for ; Thu, 28 Jan 2021 05:30:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boundarydevices.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=94FMt5sdOQuvuur1w1p4IxKcptSx9rGgTLf5Xxc88cE=; b=Tg1GhLVbO1HpM1UYAbNZrOTCbj57bouBNfEz7xkktaLQisi+PU6CVuJq5A6s8XixsY eSZ28Z+P/1dXc7FwrT6Fa1rQDa7f9xyrHRzZlV4fluStCiEOr3Cv2ulVFTIUqgCeLsHH Q9/ou1cTESQTHEpZGKDV1upPCsi+F0SzfpKL4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=94FMt5sdOQuvuur1w1p4IxKcptSx9rGgTLf5Xxc88cE=; b=IjnonuTn55PqIGXY6EFyvUDuG83q9RPJdNJyNNkxCsHJt2Y9zD7lb0OlDtM8Dsxe+5 I+StWcvmha4svYUtJ9k+A6bW1cQCbLCRRLoekUPC8nwAvajVR0SPrwafmrpfC1rliLLb KZCangY0liH/M+3jygKxQFh85mdsuapLuR+O4mHmjoElFJiPNRFfGWpHCjZAKiAONFCf HfGCCHPCfBIwY2TcpltoZXAupcTuzwPKOeZ5ybLFnYN0juSWabStzOstNTzHDmLEBUqv NfB5rsAWe82mh/omwkRgTnfz73gJ0N26oFCNyyzyRDwKNM4bVsEcwf44zaDmuEtv9131 nMCQ== X-Gm-Message-State: AOAM5318iN0BE95bGtMvHDF6Y/MaVLQcmnk2Hqze1X3eA8YCksunSrly cpErn3ym+iIuz0lh9qUoJl5K9g== X-Google-Smtp-Source: ABdhPJx4hoGuJUwRAjCeV2TM+T4nHcjhcKWZYU/NeIX3pdgYLRh3ne2/SpQJEWn2xbHSd+7moJLbdQ== X-Received: by 2002:a1c:5412:: with SMTP id i18mr8635150wmb.152.1611840647150; Thu, 28 Jan 2021 05:30:47 -0800 (PST) Received: from p1g2 (2a01cb000f9f0e008f0bd0d6ec94dd0e.ipv6.abo.wanadoo.fr. [2a01:cb00:f9f:e00:8f0b:d0d6:ec94:dd0e]) by smtp.gmail.com with ESMTPSA id y24sm5817751wmi.47.2021.01.28.05.30.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 05:30:46 -0800 (PST) Date: Thu, 28 Jan 2021 14:30:44 +0100 From: Gary Bisson To: Adrien Grassein Subject: Re: [PATCH] arm64: dts: imx8mq-nitrogen: add USB support Message-ID: References: <20210126215511.1056600-1-adrien.grassein@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210126215511.1056600-1-adrien.grassein@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210128_083050_954367_99C6AA58 X-CRM114-Status: GOOD ( 19.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, troy.kisky@boundarydevices.com, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Adrien, Thanks for improving Nitrogen upstream, much appreciated. On Tue, Jan 26, 2021 at 10:55:11PM +0100, Adrien Grassein wrote: > add USB support for imx8mq-nitrogen. It consists > in 2 phys: OTG and host. > > The OTG port uses a dedicated regulator for vbus. > > Signed-off-by: Adrien Grassein > --- > .../boot/dts/freescale/imx8mq-nitrogen.dts | 36 +++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts b/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts > index 81d269296610..fb8acd83a280 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dts > @@ -34,6 +34,17 @@ power { > }; > }; > > + reg_usb_otg_vbus: regulator-usb-otg-vbus { > + compatible = "regulator-fixed"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_reg_usbotg_vbus>; > + regulator-name = "usb_otg_vbus"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + gpio = <&gpio1 12 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + }; > + > reg_vref_0v9: regulator-vref-0v9 { > compatible = "regulator-fixed"; > regulator-name = "vref-0v9"; > @@ -190,6 +201,25 @@ &uart2 { > status = "okay"; > }; > > +&usb_dwc3_0 { > + dr_mode = "otg"; > + status = "okay"; Please add a pinctrl here to mux GPIO1_IO13 as over current pin. But I confirm the port is working. > +}; > + > +&usb3_phy0 { > + vbus-supply = <®_usb_otg_vbus>; > + status = "okay"; > +}; > + > +&usb_dwc3_1 { > + dr_mode = "host"; > + status = "okay"; > +}; The Host port doesn't work for me. This is because of the missing reset signal. Maybe it's time to revive the gpio-reset driver [1]? Anyway, here is how to fix the USB Host ports: # gpioset 0 14=1 I guess it'd be best to have a proper reset solution before merging the host port addition. Regards, Gary [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/1374834384-8071-1-git-send-email-p.zabel@pengutronix.de/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel