From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Zhanyong Wang <zhanyong.wang@mediatek.com>,
Mathias Nyman <mathias.nyman@intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Tianping Fang <tianping.fang@mediatek.com>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Ikjoon Jang <ikjn@chromium.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7] usb: xhci-mtk: fix unreleased bandwidth data
Date: Fri, 29 Jan 2021 11:27:51 +0100 [thread overview]
Message-ID: <YBPjJ8CCLcBjg42S@kroah.com> (raw)
In-Reply-To: <1611913099-25805-1-git-send-email-chunfeng.yun@mediatek.com>
On Fri, Jan 29, 2021 at 05:38:19PM +0800, Chunfeng Yun wrote:
> From: Ikjoon Jang <ikjn@chromium.org>
>
> xhci-mtk needs XHCI_MTK_HOST quirk functions in add_endpoint() and
> drop_endpoint() to handle its own sw bandwidth management.
>
> It stores bandwidth data into an internal table every time
> add_endpoint() is called, and drops those in drop_endpoint().
> But when bandwidth allocation fails at one endpoint, all earlier
> allocation from the same interface could still remain at the table.
>
> This patch moves bandwidth management codes to check_bandwidth() and
> reset_bandwidth() path. To do so, this patch also adds those functions
> to xhci_driver_overrides and lets mtk-xhci to release all failed
> endpoints in reset_bandwidth() path.
>
> Fixes: 08e469de87a2 ("usb: xhci-mtk: supports bandwidth scheduling with multi-TT")
> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> Changes in v7 from Chunfeng:
> - rename xhci_mtk_droop_ep() as destroy_sch_ep(), and include parameters
> - add member @allocated in mu3h_sch_ep_info struct
> used to skip endpoint not allocated bandwidth
> - use xhci_dbg() instead of dev_dbg()
> - rename bw_ep_list_new as bw_ep_chk_list
As a previous version of this patch is already in my public tree, just
send a follow-on patch that resolves the issues in the previous one, as
I can not apply this one. Bonus is that you get the credit for fixing
these issues :)
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-29 10:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 9:38 [PATCH v7] usb: xhci-mtk: fix unreleased bandwidth data Chunfeng Yun
2021-01-29 10:27 ` Greg Kroah-Hartman [this message]
2021-02-01 2:04 ` Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBPjJ8CCLcBjg42S@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chunfeng.yun@mediatek.com \
--cc=ikjn@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=tianping.fang@mediatek.com \
--cc=zhanyong.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).