From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AA22C433E0 for ; Sat, 30 Jan 2021 02:06:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E47A560235 for ; Sat, 30 Jan 2021 02:06:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E47A560235 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XRKCciQ9xKAJ2vw1X/uKqrOQajNZCqAqynA0JIlI2ic=; b=JuRC9sD4LPd4AVQotCejcWJXi kfIu2WiYLcA5IXCkqbt+YCzzzWaAb3z+g97EqnzRiEVAnFtMkcXRYx95/SM+tWpOVJ31CUOPgaUwe AcvX46GRVt0vKnL1u8XQe3VqrFZLqu+FLGbPE0l4Sb2aAo/Ea5OEqR1sIlDfou3tlqvJZEW7bLd9X Etv4zZBdWmEyWX7FmVvF6lMqZ9+0X0KJoC9S60gF9dTU4DldGnfd3toBh2/gfSVzUQAlxsRc4NvaK H77/jGaABOGM0g3KLFwYzFOY9MmLnszFq+hdPfkg7RCg4NmnIgvcwGsJQfzksyLOqBhV+JyRuFv7X iWLa/NcAA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5fdb-0005KJ-Rh; Sat, 30 Jan 2021 02:05:23 +0000 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5fdY-0005Jq-Gk for linux-arm-kernel@lists.infradead.org; Sat, 30 Jan 2021 02:05:21 +0000 Received: by mail-pg1-x534.google.com with SMTP id i7so7836429pgc.8 for ; Fri, 29 Jan 2021 18:05:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ha7cDz5klKkhTpo5euIGmAiyN3F0x/AzncqZSAgqejk=; b=gXR8TWL/GSbd+BTSOP7hYzzftfT6KysHK8MDtcvvrv7lkJwp6yDYfopWO2YQtSFU/z qCbuQWYuQLiEZwNsg3CYEffQ7uaPbZaAgGYGVFAAfqG0vvF1JjM+xw1HxpILhoVSnzrA EykpOAobH6zmXt6HEo9kpDu0g6SFLJfn7tMylftAHI8hIIluwA0+djpJIK6VuIgqr+BL AvPb7LwunNl57GE7hk8NrZKwfbcf2HnF2bP/IhPGmGJpQPIXrEB2w6qZizc162ww5bHc oS8BfU6429CXAjnLRlHqmaYwCKhHabOzkLV0n31o4tQ0L5/Xq7Xj8MR2BdbrGXCcexZH wYjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ha7cDz5klKkhTpo5euIGmAiyN3F0x/AzncqZSAgqejk=; b=L/KmjN1Lqil3M3qSY6g2UlXzIivlyPJ2WbhuLkgYDwyWgX+1VFP1nEJGykVYiM5WWm XAcxIBJry/M0AsKBqwpwjTPNecnVOIcrsPFvnsNchMK60X1+HLagXzbHGXBGSSdJAWzt ng/7JBERgtuGhviFxakZoLSYuS/Af8/QjRqsvFBviL594WbrqXvf9/azeftlVJfA/xJc NXtaLH1iZruHu5iCbW55pKL4hBRTui34IDLd50BWQ6PSr6kG8UnYYxVEV7OuNbusey7l Zk0Q7//vDzp+WevuTyQ4A8PrTleZuOsagJPd0a15hy9Nz4bEs+onJpYYSjQoHHyTN7jD o40g== X-Gm-Message-State: AOAM532sow4tCBsR0hNujk9+3C7nMNmHlM2U6Whge14f8zvRiVsSz4du DL0uLBKz2MF4BI3heNI+W3Y= X-Google-Smtp-Source: ABdhPJx0EIXCj480w9Vp1E2CYYaLdZyMWKfY3IJeVtmActSGPlYN2Ja1peCL+8dcxWIfJ8557FG1Tw== X-Received: by 2002:a63:34c8:: with SMTP id b191mr7133032pga.405.1611972318297; Fri, 29 Jan 2021 18:05:18 -0800 (PST) Received: from shinobu (113x33x126x33.ap113.ftth.ucom.ne.jp. [113.33.126.33]) by smtp.gmail.com with ESMTPSA id q15sm8101034pfk.181.2021.01.29.18.05.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Jan 2021 18:05:17 -0800 (PST) Date: Sat, 30 Jan 2021 11:05:08 +0900 From: William Breathitt Gray To: Srinivas Neeli Subject: Re: [PATCH V5 5/5] gpio: gpio-xilinx: Add check if width exceeds 32 Message-ID: References: <1611930410-25747-1-git-send-email-srinivas.neeli@xilinx.com> <1611930410-25747-6-git-send-email-srinivas.neeli@xilinx.com> MIME-Version: 1.0 In-Reply-To: <1611930410-25747-6-git-send-email-srinivas.neeli@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210129_210520_738444_1E5D61DC X-CRM114-Status: GOOD ( 16.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, sgoud@xilinx.com, linus.walleij@linaro.org, shubhrajyoti.datta@xilinx.com, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, bgolaszewski@baylibre.com, git@xilinx.com, syednwaris@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============7825485752360956439==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7825485752360956439== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5ks6C7Cgywkx2xlR" Content-Disposition: inline --5ks6C7Cgywkx2xlR Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 29, 2021 at 07:56:50PM +0530, Srinivas Neeli wrote: > Add check to see if gpio-width property does not exceed 32. > If it exceeds then return -EINVAL. >=20 > Signed-off-by: Srinivas Neeli > Reviewed-by: Linus Walleij Acked-by: William Breathitt Gray > --- > Changes in V5: > -None > Changes in V4: > -New patch. > --- > drivers/gpio/gpio-xilinx.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c > index acd574779ca6..b411d3156e0b 100644 > --- a/drivers/gpio/gpio-xilinx.c > +++ b/drivers/gpio/gpio-xilinx.c > @@ -589,6 +589,9 @@ static int xgpio_probe(struct platform_device *pdev) > if (of_property_read_u32(np, "xlnx,gpio-width", &chip->gpio_width[0])) > chip->gpio_width[0] =3D 32; > =20 > + if (chip->gpio_width[0] > 32) > + return -EINVAL; > + > spin_lock_init(&chip->gpio_lock); > =20 > if (of_property_read_u32(np, "xlnx,is-dual", &is_dual)) > @@ -613,6 +616,8 @@ static int xgpio_probe(struct platform_device *pdev) > &chip->gpio_width[1])) > chip->gpio_width[1] =3D 32; > =20 > + if (chip->gpio_width[1] > 32) > + return -EINVAL; > } > =20 > chip->gc.base =3D -1; > --=20 > 2.7.4 >=20 --5ks6C7Cgywkx2xlR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAmAUvrwACgkQhvpINdm7 VJJ4nxAAzRkaHQUnewnwSrydk2mHrYamMVGPzFWsrG5heOgcxrEaAbJ9rOwBatxf dD7LHpGbskMBf00hNxa7iUOjBUFAje2upwxTtlNRjguNzufAGvSlmk4EVC7PKndp 1fLAgx3Id7tXhfPIxcYxfcXNB+gtdfN/LLzPj0kNEXButa+gP28o70WcRNdiHnq0 2j0zb/GGzGF9asVrYD5GlGUGyMNEMHLZO7SPTAvZZgAzjGK9zzYjbZqNvTKOXocZ l0WTrm9H1TqSXeC0nSRQjAmB8TyKPuiSVXCmIag8GZGqw3l9l5YT6095eLu0kH8Z dP6ffXa56z/gwURT2cjr38862tRdAmGetpe5lynOKJYgosUTgsgvmZ809QtRUr7d oX7t7CAkOi71h3crUFwPacaxqtlyXL/75nfBksCVfsmMBZvWDS+xGuMNYwRb27R8 lEPzZogvr1LLZ9BtJkHK8p1B/9M2d0hPCEXLiLxqGcVyXml2m1xAamTO6JEvLNmi OdDZSs9NqHtF0tg8C2+VHhGk12urEp3xMU2BnEX8iHOZ7LvGNkAUpfdP6I8pbpE4 1xx5DImBicQ4M7vI9w2M0058rPuwkSSVMOcRpmeXkjg9LezpWevT6hq/rrOEIhWo fKFpB1KKoMYZl92sK1D4p1mjINxbNI9Mn0zUtIQp4shRE2A59Z8= =utiP -----END PGP SIGNATURE----- --5ks6C7Cgywkx2xlR-- --===============7825485752360956439== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7825485752360956439==--