From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B60AFC433E0 for ; Tue, 2 Feb 2021 09:58:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4999164F50 for ; Tue, 2 Feb 2021 09:58:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4999164F50 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T5LXanU/DPT1KLeqArkEZLIihxkbWQLXk8ji0V7oPuE=; b=kGjBgVQDCvKNZkr9OsTm1UPES mfPVr4Ne/Cnpl62fkoKndWjPEWaf1nqSvx/D0ZKXcYdwXG7lsgso9bUhrsyEtAukryKDLSLnKIE/A LIGrfQOcQG9CPJALb/dN6Ru8moU96DXGnx+9UdXyMG8WjLI+jghnxAwIVjUADnvU2yPDi94ytbo/O jjki/RO/9EXrDenrUMRlamo2p6U4d7eKrS67bgHYqGdCwXpAisWpP7/YvqtATsiDfnBiMtaiMjh/o KlE+HwY6Ap0k0mSMfatHbuh/xOdJUZ+zr3UPyPyINvh1t3JtGicRe8XiukNJiMAhBYf04LYaJwKEp HlcJVuCGA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6sQi-0004Tp-Sr; Tue, 02 Feb 2021 09:57:05 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6sQg-0004Sc-L7 for linux-arm-kernel@lists.infradead.org; Tue, 02 Feb 2021 09:57:03 +0000 Received: from aptenodytes (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id BA0BA24000C; Tue, 2 Feb 2021 09:56:56 +0000 (UTC) Date: Tue, 2 Feb 2021 10:56:56 +0100 From: Paul Kocialkowski To: "H. Nikolaus Schaller" Subject: Re: BOG: commit 89c7cb1608ac3 ("of/device: Update dma_range_map only when dev has valid dma-ranges") seems to break Pinephone display or LCDC Message-ID: References: <81FE44A3-38C8-4B78-BB77-C09B4FC80B0A@goldelico.com> MIME-Version: 1.0 In-Reply-To: <81FE44A3-38C8-4B78-BB77-C09B4FC80B0A@goldelico.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210202_045702_863206_7E94AFE4 X-CRM114-Status: GOOD ( 20.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Frank Rowand , Linux Kernel Mailing List , Yong Wu , Discussions about the Letux Kernel , Robin Murphy , linux-arm-kernel Content-Type: multipart/mixed; boundary="===============2242093967816737227==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2242093967816737227== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FywNW6//oMEHP8B6" Content-Disposition: inline --FywNW6//oMEHP8B6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Nikolaus, On Tue 02 Feb 21, 10:18, H. Nikolaus Schaller wrote: > Hi, > since v5.11-rc6 my Pinephone display shows some moir=C3=A9 pattern. >=20 > I did a bisect between v5.11-rc5 and v5.11-rc6 and it told me that > the commit mentioned in the subject is the reason. >=20 > Reverting it makes the display work again and re-reverting fail again. >=20 > IMHO it seems as if the display DMA of the pinephone (allwinner suni-a54) > got influenced and stopped to scan the framebuffer. >=20 > The only dma-ranges I could find are defined here: >=20 > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >=20 > dma-ranges =3D <0x00000000 0x40000000 0xc0000000>; >=20 > but I can't tell if they are "valid" or not. >=20 > Any insights are welcome. And please direct to the right people/mailing l= ists > if they are missing. This may not be strictly the same thing, but is this patch in your tree: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210115175831.= 1184260-2-paul.kocialkowski@bootlin.com/ If not, it's worth a try to add it. If it is, it's worth doing a revert. My understanding is like DE2 does not need a particular DMA range and has D= RAM starting at 0x40000000 (just like the CPU) but it will map DRAM in a loop before and after this address. I suspect the issue shows because the pinephone has 2 GiB RAM while for oth= er boards with < 2 GiB RAM, removing 0x40000000 to the DMA addresses still poi= nts to the same location. So IMO the MBUS dma-ranges shouldn't apply to DE2. I think this is already the case in dt, but the mbus driver may add it if y= ou don't have that patch. I think I have a few A64 boards around, but probably not with 2 GiB RAM. If adding the patch doesn't help, I'll try to make a few test. Cheers! Paul --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --FywNW6//oMEHP8B6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmAZIegACgkQ3cLmz3+f v9GMSwf+M9LokGcpYmUUjM+QKbQiZN+fF/QxqEV2cZdtgl0cuDkv/sLpvDmmj5O4 LT75CStM2LUBo2KYk97saEHX+5KxDeOCDpcyKb+PiTIuCZ0K2XaxMoGSs24XBJHC +oPPXUWgZ5JowcwObvEyp9dnAjYeqSLmK8vtZs/n80hGWhvrvzf++Jdo0Qy+TAwK ltD54b3Y2Yl3P5jUB4SxmrK0/FPXOeId5yN8x316/rXEcCqntpMbTMjU1nqkAr4r ydOcWbqqdedPGVufLwvQaECPmBZrmI9Yxzsffbw3ijOrLAv5NHsSADG+D632WcgW tbDQj8VryIs602K1KVnMNWL+9oPxng== =x65B -----END PGP SIGNATURE----- --FywNW6//oMEHP8B6-- --===============2242093967816737227== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2242093967816737227==--