From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64BECC433DB for ; Tue, 2 Feb 2021 16:58:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B28D64E9A for ; Tue, 2 Feb 2021 16:58:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B28D64E9A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HDX5hrAOYUCcbgEf3p6rqkccm+9NuqPkHBocEtKCHZ8=; b=IeSC1Co0ovNil0bI0XUQD/5Ti zIhN9gZRghCxeyJ6xs3u1TgMfmFYgGGHISBwiYiMMBAYX9GuooI7zuH00uNiDCFD4R5caLWPZL310 O9Co3noVa9GS8eczPPoZRvo0spxUqDIX2abGK2hbDfetrfZiGtU+9osdVmZly5joyNLM+A1lIprwg fNfWY6JE4abbEhtx99rgax4rW9dpWVzefqvev853g7PAQ7i9/UhkMz08/298xRrfE/+JTBUETZ7qY Y5dzN4gQ5JrlbYK8SwHmrph716Dd8zVBv5lhqu0VpEA0gkdmkC/wvqujZY2o3YA4OGheyU0V/az/7 +LjZv29Rg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6yzg-0001Hu-TS; Tue, 02 Feb 2021 16:57:36 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6yzd-0001HE-U6 for linux-arm-kernel@lists.infradead.org; Tue, 02 Feb 2021 16:57:34 +0000 Received: by mail-wm1-x332.google.com with SMTP id l12so2071102wmq.2 for ; Tue, 02 Feb 2021 08:57:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lO7tj/Femn1+wEijzb4UKh0PnLxDA74JJSIXBjPCjcg=; b=emCtWBCSzNAR6zo9nqaF4fGZuOL3zOc2tIGPwlEafqDM3dv1vp5Ci1ONSFtdfh3++T mzX+vg6fhgdyhumEFT5SWWhOvljxP1Bso9nBLgTeZqdVWmcNTc9sNZ9za02+nsTsRahB E5Mi8/UGFb5X81E7RWyvc7gIrqqxwKHv9VcvGIxlOoQXSzl1hscp6gOeSXfkKFzfjMrv KSykYRzZvKF3sMMPyx0lkR1DypEcoQUnqiSk9cINQyKT9/3wwuibqVSr5JsWON+pGP1+ a1V1YgNJXJxrhczcOkiPxxx6wZcWXNkQ94120eEID0uRyslqRsYcrYZt3Mzl0uAkDKIH 5G/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lO7tj/Femn1+wEijzb4UKh0PnLxDA74JJSIXBjPCjcg=; b=reOrncLWn2aacuee0bbfH3kT5jby+QilcVoDo520mjssMRzD5+wYY/qaYcsevoJnE1 jPMsw/Y/op1kjB6c5xOWY6/JZxNxfgJhChwuIXLJ+XoPK4vKpW4azdJYI0AyBjZYmug4 bY/hLN+lIixkK+WtLKEzLVfW5FzyRI4U4dkdMbS5Ps9DPN7IpbhVpXflVRgQE2QGLZpe XUQcJEjqhT7Jgua0J1s2cA1oXxWO0D94HFwCo65wSIQim0EDH/0JHpEWTgc5g5k1xD5G w3DLQkI+fKTZoOzT1oCyYrb+2wLWtPSIc5zceyxtQCdAJaYw4JaI1o89Oz5clyIaqWk6 axIA== X-Gm-Message-State: AOAM532623T5Ds2DdUHGeZNJdOW8mspy7dAXAbBQRbt0ZUN61erWIFnO BGULSH15aOjsalqjJXroCYGVEw== X-Google-Smtp-Source: ABdhPJzKnlEb49Qzq1C7WH6rqxehd7nnWuFwXqi876IGzxU89iMEg3PBoEY8CsMHZqoxchz2OXRvFA== X-Received: by 2002:a1c:5608:: with SMTP id k8mr4448012wmb.91.1612285052531; Tue, 02 Feb 2021 08:57:32 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:f693:9fff:fef4:2449]) by smtp.gmail.com with ESMTPSA id j4sm32514546wru.20.2021.02.02.08.57.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Feb 2021 08:57:31 -0800 (PST) Date: Tue, 2 Feb 2021 17:57:25 +0100 From: Marco Elver To: Andrey Konovalov Subject: Re: [PATCH 03/12] kasan: optimize large kmalloc poisoning Message-ID: References: <8fdbf86842f4eaf2458ecd23d0844058dbc2c7a2.1612208222.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8fdbf86842f4eaf2458ecd23d0844058dbc2c7a2.1612208222.git.andreyknvl@google.com> User-Agent: Mutt/2.0.2 (2020-11-20) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210202_115734_047166_1EA383BD X-CRM114-Status: GOOD ( 24.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Branislav Rankov , Catalin Marinas , Kevin Brodsky , Will Deacon , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Peter Collingbourne , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 01, 2021 at 08:43PM +0100, Andrey Konovalov wrote: > Similarly to kasan_kmalloc(), kasan_kmalloc_large() doesn't need > to unpoison the object as it as already unpoisoned by alloc_pages() > (or by ksize() for krealloc()). > > This patch changes kasan_kmalloc_large() to only poison the redzone. > > Signed-off-by: Andrey Konovalov Reviewed-by: Marco Elver > --- > mm/kasan/common.c | 20 +++++++++++++++----- > 1 file changed, 15 insertions(+), 5 deletions(-) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index 128cb330ca73..a7eb553c8e91 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -494,7 +494,6 @@ EXPORT_SYMBOL(__kasan_kmalloc); > void * __must_check __kasan_kmalloc_large(const void *ptr, size_t size, > gfp_t flags) > { > - struct page *page; > unsigned long redzone_start; > unsigned long redzone_end; > > @@ -504,12 +503,23 @@ void * __must_check __kasan_kmalloc_large(const void *ptr, size_t size, > if (unlikely(ptr == NULL)) > return NULL; > > - page = virt_to_page(ptr); > + /* > + * The object has already been unpoisoned by kasan_alloc_pages() for > + * alloc_pages() or by ksize() for krealloc(). > + */ > + > + /* > + * The redzone has byte-level precision for the generic mode. > + * Partially poison the last object granule to cover the unaligned > + * part of the redzone. > + */ > + if (IS_ENABLED(CONFIG_KASAN_GENERIC)) > + kasan_poison_last_granule(ptr, size); > + > + /* Poison the aligned part of the redzone. */ > redzone_start = round_up((unsigned long)(ptr + size), > KASAN_GRANULE_SIZE); > - redzone_end = (unsigned long)ptr + page_size(page); > - > - kasan_unpoison(ptr, size); > + redzone_end = (unsigned long)ptr + page_size(virt_to_page(ptr)); > kasan_poison((void *)redzone_start, redzone_end - redzone_start, > KASAN_PAGE_REDZONE); > > -- > 2.30.0.365.g02bc693789-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel