From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3DC3C433E0 for ; Wed, 3 Feb 2021 23:53:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CC3964E50 for ; Wed, 3 Feb 2021 23:53:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CC3964E50 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IEQTBW05TmzFu7/hosqkd8ABoHe1/YEmsissqUh6BAY=; b=dmhuabSmIneX2sDRIc7rKVW3W 9iOEy1Op/fGHrmXk2dhKGdQLQrMNdtdOprihozEV5W+XHn5Qhll5N/EDyRRsPd9wr51riYVDeLARR Ssv5w1dUkIoD7NlbOUnHe3fDVUzhXpg9i99wFxY9/sM6ZUd7dk3HumPruMi4Y7ymWYoaP6qWp3Imj oK16Hsh09JLTvg9kIUSdNAxeDnPdbOPbmjuT5meGkxgUCOVU27gPAuMZV5k4jD0QE6VNElky6G9Nt 3eyMqbxYQSJFEQt92yWytvp3UNIeIlp1ZAUdor+pZUMuoqXmYl4TjOzKIy+GzmYSVTqCSRyE/NOJQ 9TYcoZGyg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7RwS-0000q8-Qo; Wed, 03 Feb 2021 23:52:12 +0000 Received: from mail-qt1-x82a.google.com ([2607:f8b0:4864:20::82a]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l7RwQ-0000pW-2l for linux-arm-kernel@lists.infradead.org; Wed, 03 Feb 2021 23:52:11 +0000 Received: by mail-qt1-x82a.google.com with SMTP id n8so1162660qtp.5 for ; Wed, 03 Feb 2021 15:52:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=LWDBz11RsEKuXQrdXFjH1+vI1NJWjWDUc79Y8gU0Dzs=; b=kHHIcea+bU3FPDTBvBjb7OFVs326OtyWwtSHA8j+Eu4SrBIECbq9n9BIcan8vJJiiy +A1dnpEAD8DwhSUtQnO//Vcp8elafTtdoQpS2Eq6eOQCE9i3MHDSGphLoQ9lBt+UM/Xs J7xKrf/7zeadMMutgrYPyKlMBILqm3bMsMtgegRXXsCmEaxyVf/H/nNIzGDaQcXEtgwj Ze7BpX+QH6Bov6ewYL7hAM3oMt42O8rkuDR1yifF8drKC/r/RgTh6dCM5upBqeNd5BS+ Bp42pgPuTdWPxTS4ZLnEGfFcaIf/C4AU8tNciDOTsct95eSzCMNMHfgV87mO2Lt4QigS BUow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=LWDBz11RsEKuXQrdXFjH1+vI1NJWjWDUc79Y8gU0Dzs=; b=Vu8t3iWDQGDJ45oPhgAqhT/yoVBFZkWbdKncgy1oMERGGxzJu97tK+1nNLvnSdcWS5 3x3V5KF37KlPrTXTqMWGFg0E1cxRpAgp7Pt6/vjPUQMtbArhUkdDOBw734CgG1AKZBtf F9HtFOmvWj2prt/qwft5ZAmDr62F41HJ4ZmnV6Xr/o5k56YigWEQzDIRxKWdN0nUlwf9 U9Asu53Dc19QKfbVie2xgB7+lSfVVXlQEb4Yujn9JPUKHEmsuVygA+MQQVXjeCPm/E1c ynwEFhSQlsobV3uWXHcOreDnZEYOw17ymlhXh4PZoYDMH+TSUj6CBhfYhckIZzX4ZM9p Qh4w== X-Gm-Message-State: AOAM531X3D5kzP4daR9GzNC9YGk0Bfit/xDjkyNn4hCx0pVoml6km/IF Jb4vfCdoVT10u82VsqaUKJ0= X-Google-Smtp-Source: ABdhPJz83XPsMoY6aRs2ze9gwQKINWz+j1LYlx9iJP8K3cN/DCePE+bN1MkIuBb3QVRs9iWRhM8Pzw== X-Received: by 2002:a05:622a:8a:: with SMTP id o10mr4931100qtw.9.1612396325963; Wed, 03 Feb 2021 15:52:05 -0800 (PST) Received: from Gentoo ([138.199.13.179]) by smtp.gmail.com with ESMTPSA id 202sm3384810qkj.92.2021.02.03.15.52.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 15:52:05 -0800 (PST) Date: Thu, 4 Feb 2021 05:21:54 +0530 From: Bhaskar Chowdhury To: Jakub Kicinski Subject: Re: [PATCH] drivers: net: ehternet: i825xx: Fix couple of spellings in the file ether1.c Message-ID: Mail-Followup-To: Bhaskar Chowdhury , Jakub Kicinski , Randy Dunlap , linux@armlinux.org.uk, davem@davemloft.net, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210203151547.13273-1-unixbhaskar@gmail.com> <20210203121352.41b4733d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 In-Reply-To: <20210203121352.41b4733d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210203_185210_215934_7B1E8AEB X-CRM114-Status: GOOD ( 20.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Randy Dunlap , linux-kernel@vger.kernel.org, linux@armlinux.org.uk, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============8218056686153868477==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8218056686153868477== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="G9hZZrgodwUjX8Ad" Content-Disposition: inline --G9hZZrgodwUjX8Ad Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline On 12:13 Wed 03 Feb 2021, Jakub Kicinski wrote: >On Wed, 3 Feb 2021 09:54:22 -0800 Randy Dunlap wrote: >> On 2/3/21 7:15 AM, Bhaskar Chowdhury wrote: >> > >> > s/initialsation/initialisation/ >> > s/specifiing/specifying/ >> > >> > Signed-off-by: Bhaskar Chowdhury >> >> Hi, >> >> $Subject has a typo/spello. > >This happens more than you'd think with spell fixies. Always makes me >chuckle. FWIW "net: i825xx:" is enough of a prefix, no need to >transcribe the entire directory path. > >> The 2 fixes below look good (as explained in the patch description), >> but: >> can you explain the 3 changes below that AFAICT do nothing? > I am so sorry that error like this lean in . I will fix that Randy..thank you... >I think we can jump to the conclusion that Bhaskar's editor cleanup up >trailing white space. > >Bhaskar please make sure that the patch does not make unrelated white >space changes. > >> > drivers/net/ethernet/i825xx/ether1.c | 10 +++++----- >> > 1 file changed, 5 insertions(+), 5 deletions(-) >> > >> > diff --git a/drivers/net/ethernet/i825xx/ether1.c b/drivers/net/ethernet/i825xx/ether1.c >> > index a0bfb509e002..0233fb6e222d 100644 >> > --- a/drivers/net/ethernet/i825xx/ether1.c >> > +++ b/drivers/net/ethernet/i825xx/ether1.c >> > @@ -885,7 +885,7 @@ ether1_recv_done (struct net_device *dev) >> > ether1_writew(dev, 0, priv(dev)->rx_tail, rfd_t, rfd_command, NORMALIRQS); >> > ether1_writew(dev, 0, priv(dev)->rx_tail, rfd_t, rfd_status, NORMALIRQS); >> > ether1_writew(dev, 0, priv(dev)->rx_tail, rfd_t, rfd_rbdoffset, NORMALIRQS); >> > - >> > + >> > priv(dev)->rx_tail = nexttail; >> > priv(dev)->rx_head = ether1_readw(dev, priv(dev)->rx_head, rfd_t, rfd_link, NORMALIRQS); >> > } while (1); >> > @@ -1031,7 +1031,7 @@ ether1_probe(struct expansion_card *ec, const struct ecard_id *id) >> > >> > printk(KERN_INFO "%s: ether1 in slot %d, %pM\n", >> > dev->name, ec->slot_no, dev->dev_addr); >> > - >> > + >> > ecard_set_drvdata(ec, dev); >> > return 0; >> > >> > @@ -1047,7 +1047,7 @@ static void ether1_remove(struct expansion_card *ec) >> > { >> > struct net_device *dev = ecard_get_drvdata(ec); >> > >> > - ecard_set_drvdata(ec, NULL); >> > + ecard_set_drvdata(ec, NULL); >> > >> > unregister_netdev(dev); >> > free_netdev(dev); >> > -- >> > 2.26.2 >> > >> >> > --G9hZZrgodwUjX8Ad Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEnwF+nWawchZUPOuwsjqdtxFLKRUFAmAbNxcACgkQsjqdtxFL KRVHwAf+Ln8hvEa+7y8Zo2IjmVGI+vDnyXaapcZTCwHTeqY5N/pWs5O80JqZMfqT EaHX8H2rXtICBFKIpW2V4gn1o8xDPYj76e9pQGSW1klMn/N3+zBcNaC7tLsdctai skyC0k+KPACWXHjQmLiS7KmXr5szYzgMhdmRQjpzBPmu1HzjcVE2mSuSVxHG977w JPZKO+eti+2BpYTHkJpZ48iy+VWB0leaszytLoJdvmpnfvt698jrG+3IpZJwtkTy rzpRg7R9Zg7EyhcT9pIImtBNH+WWW5l16E1qVrdBSRVAc94zkbi9d3dlVhQlO77G yfn/AUxdwIatcJ8BG4n8lCA4Z7dqBg== =y56c -----END PGP SIGNATURE----- --G9hZZrgodwUjX8Ad-- --===============8218056686153868477== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8218056686153868477==--